linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCHv3 00/10] ext4: Improve FC trace events
@ 2022-03-12  5:39 Ritesh Harjani
  2022-03-12  5:39 ` [PATCHv3 01/10] ext4: Remove unused enum EXT4_FC_COMMIT_FAILED Ritesh Harjani
                   ` (10 more replies)
  0 siblings, 11 replies; 27+ messages in thread
From: Ritesh Harjani @ 2022-03-12  5:39 UTC (permalink / raw)
  To: linux-ext4
  Cc: Jan Kara, Theodore Ts'o, Harshad Shirwadkar, linux-fsdevel,
	linux-kernel, Ritesh Harjani

Hello,

Please find the v3 of this patch series. I have included Reviewed-by tag
on all patches, except in [5-7] which were later added to address review
comments from Jan [1].

Changes since v2
================
v2 -> v3
1. Defined TRACE_DEFINE_ENUM(EXT4_FC_REASON_MAX) in [Patch 02/10]


Changes since RFC
================
RFC -> v2
1. Added new patch-5 ("ext4: Return early for non-eligible fast_commit track events")
2. Removed a trace event in ext4_fc_track_template() (which was added in RFC)
   from patch-6 and added patch-7 to add the tid info in callers of
   ext4_fc_track_template(). (As per review comments from Jan)


Testing
=========
Tested this with xfstests -g "quick"

Thanks again to Jan, Harshad for helping with reviews and Steve for helping with
TRACE_DEFINE_ENUM part in kernel trace events.


[RFC]: https://lore.kernel.org/linux-ext4/cover.1645558375.git.riteshh@linux.ibm.com/
[v2]: https://lore.kernel.org/linux-ext4/cover.1646922487.git.riteshh@linux.ibm.com/
[1]: https://lore.kernel.org/linux-ext4/20220223115313.3s73bu7p454bodvl@quack3.lan/

Ritesh Harjani (10):
  ext4: Remove unused enum EXT4_FC_COMMIT_FAILED
  ext4: Fix ext4_fc_stats trace point
  ext4: Convert ext4_fc_track_dentry type events to use event class
  ext4: Do not call FC trace event in ext4_fc_commit() if FS does not support FC
  ext4: Return early for non-eligible fast_commit track events
  ext4: Add new trace event in ext4_fc_cleanup
  ext4: Add transaction tid info in fc_track events
  ext4: Add commit_tid info in jbd debug log
  ext4: Add commit tid info in ext4_fc_commit_start/stop trace events
  ext4: Fix remaining two trace events to use same printk convention

 fs/ext4/fast_commit.c       |  95 ++++++++----
 fs/ext4/fast_commit.h       |   1 -
 include/trace/events/ext4.h | 298 +++++++++++++++++++++++-------------
 3 files changed, 258 insertions(+), 136 deletions(-)

--
2.31.1


^ permalink raw reply	[flat|nested] 27+ messages in thread

end of thread, other threads:[~2022-03-19  5:05 UTC | newest]

Thread overview: 27+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-12  5:39 [PATCHv3 00/10] ext4: Improve FC trace events Ritesh Harjani
2022-03-12  5:39 ` [PATCHv3 01/10] ext4: Remove unused enum EXT4_FC_COMMIT_FAILED Ritesh Harjani
2022-03-12  5:39 ` [PATCHv3 02/10] ext4: Fix ext4_fc_stats trace point Ritesh Harjani
2022-03-12 15:13   ` Steven Rostedt
2022-03-17 12:01   ` Sven Schnelle
2022-03-17 14:50     ` Ritesh Harjani
2022-03-17 15:22       ` Sven Schnelle
2022-03-17 16:00         ` Steven Rostedt
2022-03-17 16:11       ` Sven Schnelle
2022-03-17 17:43         ` Nathan Chancellor
2022-03-18  4:14           ` Ritesh Harjani
2022-03-18 15:32             ` Nathan Chancellor
2022-03-17 18:38         ` Steven Rostedt
2022-03-17 18:39     ` Steven Rostedt
2022-03-18 16:30       ` Steven Rostedt
2022-03-19  5:04         ` Ritesh Harjani
2022-03-12  5:39 ` [PATCHv3 03/10] ext4: Convert ext4_fc_track_dentry type events to use event class Ritesh Harjani
2022-03-12  5:39 ` [PATCHv3 04/10] ext4: Do not call FC trace event in ext4_fc_commit() if FS does not support FC Ritesh Harjani
2022-03-12  5:39 ` [PATCHv3 05/10] ext4: Return early for non-eligible fast_commit track events Ritesh Harjani
2022-03-15 21:43   ` Theodore Ts'o
2022-03-16  3:55     ` Ritesh Harjani
2022-03-12  5:39 ` [PATCHv3 06/10] ext4: Add new trace event in ext4_fc_cleanup Ritesh Harjani
2022-03-12  5:39 ` [PATCHv3 07/10] ext4: Add transaction tid info in fc_track events Ritesh Harjani
2022-03-12  5:39 ` [PATCHv3 08/10] ext4: Add commit_tid info in jbd debug log Ritesh Harjani
2022-03-12  5:39 ` [PATCHv3 09/10] ext4: Add commit tid info in ext4_fc_commit_start/stop trace events Ritesh Harjani
2022-03-12  5:39 ` [PATCHv3 10/10] ext4: Fix remaining two trace events to use same printk convention Ritesh Harjani
2022-03-13  4:45 ` [PATCHv3 00/10] ext4: Improve FC trace events Theodore Ts'o

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).