[PATCH] ext4: fix potential unnitialized variable

[PATCH] ext4: fix potential unnitialized variable

[Dan Carpenter]

Smatch complains "err" can be uninitialized in the caller.

    fs/ext4/indirect.c:349 ext4_alloc_branch()
    error: uninitialized symbol 'err'.

Set the error to zero on the success path.

Fixes: 8016e29f4362 ("ext4: fast commit recovery path")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
This is a static checker fix and I don't know this code very well...
Please review it extra carefully.

 fs/ext4/mballoc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 12b3f196010b..714f83632e3f 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -6113,6 +6113,7 @@ ext4_mb_new_blocks_simple(struct ext4_allocation_request *ar, int *errp)
 	ext4_mb_mark_bb(sb, block, 1, true);
 	ar->len = 1;
 
+	*errp = 0;
 	return block;
 }
 
-- 
2.43.0

Re: [PATCH] ext4: fix potential unnitialized variable

[Theodore Ts'o]

On Wed, 17 Apr 2024 21:10:40 +0300, Dan Carpenter wrote:
> Smatch complains "err" can be uninitialized in the caller.
> 
>     fs/ext4/indirect.c:349 ext4_alloc_branch()
>     error: uninitialized symbol 'err'.
> 
> Set the error to zero on the success path.
> 
> [...]

Applied, thanks!

[1/1] ext4: fix potential unnitialized variable
      commit: 3f4830abd236d0428e50451e1ecb62e14c365e9b

Best regards,
-- 
Theodore Ts'o <tytso@mit.edu>