From: Joseph Qi <joseph.qi@linux.alibaba.com>
To: "Theodore Y. Ts'o" <tytso@mit.edu>
Cc: Jan Kara <jack@suse.cz>, Joseph Qi <jiangqi903@gmail.com>,
Dave Chinner <david@fromorbit.com>,
Andreas Dilger <adilger@dilger.ca>,
Ext4 Developers List <linux-ext4@vger.kernel.org>,
Xiaoguang Wang <xiaoguang.wang@linux.alibaba.com>,
Liu Bo <bo.liu@linux.alibaba.com>
Subject: Re: [RFC] performance regression with "ext4: Allow parallel DIO reads"
Date: Thu, 22 Aug 2019 14:45:23 +0800 [thread overview]
Message-ID: <4e3606cf-34ae-6989-404a-de67324a4919@linux.alibaba.com> (raw)
In-Reply-To: <20190821033443.GI10232@mit.edu>
On 19/8/21 11:34, Theodore Y. Ts'o wrote:
> On Wed, Aug 21, 2019 at 09:04:57AM +0800, Joseph Qi wrote:
>> On 19/8/21 00:08, Theodore Y. Ts'o wrote:
>>> On Tue, Aug 20, 2019 at 11:00:39AM +0800, Joseph Qi wrote:
>>>>
>>>> I've tested parallel dio reads with dioread_nolock, it doesn't have
>>>> significant performance improvement and still poor compared with reverting
>>>> parallel dio reads. IMO, this is because with parallel dio reads, it take
>>>> inode shared lock at the very beginning in ext4_direct_IO_read().
>>>
>>> Why is that a problem? It's a shared lock, so parallel threads should
>>> be able to issue reads without getting serialized?
>>>
>> The above just tells the result that even mounting with dioread_nolock,
>> parallel dio reads still has poor performance than before (w/o parallel
>> dio reads).
>
> Right, but you were asserting that performance hit was *because* of
> the shared lock. I'm asking what leading you to have that opinion.
> The fact that parallel dioread reads doesn't necessarily say that it
> was because of that particular shared lock. It could be due to any
> number of other things. Have you looked at /proc/lock_stat (enabeld
> via CONFIG_LOCK_STAT) to see where the locking bottlenecks might be?
>
I've enabled CONFIG_LOCK_STAT and CONFIG_DEBUG_RWSEMS, but doesn't see
any statistics for i_rwsem. Am I missing something?
Thanks,
Joseph
next prev parent reply other threads:[~2019-08-22 6:45 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 9:22 [RFC] performance regression with "ext4: Allow parallel DIO reads" Joseph Qi
2019-07-23 11:17 ` Joseph Qi
2019-07-25 21:20 ` Andreas Dilger
2019-07-26 1:12 ` Joseph Qi
2019-07-27 1:57 ` Andreas Dilger
2019-07-27 2:16 ` Joseph Qi
2019-07-28 22:51 ` Dave Chinner
2019-07-30 1:34 ` Joseph Qi
2019-08-15 15:13 ` Jan Kara
2019-08-16 13:23 ` Joseph Qi
2019-08-16 14:57 ` Jan Kara
2019-08-20 3:00 ` Joseph Qi
2019-08-20 16:08 ` Theodore Y. Ts'o
2019-08-21 1:04 ` Joseph Qi
2019-08-21 3:34 ` Theodore Y. Ts'o
2019-08-22 6:45 ` Joseph Qi [this message]
2019-08-22 5:40 ` Dave Chinner
2019-08-23 7:57 ` Joseph Qi
2019-08-23 8:07 ` Joseph Qi
2019-08-23 10:16 ` Dave Chinner
2019-08-23 13:08 ` Joseph Qi
2019-08-24 2:18 ` Dave Chinner
2019-08-26 8:39 ` Jan Kara
2019-08-26 19:10 ` Andreas Dilger
2019-08-27 1:00 ` Joseph Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e3606cf-34ae-6989-404a-de67324a4919@linux.alibaba.com \
--to=joseph.qi@linux.alibaba.com \
--cc=adilger@dilger.ca \
--cc=bo.liu@linux.alibaba.com \
--cc=david@fromorbit.com \
--cc=jack@suse.cz \
--cc=jiangqi903@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=xiaoguang.wang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).