* [BUG] Possible bug of missing error return code in __ext4_journalled_writepage()
@ 2021-03-09 9:40 Jia-Ju Bai
0 siblings, 0 replies; only message in thread
From: Jia-Ju Bai @ 2021-03-09 9:40 UTC (permalink / raw)
To: tytso, adilger.kernel; +Cc: linux-ext4, linux-kernel
In __ext4_journalled_writepage():
......
inode_bh = ext4_journalled_write_inline_data(inode, len, page);
if (inode_bh == NULL)
goto out;
......
out:
unlock_page(page);
out_no_pagelock:
brelse(inode_bh);
return ret;
When inode_bh is NULL, ret is not assigned with an error code like -ENOENT.
I wonder whether this is intentional? Or ret should be assigned with
-ENOENT here?
Best wishes,
Jia-Ju Bai
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-03-09 9:40 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-09 9:40 [BUG] Possible bug of missing error return code in __ext4_journalled_writepage() Jia-Ju Bai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).