[PATCH -next] ext4: fix trailing whitespace

[PATCH -next] ext4: fix trailing whitespace

[Jack Qiu]

Made suggested modifications from checkpatch in reference to ERROR:
 trailing whitespace

Signed-off-by: Jack Qiu <jack.qiu@huawei.com>
---
 fs/ext4/balloc.c  | 2 +-
 fs/ext4/mballoc.c | 2 +-
 fs/ext4/namei.c   | 6 +++---
 fs/ext4/super.c   | 2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/fs/ext4/balloc.c b/fs/ext4/balloc.c
index 74a5172c2d83..9dc6e74b265c 100644
--- a/fs/ext4/balloc.c
+++ b/fs/ext4/balloc.c
@@ -239,7 +239,7 @@ unsigned ext4_free_clusters_after_init(struct super_block *sb,
 				       ext4_group_t block_group,
 				       struct ext4_group_desc *gdp)
 {
-	return num_clusters_in_group(sb, block_group) -
+	return num_clusters_in_group(sb, block_group) -
 		ext4_num_overhead_clusters(sb, block_group, gdp);
 }

diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index a02fadf4fc84..1e39ff5cdde2 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -2590,7 +2590,7 @@ int ext4_mb_alloc_groupinfo(struct super_block *sb, ext4_group_t ngroups)
 	sbi->s_group_info_size = size / sizeof(*sbi->s_group_info);
 	if (old_groupinfo)
 		ext4_kvfree_array_rcu(old_groupinfo);
-	ext4_debug("allocated s_groupinfo array for %d meta_bg's\n",
+	ext4_debug("allocated s_groupinfo array for %d meta_bg's\n",
 		   sbi->s_group_info_size);
 	return 0;
 }
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index 883e2a7cd4ab..996b89b406c5 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -2139,10 +2139,10 @@ static int make_indexed_dir(handle_t *handle, struct ext4_filename *fname,

 	retval = ext4_handle_dirty_dx_node(handle, dir, frame->bh);
 	if (retval)
-		goto out_frames;	
+		goto out_frames;
 	retval = ext4_handle_dirty_dirblock(handle, dir, bh2);
 	if (retval)
-		goto out_frames;	
+		goto out_frames;

 	de = do_split(handle,dir, &bh2, frame, &fname->hinfo);
 	if (IS_ERR(de)) {
@@ -3372,7 +3372,7 @@ static int ext4_symlink(struct user_namespace *mnt_userns, struct inode *dir,
 		 * for transaction commit if we are running out of space
 		 * and thus we deadlock. So we have to stop transaction now
 		 * and restart it when symlink contents is written.
-		 *
+		 *
 		 * To keep fs consistent in case of crash, we have to put inode
 		 * to orphan list in the mean time.
 		 */
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index b9693680463a..675f5de6ac06 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -4996,7 +4996,7 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
 			ext4_journal_commit_callback;

 	block = ext4_count_free_clusters(sb);
-	ext4_free_blocks_count_set(sbi->s_es,
+	ext4_free_blocks_count_set(sbi->s_es,
 				   EXT4_C2B(sbi, block));
 	err = percpu_counter_init(&sbi->s_freeclusters_counter, block,
 				  GFP_KERNEL);
--
2.17.1

Re: [PATCH -next] ext4: fix trailing whitespace

[riteshh]

On 21/04/09 12:20PM, Jack Qiu wrote:
> Made suggested modifications from checkpatch in reference to ERROR:
>  trailing whitespace

Also happens to be useful to folks who have auto remove of any whitespace
at end of line on file save in their editor setup ;)

" for vim
autocmd BufWritePre * %s/\s\+$//e

So, patch looks good to me.
Reviewed-by: Ritesh Harjani <riteshh@linux.ibm.com>

>
> Signed-off-by: Jack Qiu <jack.qiu@huawei.com>
> ---
>  fs/ext4/balloc.c  | 2 +-
>  fs/ext4/mballoc.c | 2 +-
>  fs/ext4/namei.c   | 6 +++---
>  fs/ext4/super.c   | 2 +-
>  4 files changed, 6 insertions(+), 6 deletions(-)
>

-ritesh

Re: [PATCH -next] ext4: fix trailing whitespace

[Theodore Ts'o]

On Fri, Apr 09, 2021 at 10:20:23AM +0530, riteshh wrote:
> On 21/04/09 12:20PM, Jack Qiu wrote:
> > Made suggested modifications from checkpatch in reference to ERROR:
> >  trailing whitespace
> 
> Also happens to be useful to folks who have auto remove of any whitespace
> at end of line on file save in their editor setup ;)
> 
> " for vim
> autocmd BufWritePre * %s/\s\+$//e
> 
> So, patch looks good to me.
> Reviewed-by: Ritesh Harjani <riteshh@linux.ibm.com>

Applied, thanks.

					- Ted