From: Chao Yu <yuchao0@huawei.com>
To: <jaegeuk@kernel.org>
Cc: Xiaojun Wang <wangxiaojun11@huawei.com>,
linux-f2fs-devel@lists.sourceforge.net
Subject: [f2fs-dev] [PATCH 1/3] sload.f2fs: fix memory leak in build_directory
Date: Mon, 5 Aug 2019 09:44:57 +0800 [thread overview]
Message-ID: <20190805014459.119305-1-yuchao0@huawei.com> (raw)
From: Xiaojun Wang <wangxiaojun11@huawei.com>
This patch fix bug that variable dentries going out of scope leaks
the storage it points to.
Signed-off-by: Xiaojun Wang <wangxiaojun11@huawei.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
---
fsck/sload.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/fsck/sload.c b/fsck/sload.c
index f5a4651..940da5c 100644
--- a/fsck/sload.c
+++ b/fsck/sload.c
@@ -240,12 +240,18 @@ static int build_directory(struct f2fs_sb_info *sbi, const char *full_path,
ret = set_selinux_xattr(sbi, dentries[i].path,
dentries[i].ino, dentries[i].mode);
if (ret)
- return ret;
+ goto out_free;
free(dentries[i].path);
free(dentries[i].full_path);
free((void *)dentries[i].name);
}
+out_free:
+ for (; i < entries; i++) {
+ free(dentries[i].path);
+ free(dentries[i].full_path);
+ free((void *)dentries[i].name);
+ }
free(dentries);
return 0;
--
2.18.0.rc1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next reply other threads:[~2019-08-05 1:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 1:44 Chao Yu [this message]
2019-08-05 1:44 ` [f2fs-dev] [PATCH 2/3] sload.f2fs: fix memory leak of dentry.link Chao Yu
2019-08-05 1:44 ` [f2fs-dev] [PATCH 3/3] sload.f2fs: fix error path of build_directory Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190805014459.119305-1-yuchao0@huawei.com \
--to=yuchao0@huawei.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=wangxiaojun11@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).