linux-f2fs-devel.lists.sourceforge.net archive mirror
 help / color / mirror / Atom feed
* [f2fs-dev] [PATCH 1/3] sload.f2fs: fix memory leak in build_directory
@ 2019-08-05  1:44 Chao Yu
  2019-08-05  1:44 ` [f2fs-dev] [PATCH 2/3] sload.f2fs: fix memory leak of dentry.link Chao Yu
  2019-08-05  1:44 ` [f2fs-dev] [PATCH 3/3] sload.f2fs: fix error path of build_directory Chao Yu
  0 siblings, 2 replies; 3+ messages in thread
From: Chao Yu @ 2019-08-05  1:44 UTC (permalink / raw)
  To: jaegeuk; +Cc: Xiaojun Wang, linux-f2fs-devel

From: Xiaojun Wang <wangxiaojun11@huawei.com>

This patch fix bug that variable dentries going out of scope leaks
the storage it points to.

Signed-off-by: Xiaojun Wang <wangxiaojun11@huawei.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
---
 fsck/sload.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/fsck/sload.c b/fsck/sload.c
index f5a4651..940da5c 100644
--- a/fsck/sload.c
+++ b/fsck/sload.c
@@ -240,12 +240,18 @@ static int build_directory(struct f2fs_sb_info *sbi, const char *full_path,
 		ret = set_selinux_xattr(sbi, dentries[i].path,
 					dentries[i].ino, dentries[i].mode);
 		if (ret)
-			return ret;
+			goto out_free;
 
 		free(dentries[i].path);
 		free(dentries[i].full_path);
 		free((void *)dentries[i].name);
 	}
+out_free:
+	for (; i < entries; i++) {
+		free(dentries[i].path);
+		free(dentries[i].full_path);
+		free((void *)dentries[i].name);
+	}
 
 	free(dentries);
 	return 0;
-- 
2.18.0.rc1



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-08-05  1:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-05  1:44 [f2fs-dev] [PATCH 1/3] sload.f2fs: fix memory leak in build_directory Chao Yu
2019-08-05  1:44 ` [f2fs-dev] [PATCH 2/3] sload.f2fs: fix memory leak of dentry.link Chao Yu
2019-08-05  1:44 ` [f2fs-dev] [PATCH 3/3] sload.f2fs: fix error path of build_directory Chao Yu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).