From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: Hridya Valsaraju <hridya@google.com>,
Android Kernel Team <kernel-team@android.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 2/2] f2fs: Add f2fs stats to sysfs
Date: Fri, 25 Oct 2019 11:22:29 -0700 [thread overview]
Message-ID: <20191025182229.GB24183@jaegeuk-macbookpro.roam.corp.google.com> (raw)
In-Reply-To: <96f89e7c-d91e-e263-99f7-16998cc443a7@huawei.com>
On 10/25, Chao Yu wrote:
> On 2019/10/25 11:51, Hridya Valsaraju wrote:
> > On Thu, Oct 24, 2019 at 2:26 AM Chao Yu <yuchao0@huawei.com> wrote:
> >>
> >> On 2019/10/24 5:48, Hridya Valsaraju wrote:
> >>> Currently f2fs stats are only available from /d/f2fs/status. This patch
> >>> adds some of the f2fs stats to sysfs so that they are accessible even
> >>> when debugfs is not mounted.
> >>
> >> Why don't we mount debugfs first?
> >
> > Thank you for taking a look at the patch Chao. We will not be mounting
> > debugfs for security reasons.
>
> Hi, Hridya,
>
> May I ask is there any use case for those new entries?
>
> So many sysfs entries exist, if there is real use case, how about backuping
> entire /d/f2fs/status entry into /proc/fs/f2fs/<dev>/ directory rather than
> adding some of stats as a single entry in sysfs directory?
These will be useful to keep a track on f2fs health status by one value
per entry, which doesn't require user-land parsing stuff. Of course, Android
can exploit them by IdleMaint, rollback feature, and so on.
>
> Thanks,
>
> >
> > Regards,
> > Hridya
> >
> >>
> >> Thanks,
> > .
> >
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2019-10-25 18:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 21:48 [f2fs-dev] [PATCH 1/2] f2fs: delete duplicate information on sysfs nodes Hridya Valsaraju via Linux-f2fs-devel
2019-10-23 21:48 ` [f2fs-dev] [PATCH 2/2] f2fs: Add f2fs stats to sysfs Hridya Valsaraju via Linux-f2fs-devel
2019-10-24 9:26 ` Chao Yu
2019-10-25 3:51 ` Hridya Valsaraju via Linux-f2fs-devel
2019-10-25 8:30 ` Chao Yu
2019-10-25 18:22 ` Jaegeuk Kim [this message]
2019-10-26 1:37 ` Chao Yu
2019-10-29 0:26 ` Hridya Valsaraju via Linux-f2fs-devel
2019-10-24 9:15 ` [f2fs-dev] [PATCH 1/2] f2fs: delete duplicate information on sysfs nodes Chao Yu
2019-10-25 18:23 ` Jaegeuk Kim
2019-10-26 1:40 ` Chao Yu
2020-01-23 1:13 Jaegeuk Kim
2020-01-23 1:13 ` [f2fs-dev] [PATCH 2/2] f2fs: Add f2fs stats to sysfs Jaegeuk Kim
2020-01-23 2:13 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191025182229.GB24183@jaegeuk-macbookpro.roam.corp.google.com \
--to=jaegeuk@kernel.org \
--cc=hridya@google.com \
--cc=kernel-team@android.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).