From: Eric Biggers <ebiggers@kernel.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: Hridya Valsaraju <hridya@google.com>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 2/2] f2fs: Add f2fs stats to sysfs
Date: Wed, 22 Jan 2020 18:13:46 -0800 [thread overview]
Message-ID: <20200123021346.GA862@sol.localdomain> (raw)
In-Reply-To: <20200123011354.75282-2-jaegeuk@kernel.org>
On Wed, Jan 22, 2020 at 05:13:54PM -0800, Jaegeuk Kim wrote:
> diff --git a/fs/f2fs/debug.c b/fs/f2fs/debug.c
> index ce2936554ef8..7565ba9967dd 100644
> --- a/fs/f2fs/debug.c
> +++ b/fs/f2fs/debug.c
> @@ -150,7 +150,7 @@ static void update_general_status(struct f2fs_sb_info *sbi)
> /*
> * This function calculates BDF of every segments
> */
> -static void update_sit_info(struct f2fs_sb_info *sbi)
> +void update_sit_info(struct f2fs_sb_info *sbi)
> {
> struct f2fs_stat_info *si = F2FS_STAT(sbi);
> unsigned long long blks_per_sec, hblks_per_sec, total_vblocks;
Global functions need a "f2fs_" prefix.
- Eric
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2020-01-23 2:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-23 1:13 [f2fs-dev] [PATCH 1/2] f2fs: delete duplicate information on sysfs nodes Jaegeuk Kim
2020-01-23 1:13 ` [f2fs-dev] [PATCH 2/2] f2fs: Add f2fs stats to sysfs Jaegeuk Kim
2020-01-23 2:13 ` Eric Biggers [this message]
2020-01-23 17:24 ` [f2fs-dev] [PATCH 2/2 v2] " Jaegeuk Kim
-- strict thread matches above, loose matches on Subject: below --
2019-10-23 21:48 [f2fs-dev] [PATCH 1/2] f2fs: delete duplicate information on sysfs nodes Hridya Valsaraju via Linux-f2fs-devel
2019-10-23 21:48 ` [f2fs-dev] [PATCH 2/2] f2fs: Add f2fs stats to sysfs Hridya Valsaraju via Linux-f2fs-devel
2019-10-24 9:26 ` Chao Yu
2019-10-25 3:51 ` Hridya Valsaraju via Linux-f2fs-devel
2019-10-25 8:30 ` Chao Yu
2019-10-25 18:22 ` Jaegeuk Kim
2019-10-26 1:37 ` Chao Yu
2019-10-29 0:26 ` Hridya Valsaraju via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200123021346.GA862@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=hridya@google.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).