* Re: [f2fs-dev] [PATCH] f2fs: make trace enter and end in pairs for unlink
2020-06-20 2:12 [f2fs-dev] [PATCH] f2fs: make trace enter and end in pairs for unlink Lihong Kou
@ 2020-06-20 1:48 ` Chao Yu
0 siblings, 0 replies; 2+ messages in thread
From: Chao Yu @ 2020-06-20 1:48 UTC (permalink / raw)
To: Lihong Kou, jaegeuk; +Cc: linux-f2fs-devel
On 2020/6/20 10:12, Lihong Kou wrote:
> In the f2fs_unlink we do not add trace end for some
> error paths, just add.
>
> Signed-off-by: Lihong Kou <koulihong@huawei.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* [f2fs-dev] [PATCH] f2fs: make trace enter and end in pairs for unlink
@ 2020-06-20 2:12 Lihong Kou
2020-06-20 1:48 ` Chao Yu
0 siblings, 1 reply; 2+ messages in thread
From: Lihong Kou @ 2020-06-20 2:12 UTC (permalink / raw)
To: yuchao0, jaegeuk; +Cc: linux-f2fs-devel
In the f2fs_unlink we do not add trace end for some
error paths, just add.
Signed-off-by: Lihong Kou <koulihong@huawei.com>
---
fs/f2fs/namei.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c
index e94e02c6580a..a15a2831d43b 100644
--- a/fs/f2fs/namei.c
+++ b/fs/f2fs/namei.c
@@ -569,15 +569,17 @@ static int f2fs_unlink(struct inode *dir, struct dentry *dentry)
trace_f2fs_unlink_enter(dir, dentry);
- if (unlikely(f2fs_cp_error(sbi)))
- return -EIO;
+ if (unlikely(f2fs_cp_error(sbi))) {
+ err = -EIO;
+ goto fail;
+ }
err = dquot_initialize(dir);
if (err)
- return err;
+ goto fail;
err = dquot_initialize(inode);
if (err)
- return err;
+ goto fail;
de = f2fs_find_entry(dir, &dentry->d_name, &page);
if (!de) {
--
2.17.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-20 1:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-20 2:12 [f2fs-dev] [PATCH] f2fs: make trace enter and end in pairs for unlink Lihong Kou
2020-06-20 1:48 ` Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).