From: Eric Biggers <ebiggers@kernel.org>
To: Satya Tangirala <satyat@google.com>
Cc: linux-fsdevel@vger.kernel.org, linux-fscrypt@vger.kernel.org,
linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 4/5] ext4: support direct I/O with fscrypt using blk-crypto
Date: Thu, 9 Jul 2020 15:30:34 -0700 [thread overview]
Message-ID: <20200709223034.GE3855682@gmail.com> (raw)
In-Reply-To: <20200709194751.2579207-5-satyat@google.com>
On Thu, Jul 09, 2020 at 07:47:50PM +0000, Satya Tangirala wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> Wire up ext4 with fscrypt direct I/O support.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> Signed-off-by: Satya Tangirala <satyat@google.com>
This commit message could use some more details. I think it should clarify that
the direct I/O support is limited to cases where the filesystem has been mounted
with '-o inlinecrypt' and CONFIG_BLK_INLINE_ENCRYPTION has been enabled, along
with CONFIG_BLK_INLINE_ENCRYPTION_FALLBACK if hardware support isn't present.
As-is, it sounds a bit over-promising.
Likewise for f2fs.
We need to properly document this too. At the very least, in the fscrypt patch,
Documentation/filesystems/fscrypt.rst needs to be updated because it currently
says "Direct I/O is not supported on encrypted files."
fscrypt.rst could also use some information about inline encryption. Currently
inline encryption for fscrypt is only documented in the ext4 and f2fs
documentation in the context of the inlinecrypt mount option. (Though, this
suggestion applies even without direct I/O support.)
- Eric
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2020-07-09 22:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 19:47 [f2fs-dev] [PATCH 0/5] add support for direct I/O with fscrypt using blk-crypto Satya Tangirala via Linux-f2fs-devel
2020-07-09 19:47 ` [f2fs-dev] [PATCH 1/5] fscrypt: Add functions for direct I/O support Satya Tangirala via Linux-f2fs-devel
2020-07-09 21:54 ` Eric Biggers
2020-07-09 19:47 ` [f2fs-dev] [PATCH 2/5] direct-io: add support for fscrypt using blk-crypto Satya Tangirala via Linux-f2fs-devel
2020-07-10 5:34 ` Christoph Hellwig
2020-07-13 18:36 ` Eric Biggers
2020-07-17 1:56 ` Satya Tangirala via Linux-f2fs-devel
2020-07-09 19:47 ` [f2fs-dev] [PATCH 3/5] iomap: support direct I/O with " Satya Tangirala via Linux-f2fs-devel
2020-07-09 21:59 ` Eric Biggers
2020-07-09 19:47 ` [f2fs-dev] [PATCH 4/5] ext4: " Satya Tangirala via Linux-f2fs-devel
2020-07-09 22:30 ` Eric Biggers [this message]
2020-07-09 19:47 ` [f2fs-dev] [PATCH 5/5] f2fs: " Satya Tangirala via Linux-f2fs-devel
2020-07-10 1:05 ` Chao Yu
2020-07-10 1:15 ` Eric Biggers
2020-07-09 22:46 ` [f2fs-dev] [PATCH 0/5] add support for " Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200709223034.GE3855682@gmail.com \
--to=ebiggers@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=satyat@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).