* [f2fs-dev] [PATCH] f2fs: Change the type of f2fs_flush_inline_data() to void
@ 2020-07-21 3:49 Jia Yang
2020-07-24 1:34 ` Chao Yu
0 siblings, 1 reply; 2+ messages in thread
From: Jia Yang @ 2020-07-21 3:49 UTC (permalink / raw)
To: yuchao0, jaegeuk; +Cc: linux-f2fs-devel
The return value of f2fs_flush_inline_data() is not used,
so delete it.
Signed-off-by: Jia Yang <jiayang5@huawei.com>
---
fs/f2fs/f2fs.h | 2 +-
fs/f2fs/node.c | 4 +---
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index b35a50f4953c..cf808aa749bc 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -3275,7 +3275,7 @@ void f2fs_ra_node_page(struct f2fs_sb_info *sbi, nid_t nid);
struct page *f2fs_get_node_page(struct f2fs_sb_info *sbi, pgoff_t nid);
struct page *f2fs_get_node_page_ra(struct page *parent, int start);
int f2fs_move_node_page(struct page *node_page, int gc_type);
-int f2fs_flush_inline_data(struct f2fs_sb_info *sbi);
+void f2fs_flush_inline_data(struct f2fs_sb_info *sbi);
int f2fs_fsync_node_pages(struct f2fs_sb_info *sbi, struct inode *inode,
struct writeback_control *wbc, bool atomic,
unsigned int *seq_id);
diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index 03e24df1c84f..6a95bbcb8313 100644
--- a/fs/f2fs/node.c
+++ b/fs/f2fs/node.c
@@ -1814,12 +1814,11 @@ static bool flush_dirty_inode(struct page *page)
return true;
}
-int f2fs_flush_inline_data(struct f2fs_sb_info *sbi)
+void f2fs_flush_inline_data(struct f2fs_sb_info *sbi)
{
pgoff_t index = 0;
struct pagevec pvec;
int nr_pages;
- int ret = 0;
pagevec_init(&pvec);
@@ -1858,7 +1857,6 @@ int f2fs_flush_inline_data(struct f2fs_sb_info *sbi)
pagevec_release(&pvec);
cond_resched();
}
- return ret;
}
int f2fs_sync_node_pages(struct f2fs_sb_info *sbi,
--
2.26.0.106.g9fadedd
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: Change the type of f2fs_flush_inline_data() to void
2020-07-21 3:49 [f2fs-dev] [PATCH] f2fs: Change the type of f2fs_flush_inline_data() to void Jia Yang
@ 2020-07-24 1:34 ` Chao Yu
0 siblings, 0 replies; 2+ messages in thread
From: Chao Yu @ 2020-07-24 1:34 UTC (permalink / raw)
To: Jia Yang, jaegeuk; +Cc: linux-f2fs-devel
On 2020/7/21 11:49, Jia Yang wrote:
> The return value of f2fs_flush_inline_data() is not used,
> so delete it.
>
> Signed-off-by: Jia Yang <jiayang5@huawei.com>
The patch looks good to me, however f2fs_flush_inline_data() should be
reverted, so let's see...
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Thanks,
> ---
> fs/f2fs/f2fs.h | 2 +-
> fs/f2fs/node.c | 4 +---
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> index b35a50f4953c..cf808aa749bc 100644
> --- a/fs/f2fs/f2fs.h
> +++ b/fs/f2fs/f2fs.h
> @@ -3275,7 +3275,7 @@ void f2fs_ra_node_page(struct f2fs_sb_info *sbi, nid_t nid);
> struct page *f2fs_get_node_page(struct f2fs_sb_info *sbi, pgoff_t nid);
> struct page *f2fs_get_node_page_ra(struct page *parent, int start);
> int f2fs_move_node_page(struct page *node_page, int gc_type);
> -int f2fs_flush_inline_data(struct f2fs_sb_info *sbi);
> +void f2fs_flush_inline_data(struct f2fs_sb_info *sbi);
> int f2fs_fsync_node_pages(struct f2fs_sb_info *sbi, struct inode *inode,
> struct writeback_control *wbc, bool atomic,
> unsigned int *seq_id);
> diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
> index 03e24df1c84f..6a95bbcb8313 100644
> --- a/fs/f2fs/node.c
> +++ b/fs/f2fs/node.c
> @@ -1814,12 +1814,11 @@ static bool flush_dirty_inode(struct page *page)
> return true;
> }
>
> -int f2fs_flush_inline_data(struct f2fs_sb_info *sbi)
> +void f2fs_flush_inline_data(struct f2fs_sb_info *sbi)
> {
> pgoff_t index = 0;
> struct pagevec pvec;
> int nr_pages;
> - int ret = 0;
>
> pagevec_init(&pvec);
>
> @@ -1858,7 +1857,6 @@ int f2fs_flush_inline_data(struct f2fs_sb_info *sbi)
> pagevec_release(&pvec);
> cond_resched();
> }
> - return ret;
> }
>
> int f2fs_sync_node_pages(struct f2fs_sb_info *sbi,
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-24 1:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-21 3:49 [f2fs-dev] [PATCH] f2fs: Change the type of f2fs_flush_inline_data() to void Jia Yang
2020-07-24 1:34 ` Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).