[f2fs-dev] [PATCH -next 0/3] f2fs: clean code and fix type error

[f2fs-dev] [PATCH -next 0/3] f2fs: clean code and fix type error

[Zhang Qilong via Linux-f2fs-devel]

Found serveral code type errors when review the code and fix it.
There is no function change.

Zhang Qilong (3):
  f2fs: insert a space around colon
  f2fs: replace spaces with tabs
  f2fs: fix a stype error in f2fs_update_extent_tree_range

 fs/f2fs/data.c         | 2 +-
 fs/f2fs/debug.c        | 2 +-
 fs/f2fs/extent_cache.c | 2 +-
 fs/f2fs/file.c         | 2 +-
 fs/f2fs/node.c         | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

-- 
2.25.1



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

[f2fs-dev] [PATCH -next 1/3] f2fs: insert a space around colon

[Zhang Qilong via Linux-f2fs-devel]

ERROR: spaces required around that ':'

Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
---
 fs/f2fs/data.c  | 2 +-
 fs/f2fs/debug.c | 2 +-
 fs/f2fs/file.c  | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 7d656bf51c52..8b1814c80c30 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -725,7 +725,7 @@ int f2fs_submit_page_bio(struct f2fs_io_info *fio)
 		wbc_account_cgroup_owner(fio->io_wbc, page, PAGE_SIZE);
 
 	inc_page_count(fio->sbi, is_read_io(fio->op) ?
-			__read_io_type(page): WB_DATA_TYPE(fio->page));
+			__read_io_type(page) : WB_DATA_TYPE(fio->page));
 
 	__submit_bio(fio->sbi, bio, fio->type);
 	return 0;
diff --git a/fs/f2fs/debug.c b/fs/f2fs/debug.c
index 88231d393b7c..951f4212380b 100644
--- a/fs/f2fs/debug.c
+++ b/fs/f2fs/debug.c
@@ -348,7 +348,7 @@ static int stat_show(struct seq_file *s, void *v)
 
 		seq_printf(s, "\n=====[ partition info(%pg). #%d, %s, CP: %s]=====\n",
 			si->sbi->sb->s_bdev, i++,
-			f2fs_readonly(si->sbi->sb) ? "RO": "RW",
+			f2fs_readonly(si->sbi->sb) ? "RO" : "RW",
 			is_set_ckpt_flags(si->sbi, CP_DISABLED_FLAG) ?
 			"Disabled" : (f2fs_cp_error(si->sbi) ? "Error" : "Good"));
 		if (si->sbi->s_flag) {
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 6306c081e0be..3970273e0fd2 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -4662,7 +4662,7 @@ static ssize_t f2fs_file_write_iter(struct kiocb *iocb, struct iov_iter *from)
 skip_write_trace:
 		/* Do the actual write. */
 		ret = dio ?
-			f2fs_dio_write_iter(iocb, from, &may_need_sync):
+			f2fs_dio_write_iter(iocb, from, &may_need_sync) :
 			f2fs_buffered_write_iter(iocb, from);
 
 		if (trace_f2fs_datawrite_end_enabled())
-- 
2.25.1



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

[f2fs-dev] [PATCH -next 2/3] f2fs: replace spaces with tabs

[Zhang Qilong via Linux-f2fs-devel]

ERROR: code indent should use tabs where possible

Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
---
 fs/f2fs/node.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index 23291f1575d3..9263bf5f10d3 100644
--- a/fs/f2fs/node.c
+++ b/fs/f2fs/node.c
@@ -585,7 +585,7 @@ int f2fs_get_node_info(struct f2fs_sb_info *sbi, nid_t nid,
 		ne = nat_in_journal(journal, i);
 		node_info_from_raw_nat(ni, &ne);
 	}
-        up_read(&curseg->journal_rwsem);
+	up_read(&curseg->journal_rwsem);
 	if (i >= 0) {
 		f2fs_up_read(&nm_i->nat_tree_lock);
 		goto cache;
-- 
2.25.1



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

[f2fs-dev] [PATCH -next 3/3] f2fs: fix a stype error in f2fs_update_extent_tree_range

[Zhang Qilong via Linux-f2fs-devel]

A little awkward when looking at this code. Just
replace the tab key with a space for better view
here.

Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
---
 fs/f2fs/extent_cache.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/f2fs/extent_cache.c b/fs/f2fs/extent_cache.c
index 761fd42c93f2..9ca4b7ab9b9d 100644
--- a/fs/f2fs/extent_cache.c
+++ b/fs/f2fs/extent_cache.c
@@ -583,7 +583,7 @@ static void f2fs_update_extent_tree_range(struct inode *inode,
 		org_end = dei.fofs + dei.len;
 		f2fs_bug_on(sbi, pos >= org_end);
 
-		if (pos > dei.fofs &&	pos - dei.fofs >= F2FS_MIN_EXTENT_LEN) {
+		if (pos > dei.fofs && pos - dei.fofs >= F2FS_MIN_EXTENT_LEN) {
 			en->ei.len = pos - en->ei.fofs;
 			prev_en = en;
 			parts = 1;
-- 
2.25.1



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH -next 0/3] f2fs: clean code and fix type error

[Jaegeuk Kim]

On 09/13, Zhang Qilong wrote:
> Found serveral code type errors when review the code and fix it.
> There is no function change.

Could you please combine them into single patch?
Thanks,

> 
> Zhang Qilong (3):
>   f2fs: insert a space around colon
>   f2fs: replace spaces with tabs
>   f2fs: fix a stype error in f2fs_update_extent_tree_range
> 
>  fs/f2fs/data.c         | 2 +-
>  fs/f2fs/debug.c        | 2 +-
>  fs/f2fs/extent_cache.c | 2 +-
>  fs/f2fs/file.c         | 2 +-
>  fs/f2fs/node.c         | 2 +-
>  5 files changed, 5 insertions(+), 5 deletions(-)
> 
> -- 
> 2.25.1


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

[f2fs-dev] 答复: [PATCH -next 0/3] f2fs: clean code and fix type error

[zhangqilong via Linux-f2fs-devel]

> 
> On 09/13, Zhang Qilong wrote:
> > Found serveral code type errors when review the code and fix it.
> > There is no function change.
> 
> Could you please combine them into single patch?
> Thanks,
> 

Just fine :), I will send a new patch.

Thanks,

> >
> > Zhang Qilong (3):
> >   f2fs: insert a space around colon
> >   f2fs: replace spaces with tabs
> >   f2fs: fix a stype error in f2fs_update_extent_tree_range
> >
> >  fs/f2fs/data.c         | 2 +-
> >  fs/f2fs/debug.c        | 2 +-
> >  fs/f2fs/extent_cache.c | 2 +-
> >  fs/f2fs/file.c         | 2 +-
> >  fs/f2fs/node.c         | 2 +-
> >  5 files changed, 5 insertions(+), 5 deletions(-)
> >
> > --
> > 2.25.1

_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel