From: Chao Yu <yuchao0@huawei.com>
To: Jaegeuk Kim <jaegeuk@kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-f2fs-devel@lists.sourceforge.net>
Subject: Re: [f2fs-dev] [PATCH 1/3] f2fs: skip GC when section is full
Date: Mon, 17 Feb 2020 09:40:48 +0800 [thread overview]
Message-ID: <2ea7ce0e-b40e-e80b-55b6-8256b3e9c2c1@huawei.com> (raw)
In-Reply-To: <20200214185855.217360-1-jaegeuk@kernel.org>
On 2020/2/15 2:58, Jaegeuk Kim wrote:
> This fixes skipping GC when segment is full in large section.
>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
> fs/f2fs/gc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
> index 53312d7bc78b..65c0687ee2bb 100644
> --- a/fs/f2fs/gc.c
> +++ b/fs/f2fs/gc.c
> @@ -1018,8 +1018,8 @@ static int gc_data_segment(struct f2fs_sb_info *sbi, struct f2fs_summary *sum,
> * race condition along with SSR block allocation.
> */
> if ((gc_type == BG_GC && has_not_enough_free_secs(sbi, 0, 0)) ||
> - get_valid_blocks(sbi, segno, false) ==
> - sbi->blocks_per_seg)
> + get_valid_blocks(sbi, segno, true) ==
> + BLKS_PER_SEC(sbi))
Then in large section, if current segment is all valid, we won't skip scanning
it, so do we need to change like this:
if ((gc_type == BG_GC && has_not_enough_free_secs(sbi, 0, 0)) ||
get_valid_blocks(sbi, segno, false) == sbi->blocks_per_seg ||
get_valid_blocks(sbi, segno, true) == BLKS_PER_SEC(sbi))
return submitted;
> return submitted;
>
> if (check_valid_map(sbi, segno, off) == 0)
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
prev parent reply other threads:[~2020-02-17 1:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 18:58 [f2fs-dev] [PATCH 1/3] f2fs: skip GC when section is full Jaegeuk Kim
2020-02-14 18:58 ` [f2fs-dev] [PATCH 2/3] f2fs: add migration count iff migration happens Jaegeuk Kim
2020-02-17 1:41 ` Chao Yu
2020-02-17 1:43 ` Chao Yu
2020-02-14 18:58 ` [f2fs-dev] [PATCH 3/3] f2fs: skip migration only when BG_GC is called Jaegeuk Kim
2020-02-17 2:22 ` Chao Yu
2020-02-18 23:27 ` Jaegeuk Kim
2020-02-19 3:01 ` Chao Yu
2020-02-19 3:04 ` Jaegeuk Kim
2020-02-19 3:54 ` Chao Yu
2020-02-24 21:53 ` Jaegeuk Kim
2020-02-25 2:24 ` Chao Yu
2020-02-17 1:40 ` Chao Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ea7ce0e-b40e-e80b-55b6-8256b3e9c2c1@huawei.com \
--to=yuchao0@huawei.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).