[f2fs-dev] [PATCH -next] f2fs: add f2fs_gc exception handle in f2fs_ioc_gc_range

[f2fs-dev] [PATCH -next] f2fs: add f2fs_gc exception handle in f2fs_ioc_gc_range

[z00520423]

From: Qilong Zhang <zhangqilong3@huawei.com>

When f2fs_ioc_gc_range performs multiple segments gc ops, the return
value of f2fs_ioc_gc_range is determined by the last segment gc ops.
If its ops failed, the f2fs_ioc_gc_range will be considered to be failed
despite some of previous segments gc ops succeeded. Therefore, so we
fix: only all of segments gc ops are finished will return success.

Signed-off-by: Qilong Zhang <zhangqilong3@huawei.com>
---
 fs/f2fs/file.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 3268f8dd59bb..b81fcf9b123d 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -2527,6 +2527,10 @@ static int f2fs_ioc_gc_range(struct file *filp, unsigned long arg)
 	}
 
 	ret = f2fs_gc(sbi, range.sync, true, GET_SEGNO(sbi, range.start));
+	if (ret) {
+		ret = -EAGAIN;
+		goto out;
+	}
 	range.start += BLKS_PER_SEC(sbi);
 	if (range.start <= end)
 		goto do_more;
-- 
2.17.1



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH -next] f2fs: add f2fs_gc exception handle in f2fs_ioc_gc_range

[Chao Yu]

On 2020/6/23 15:14, z00520423 wrote:
> From: Qilong Zhang <zhangqilong3@huawei.com>
> 
> When f2fs_ioc_gc_range performs multiple segments gc ops, the return
> value of f2fs_ioc_gc_range is determined by the last segment gc ops.
> If its ops failed, the f2fs_ioc_gc_range will be considered to be failed
> despite some of previous segments gc ops succeeded. Therefore, so we
> fix: only all of segments gc ops are finished will return success.
> 
> Signed-off-by: Qilong Zhang <zhangqilong3@huawei.com>
> ---
>  fs/f2fs/file.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index 3268f8dd59bb..b81fcf9b123d 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -2527,6 +2527,10 @@ static int f2fs_ioc_gc_range(struct file *filp, unsigned long arg)
>  	}
>  
>  	ret = f2fs_gc(sbi, range.sync, true, GET_SEGNO(sbi, range.start));
> +	if (ret) {

-ENODATA means 1) target section has no valid blocks or 2) the section has valid blocks,
but it is opened segment, IMO, for 1) condition, we can wrap return value to zero,
continue to gc later sections, for 2) condition, we'd better to return -EBUSY as a hint
to user to call the interface later again.

get_victim_by_default():

	if (*result != NULL_SEGNO) {
		if (get_valid_blocks(sbi, *result, false) &&
			!sec_usage_check(sbi, GET_SEC_FROM_SEG(sbi, *result)))
			p.min_segno = *result;
		goto out;
	}

> +		ret = -EAGAIN;
> +		goto out;
> +	}
>  	range.start += BLKS_PER_SEC(sbi);
>  	if (range.start <= end)
>  		goto do_more;
> 


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel