* [PATCH] dump.f2fs: correct the seg type in ssa_dump
@ 2018-02-06 8:47 Junling Zheng
2018-02-09 13:20 ` Chao Yu
0 siblings, 1 reply; 2+ messages in thread
From: Junling Zheng @ 2018-02-06 8:47 UTC (permalink / raw)
To: jaegeuk, yuchao0; +Cc: linux-f2fs-devel
Fix the mixed using of "ret" in ssa_dump.
Signed-off-by: Junling Zheng <zhengjunling@huawei.com>
---
fsck/dump.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/fsck/dump.c b/fsck/dump.c
index 8772a62..23e4f47 100644
--- a/fsck/dump.c
+++ b/fsck/dump.c
@@ -195,7 +195,7 @@ void ssa_dump(struct f2fs_sb_info *sbi, int start_ssa, int end_ssa)
{
struct f2fs_summary_block *sum_blk;
char buf[BUF_SZ];
- int segno, i, ret;
+ int segno, type, i, ret;
int fd;
fd = open("dump_ssa", O_CREAT|O_WRONLY|O_TRUNC, 0666);
@@ -208,10 +208,10 @@ void ssa_dump(struct f2fs_sb_info *sbi, int start_ssa, int end_ssa)
ASSERT(ret >= 0);
for (segno = start_ssa; segno < end_ssa; segno++) {
- sum_blk = get_sum_block(sbi, segno, &ret);
+ sum_blk = get_sum_block(sbi, segno, &type);
memset(buf, 0, BUF_SZ);
- switch (ret) {
+ switch (type) {
case SEG_TYPE_CUR_NODE:
snprintf(buf, BUF_SZ, "\n\nsegno: %x, Current Node\n", segno);
break;
@@ -240,8 +240,8 @@ void ssa_dump(struct f2fs_sb_info *sbi, int start_ssa, int end_ssa)
ret = write(fd, buf, strlen(buf));
ASSERT(ret >= 0);
}
- if (ret == SEG_TYPE_NODE || ret == SEG_TYPE_DATA ||
- ret == SEG_TYPE_MAX)
+ if (type == SEG_TYPE_NODE || type == SEG_TYPE_DATA ||
+ type == SEG_TYPE_MAX)
free(sum_blk);
}
close(fd);
--
2.15.1
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dump.f2fs: correct the seg type in ssa_dump
2018-02-06 8:47 [PATCH] dump.f2fs: correct the seg type in ssa_dump Junling Zheng
@ 2018-02-09 13:20 ` Chao Yu
0 siblings, 0 replies; 2+ messages in thread
From: Chao Yu @ 2018-02-09 13:20 UTC (permalink / raw)
To: Junling Zheng, jaegeuk, yuchao0; +Cc: linux-f2fs-devel
On 2018/2/6 16:47, Junling Zheng wrote:
> Fix the mixed using of "ret" in ssa_dump.
>
> Signed-off-by: Junling Zheng <zhengjunling@huawei.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Thanks,
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-09 13:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-06 8:47 [PATCH] dump.f2fs: correct the seg type in ssa_dump Junling Zheng
2018-02-09 13:20 ` Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).