linux-f2fs-devel.lists.sourceforge.net archive mirror
 help / color / mirror / Atom feed
* [f2fs-dev] [RFC PATCH 5/9] f2fs: use set/clear_fs_page_private
       [not found] <20200426214925.10970-1-guoqing.jiang@cloud.ionos.com>
@ 2020-04-26 21:49 ` Guoqing Jiang
  2020-04-27  2:22   ` Chao Yu
  0 siblings, 1 reply; 3+ messages in thread
From: Guoqing Jiang @ 2020-04-26 21:49 UTC (permalink / raw)
  To: linux-fsdevel, linux-kernel
  Cc: Guoqing Jiang, david, willy, linux-f2fs-devel, hch, Jaegeuk Kim

Since the new pair function is introduced, we can call them to clean the
code in f2fs.h.

Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: Chao Yu <chao@kernel.org>
Cc: linux-f2fs-devel@lists.sourceforge.net
Signed-off-by: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
---
 fs/f2fs/f2fs.h | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index ba470d5687fe..70ad8c51e0fc 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -3051,19 +3051,12 @@ static inline void f2fs_set_page_private(struct page *page,
 	if (PagePrivate(page))
 		return;
 
-	get_page(page);
-	SetPagePrivate(page);
-	set_page_private(page, data);
+	set_fs_page_private(page, (void *)data);
 }
 
 static inline void f2fs_clear_page_private(struct page *page)
 {
-	if (!PagePrivate(page))
-		return;
-
-	set_page_private(page, 0);
-	ClearPagePrivate(page);
-	f2fs_put_page(page, 0);
+	clear_fs_page_private(page);
 }
 
 /*
-- 
2.17.1



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [f2fs-dev] [RFC PATCH 5/9] f2fs: use set/clear_fs_page_private
  2020-04-26 21:49 ` [f2fs-dev] [RFC PATCH 5/9] f2fs: use set/clear_fs_page_private Guoqing Jiang
@ 2020-04-27  2:22   ` Chao Yu
  2020-04-27  8:10     ` Guoqing Jiang
  0 siblings, 1 reply; 3+ messages in thread
From: Chao Yu @ 2020-04-27  2:22 UTC (permalink / raw)
  To: Guoqing Jiang, linux-fsdevel, linux-kernel
  Cc: david, willy, linux-f2fs-devel, hch, Jaegeuk Kim

On 2020/4/27 5:49, Guoqing Jiang wrote:
> Since the new pair function is introduced, we can call them to clean the
> code in f2fs.h.
> 
> Cc: Jaegeuk Kim <jaegeuk@kernel.org>
> Cc: Chao Yu <chao@kernel.org>
> Cc: linux-f2fs-devel@lists.sourceforge.net
> Signed-off-by: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>

Acked-by: Chao Yu <yuchao0@huawei.com>

Thanks,


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [f2fs-dev] [RFC PATCH 5/9] f2fs: use set/clear_fs_page_private
  2020-04-27  2:22   ` Chao Yu
@ 2020-04-27  8:10     ` Guoqing Jiang
  0 siblings, 0 replies; 3+ messages in thread
From: Guoqing Jiang @ 2020-04-27  8:10 UTC (permalink / raw)
  To: Chao Yu, linux-fsdevel, linux-kernel
  Cc: david, willy, linux-f2fs-devel, hch, Jaegeuk Kim

On 4/27/20 4:22 AM, Chao Yu wrote:
> On 2020/4/27 5:49, Guoqing Jiang wrote:
>> Since the new pair function is introduced, we can call them to clean the
>> code in f2fs.h.
>>
>> Cc: Jaegeuk Kim <jaegeuk@kernel.org>
>> Cc: Chao Yu <chao@kernel.org>
>> Cc: linux-f2fs-devel@lists.sourceforge.net
>> Signed-off-by: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
> Acked-by: Chao Yu <yuchao0@huawei.com>
>

Thanks for your review.

Guoqing


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-04-27  8:11 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20200426214925.10970-1-guoqing.jiang@cloud.ionos.com>
2020-04-26 21:49 ` [f2fs-dev] [RFC PATCH 5/9] f2fs: use set/clear_fs_page_private Guoqing Jiang
2020-04-27  2:22   ` Chao Yu
2020-04-27  8:10     ` Guoqing Jiang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).