From: Chao Yu <chao@kernel.org>
To: Daeho Jeong <daeho43@gmail.com>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com
Cc: Daeho Jeong <daehojeong@google.com>
Subject: Re: [f2fs-dev] [PATCH] f2fs: fix checkpoint mount option wrong combination
Date: Mon, 1 Feb 2021 20:40:34 +0800 [thread overview]
Message-ID: <7e2f440e-6500-04c8-1115-880754a18efa@kernel.org> (raw)
In-Reply-To: <20210201000606.2206740-1-daeho43@gmail.com>
On 2021/2/1 8:06, Daeho Jeong wrote:
> From: Daeho Jeong <daehojeong@google.com>
>
> As checkpoint=merge comes in, mount option setting related to
> checkpoint had been mixed up. Fixed it.
>
> Signed-off-by: Daeho Jeong <daehojeong@google.com>
> ---
> fs/f2fs/super.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 56696f6cfa86..8231c888c772 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -930,20 +930,25 @@ static int parse_options(struct super_block *sb, char *options, bool is_remount)
> return -EINVAL;
> F2FS_OPTION(sbi).unusable_cap_perc = arg;
> set_opt(sbi, DISABLE_CHECKPOINT);
> + clear_opt(sbi, MERGE_CHECKPOINT);
> break;
> case Opt_checkpoint_disable_cap:
> if (args->from && match_int(args, &arg))
> return -EINVAL;
> F2FS_OPTION(sbi).unusable_cap = arg;
> set_opt(sbi, DISABLE_CHECKPOINT);
> + clear_opt(sbi, MERGE_CHECKPOINT);
> break;
> case Opt_checkpoint_disable:
> set_opt(sbi, DISABLE_CHECKPOINT);
> + clear_opt(sbi, MERGE_CHECKPOINT);
> break;
> case Opt_checkpoint_enable:
> clear_opt(sbi, DISABLE_CHECKPOINT);
> + clear_opt(sbi, MERGE_CHECKPOINT);
What if: -o checkpoint=merge,checkpoint=enable
Can you please explain the rule of merge/disable/enable combination and their
result? e.g.
checkpoint=merge,checkpoint=enable
checkpoint=enable,checkpoint=merge
checkpoint=merge,checkpoint=disable
checkpoint=disable,checkpoint=merge
If the rule/result is clear, it should be documented.
Thanks,
> break;
> case Opt_checkpoint_merge:
> + clear_opt(sbi, DISABLE_CHECKPOINT);
> set_opt(sbi, MERGE_CHECKPOINT);
> break;
> #ifdef CONFIG_F2FS_FS_COMPRESSION
> @@ -1142,12 +1147,6 @@ static int parse_options(struct super_block *sb, char *options, bool is_remount)
> return -EINVAL;
> }
>
> - if (test_opt(sbi, DISABLE_CHECKPOINT) &&
> - test_opt(sbi, MERGE_CHECKPOINT)) {
> - f2fs_err(sbi, "checkpoint=merge cannot be used with checkpoint=disable\n");
> - return -EINVAL;
> - }
> -
> /* Not pass down write hints if the number of active logs is lesser
> * than NR_CURSEG_PERSIST_TYPE.
> */
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2021-02-01 12:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 0:06 [f2fs-dev] [PATCH] f2fs: fix checkpoint mount option wrong combination Daeho Jeong
2021-02-01 12:40 ` Chao Yu [this message]
2021-02-01 13:11 ` Daeho Jeong
2021-02-01 20:11 ` Jaegeuk Kim
2021-02-01 23:33 ` Daeho Jeong
2021-02-02 0:41 ` Daeho Jeong
2021-02-02 1:32 ` Chao Yu
2021-02-02 1:28 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e2f440e-6500-04c8-1115-880754a18efa@kernel.org \
--to=chao@kernel.org \
--cc=daeho43@gmail.com \
--cc=daehojeong@google.com \
--cc=kernel-team@android.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).