From: Thomas Zimmermann <tzimmermann@suse.de>
To: Sam Ravnborg <sam@ravnborg.org>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
Alexander Klimov <grandmaster@al2klimov.de>,
Alex Dewar <alex.dewar90@gmail.com>,
Antonino Daplas <adaplas@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Evgeny Novikov <novikov@ispras.ru>,
Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
George Kennedy <george.kennedy@oracle.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Gustavo Silva <gustavoars@kernel.org>,
Jani Nikula <jani.nikula@intel.com>,
Jason Yan <yanaijie@huawei.com>,
Jingoo Han <jingoohan1@gmail.com>,
Jiri Slaby <jirislaby@kernel.org>, Joe Perches <joe@perches.com>,
Kristoffer Ericson <kristoffer.ericson@gmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mike Rapoport <rppt@kernel.org>,
Nathan Chancellor <natechancellor@gmail.com>,
Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
Qilong Zhang <zhangqilong3@huawei.com>,
Randy Dunlap <rdunlap@infradead.org>,
Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
Thomas Winischhofer <thomas@winischhofer.net>,
Vaibhav Gupta <vaibhavgupta40@gmail.com>,
Xiaofei Tan <tanxiaofei@huawei.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v2 05/28] video: fbdev: aty: Fix set but not used warnings
Date: Mon, 30 Nov 2020 09:53:55 +0100 [thread overview]
Message-ID: <1dfb3ff0-3a78-32ab-185a-9fa153fef509@suse.de> (raw)
In-Reply-To: <20201128224114.1033617-6-sam@ravnborg.org>
[-- Attachment #1.1: Type: text/plain, Size: 3421 bytes --]
Am 28.11.20 um 23:40 schrieb Sam Ravnborg:
> Fix W=1 warnings about variables assigned but never used.
>
> - Drop variables that was set but never used
s/that was/that were
> - Make variable definition conditional om ATARI
s/om/on
>
> v2:
> - Fix m68k build error (kernel test robot)
> - Improve subject (Lee Jones)
>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Reported-by: kernel test robot <lkp@intel.com> # m68k build fix
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Joe Perches <joe@perches.com>
> Cc: Vaibhav Gupta <vaibhavgupta40@gmail.com>
> Cc: Jason Yan <yanaijie@huawei.com>
> Cc: Randy Dunlap <rdunlap@infradead.org>
> Cc: Jani Nikula <jani.nikula@intel.com>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/video/fbdev/aty/atyfb_base.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/video/fbdev/aty/atyfb_base.c b/drivers/video/fbdev/aty/atyfb_base.c
> index c8feff0ee8da..83c8e809955a 100644
> --- a/drivers/video/fbdev/aty/atyfb_base.c
> +++ b/drivers/video/fbdev/aty/atyfb_base.c
> @@ -2353,6 +2353,9 @@ static int aty_init(struct fb_info *info)
> int gtb_memsize, has_var = 0;
> struct fb_var_screeninfo var;
> int ret;
> +#ifdef CONFIG_ATARI
> + u8 dac_type;
> +#endif
>
> init_waitqueue_head(&par->vblank.wait);
> spin_lock_init(&par->int_lock);
> @@ -2360,13 +2363,12 @@ static int aty_init(struct fb_info *info)
> #ifdef CONFIG_FB_ATY_GX
> if (!M64_HAS(INTEGRATED)) {
> u32 stat0;
> - u8 dac_type, dac_subtype, clk_type;
> + u8 dac_subtype, clk_type;
> stat0 = aty_ld_le32(CNFG_STAT0, par);
> par->bus_type = (stat0 >> 0) & 0x07;
> par->ram_type = (stat0 >> 3) & 0x07;
> ramname = aty_gx_ram[par->ram_type];
> /* FIXME: clockchip/RAMDAC probing? */
> - dac_type = (aty_ld_le32(DAC_CNTL, par) >> 16) & 0x07;
> #ifdef CONFIG_ATARI
> clk_type = CLK_ATI18818_1;
> dac_type = (stat0 >> 9) & 0x07;
> @@ -2375,7 +2377,6 @@ static int aty_init(struct fb_info *info)
> else
> dac_subtype = (aty_ld_8(SCRATCH_REG1 + 1, par) & 0xF0) | dac_type;
> #else
> - dac_type = DAC_IBMRGB514;
> dac_subtype = DAC_IBMRGB514;
> clk_type = CLK_IBMRGB514;
> #endif
> @@ -3062,7 +3063,6 @@ static int atyfb_setup_sparc(struct pci_dev *pdev, struct fb_info *info,
> if (dp == of_console_device) {
> struct fb_var_screeninfo *var = &default_var;
> unsigned int N, P, Q, M, T, R;
> - u32 v_total, h_total;
> struct crtc crtc;
> u8 pll_regs[16];
> u8 clock_cntl;
> @@ -3078,9 +3078,6 @@ static int atyfb_setup_sparc(struct pci_dev *pdev, struct fb_info *info,
> crtc.gen_cntl = aty_ld_le32(CRTC_GEN_CNTL, par);
> aty_crtc_to_var(&crtc, var);
>
> - h_total = var->xres + var->right_margin + var->hsync_len + var->left_margin;
> - v_total = var->yres + var->lower_margin + var->vsync_len + var->upper_margin;
> -
> /*
> * Read the PLL to figure actual Refresh Rate.
> */
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
next prev parent reply other threads:[~2020-11-30 8:54 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-28 22:40 [PATCH v2 0/28] drivers/video: W=1 warning fixes Sam Ravnborg
2020-11-28 22:40 ` [PATCH v2 01/28] video: Fix kernel-doc warnings in of_display_timing + of_videomode Sam Ravnborg
2020-11-29 10:01 ` Thomas Zimmermann
2020-11-29 11:22 ` Sam Ravnborg
2020-11-29 21:43 ` Sam Ravnborg
2020-11-28 22:40 ` [PATCH v2 02/28] video: fbcon: Fix warnings by using pr_debug() in fbcon Sam Ravnborg
2020-11-29 10:03 ` Thomas Zimmermann
2020-11-29 10:28 ` Tetsuo Handa
2020-11-29 11:18 ` Sam Ravnborg
2020-11-30 6:38 ` Peilin Ye
2020-11-30 7:56 ` Sam Ravnborg
2020-11-30 8:52 ` Peilin Ye
2020-11-29 21:45 ` Sam Ravnborg
2020-11-28 22:40 ` [PATCH v2 03/28] video: fbdev: core: Fix kernel-doc warnings in fbmon + fb_notify Sam Ravnborg
2020-11-29 10:08 ` Thomas Zimmermann
2020-11-28 22:40 ` [PATCH v2 04/28] video: fbdev: aty: Delete unused variable in radeon_monitor Sam Ravnborg
2020-11-30 8:51 ` Thomas Zimmermann
2020-11-28 22:40 ` [PATCH v2 05/28] video: fbdev: aty: Fix set but not used warnings Sam Ravnborg
2020-11-30 8:53 ` Thomas Zimmermann [this message]
2020-11-28 22:40 ` [PATCH v2 06/28] video: fbdev: aty: Fix set but not used warnings in mach64_ct Sam Ravnborg
2020-11-30 8:57 ` Thomas Zimmermann
2020-11-28 22:40 ` [PATCH v2 07/28] video: fbdev: sis: Fix defined but not used warnings Sam Ravnborg
2020-11-30 8:59 ` Thomas Zimmermann
2020-11-28 22:40 ` [PATCH v2 08/28] video: fbdev: sis: Fix defined but not used warning of SiS_TVDelay Sam Ravnborg
2020-11-30 9:13 ` Thomas Zimmermann
2020-11-30 19:01 ` Sam Ravnborg
2020-12-01 9:58 ` Thomas Zimmermann
2020-11-28 22:40 ` [PATCH v2 09/28] video: fbdev: sis: Fix set but not used warnings in init.c Sam Ravnborg
2020-11-30 9:16 ` Thomas Zimmermann
2020-11-28 22:40 ` [PATCH v2 10/28] video: fbdev: sis: Fix set but not used warnings in sis_main Sam Ravnborg
2020-11-30 10:14 ` Thomas Zimmermann
2020-11-28 22:40 ` [PATCH v2 11/28] video: fbdev: via: Fix set but not used warning for mode_crt_table Sam Ravnborg
2020-11-30 12:08 ` Thomas Zimmermann
2020-11-28 22:40 ` [PATCH v2 12/28] video: fbdev: tdfx: Fix set but not used warning in att_outb() Sam Ravnborg
2020-11-30 12:12 ` Thomas Zimmermann
2020-11-28 22:40 ` [PATCH v2 13/28] video: fbdev: riva: Fix kernel-doc and set but not used warnings Sam Ravnborg
2020-11-30 12:14 ` Thomas Zimmermann
2020-11-30 18:35 ` Sam Ravnborg
2020-12-01 8:47 ` Lee Jones
2020-12-01 9:07 ` Sam Ravnborg
2020-12-01 9:46 ` Lee Jones
2020-12-01 10:04 ` Daniel Vetter
2020-12-01 10:27 ` Lee Jones
2020-11-28 22:41 ` [PATCH v2 14/28] video: fbdev: pm2fb: Fix kernel-doc warnings Sam Ravnborg
2020-11-30 12:15 ` Thomas Zimmermann
2020-11-28 22:41 ` [PATCH v2 15/28] video: fbdev: neofb: Fix set but not used warning for CursorMem Sam Ravnborg
2020-11-30 12:16 ` Thomas Zimmermann
2020-11-28 22:41 ` [PATCH v2 16/28] video: fbdev: hgafb: Fix kernel-doc warnings Sam Ravnborg
2020-11-29 16:10 ` Randy Dunlap
2020-11-28 22:41 ` [PATCH v2 17/28] video: fbdev: tgafb: Fix kernel-doc and set but not used warnings Sam Ravnborg
2020-11-30 13:04 ` Thomas Zimmermann
2020-11-28 22:41 ` [PATCH v2 18/28] video: fbdev: mx3fb: Fix kernel-doc, set but not used and string warnings Sam Ravnborg
2020-11-30 13:22 ` Thomas Zimmermann
2020-11-28 22:41 ` [PATCH v2 19/28] video: fbdev: sstfb: Updated logging to fix set but not used warnings Sam Ravnborg
2020-11-30 14:25 ` Thomas Zimmermann
2020-11-28 22:41 ` [PATCH v2 20/28] video: fbdev: nvidia: Fix " Sam Ravnborg
2020-11-30 14:35 ` Thomas Zimmermann
2020-11-28 22:41 ` [PATCH v2 21/28] video: fbdev: tmiofb: " Sam Ravnborg
2020-11-30 14:36 ` Thomas Zimmermann
2020-11-30 18:46 ` Sam Ravnborg
2020-11-28 22:41 ` [PATCH v2 22/28] video: fbdev: omapfb: Fix set but not used warnings in dsi Sam Ravnborg
2020-12-01 10:03 ` Thomas Zimmermann
2020-11-28 22:41 ` [PATCH v2 23/28] video: fbdev: omapfb: Fix set but not used warnings in hdmi*_core Sam Ravnborg
2020-12-01 10:06 ` Thomas Zimmermann
2020-12-05 20:58 ` Sam Ravnborg
2020-11-28 22:41 ` [PATCH v2 24/28] video: fbdev: s3c-fb: Fix kernel-doc and set but not used warnings Sam Ravnborg
2020-12-01 10:07 ` Thomas Zimmermann
2020-11-28 22:41 ` [PATCH v2 25/28] video: fbdev: uvesafb: Fix set but not used warning Sam Ravnborg
2020-12-01 10:09 ` Thomas Zimmermann
2020-11-28 22:41 ` [PATCH v2 26/28] video: fbdev: uvesafb: Fix string related warnings Sam Ravnborg
2020-12-01 14:19 ` Thomas Zimmermann
2020-11-28 22:41 ` [PATCH v2 27/28] video: fbdev: cirrusfb: Fix kernel-doc and set but not used warnings Sam Ravnborg
2020-12-01 14:21 ` Thomas Zimmermann
2020-12-05 20:18 ` Sam Ravnborg
2020-11-28 22:41 ` [PATCH v2 28/28] video: fbdev: s1d13xxxfb: " Sam Ravnborg
2020-11-29 9:59 ` Thomas Zimmermann
2020-11-29 21:52 ` Sam Ravnborg
2020-12-01 14:23 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1dfb3ff0-3a78-32ab-185a-9fa153fef509@suse.de \
--to=tzimmermann@suse.de \
--cc=FlorianSchandinat@gmx.de \
--cc=adaplas@gmail.com \
--cc=alex.dewar90@gmail.com \
--cc=arnd@arndb.de \
--cc=b.zolnierkie@samsung.com \
--cc=benh@kernel.crashing.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=george.kennedy@oracle.com \
--cc=grandmaster@al2klimov.de \
--cc=gregkh@linuxfoundation.org \
--cc=gustavoars@kernel.org \
--cc=jani.nikula@intel.com \
--cc=jingoohan1@gmail.com \
--cc=jirislaby@kernel.org \
--cc=joe@perches.com \
--cc=kristoffer.ericson@gmail.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=lkp@intel.com \
--cc=natechancellor@gmail.com \
--cc=novikov@ispras.ru \
--cc=pakki001@umn.edu \
--cc=peda@axentia.se \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=rdunlap@infradead.org \
--cc=rppt@kernel.org \
--cc=saeed.mirzamohammadi@oracle.com \
--cc=sam@ravnborg.org \
--cc=tanxiaofei@huawei.com \
--cc=thomas@winischhofer.net \
--cc=vaibhavgupta40@gmail.com \
--cc=yanaijie@huawei.com \
--cc=yepeilin.cs@gmail.com \
--cc=zhangqilong3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).