From: Thomas Zimmermann <tzimmermann@suse.de>
To: Sam Ravnborg <sam@ravnborg.org>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
Alexander Klimov <grandmaster@al2klimov.de>,
Alex Dewar <alex.dewar90@gmail.com>,
Antonino Daplas <adaplas@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Evgeny Novikov <novikov@ispras.ru>,
Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
George Kennedy <george.kennedy@oracle.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Gustavo Silva <gustavoars@kernel.org>,
Jani Nikula <jani.nikula@intel.com>,
Jason Yan <yanaijie@huawei.com>,
Jingoo Han <jingoohan1@gmail.com>,
Jiri Slaby <jirislaby@kernel.org>, Joe Perches <joe@perches.com>,
Kristoffer Ericson <kristoffer.ericson@gmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mike Rapoport <rppt@kernel.org>,
Nathan Chancellor <natechancellor@gmail.com>,
Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
Qilong Zhang <zhangqilong3@huawei.com>,
Randy Dunlap <rdunlap@infradead.org>,
Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
Thomas Winischhofer <thomas@winischhofer.net>,
Vaibhav Gupta <vaibhavgupta40@gmail.com>,
Xiaofei Tan <tanxiaofei@huawei.com>
Subject: Re: [PATCH v2 22/28] video: fbdev: omapfb: Fix set but not used warnings in dsi
Date: Tue, 1 Dec 2020 11:03:42 +0100 [thread overview]
Message-ID: <8f39b00f-3ec7-0712-0eaa-07156c1cdc37@suse.de> (raw)
In-Reply-To: <20201128224114.1033617-23-sam@ravnborg.org>
[-- Attachment #1.1: Type: text/plain, Size: 3269 bytes --]
Am 28.11.20 um 23:41 schrieb Sam Ravnborg:
> Fix several W=1 warnings.
> This removes unused code and avoids an assignment by moving
> the use inside the conditional block.
>
> The register read FLD_GET(r, 15, 8) could be dropped as it was done a
> few lines before too.
>
> v2:
> - Updated subject (Lee)
>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Aditya Pakki <pakki001@umn.edu>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Cc: Lee Jones <lee.jones@linaro.org>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/video/fbdev/omap2/omapfb/dss/dsi.c | 12 +++---------
> 1 file changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dsi.c b/drivers/video/fbdev/omap2/omapfb/dss/dsi.c
> index 6f9c25fec994..72d45a02c3ac 100644
> --- a/drivers/video/fbdev/omap2/omapfb/dss/dsi.c
> +++ b/drivers/video/fbdev/omap2/omapfb/dss/dsi.c
> @@ -1178,13 +1178,12 @@ static int dsi_regulator_init(struct platform_device *dsidev)
>
> static void _dsi_print_reset_status(struct platform_device *dsidev)
> {
> - u32 l;
> int b0, b1, b2;
>
> /* A dummy read using the SCP interface to any DSIPHY register is
> * required after DSIPHY reset to complete the reset of the DSI complex
> * I/O. */
> - l = dsi_read_reg(dsidev, DSI_DSIPHY_CFG5);
> + dsi_read_reg(dsidev, DSI_DSIPHY_CFG5);
>
> if (dss_has_feature(FEAT_DSI_REVERSE_TXCLKESC)) {
> b0 = 28;
> @@ -3627,7 +3626,7 @@ static int dsi_proto_config(struct platform_device *dsidev)
> static void dsi_proto_timings(struct platform_device *dsidev)
> {
> struct dsi_data *dsi = dsi_get_dsidrv_data(dsidev);
> - unsigned tlpx, tclk_zero, tclk_prepare, tclk_trail;
> + unsigned tlpx, tclk_zero, tclk_prepare;
> unsigned tclk_pre, tclk_post;
> unsigned ths_prepare, ths_prepare_ths_zero, ths_zero;
> unsigned ths_trail, ths_exit;
> @@ -3646,7 +3645,6 @@ static void dsi_proto_timings(struct platform_device *dsidev)
>
> r = dsi_read_reg(dsidev, DSI_DSIPHY_CFG1);
> tlpx = FLD_GET(r, 20, 16) * 2;
> - tclk_trail = FLD_GET(r, 15, 8);
> tclk_zero = FLD_GET(r, 7, 0);
>
> r = dsi_read_reg(dsidev, DSI_DSIPHY_CFG2);
> @@ -4040,7 +4038,6 @@ static int dsi_update(struct omap_dss_device *dssdev, int channel,
> {
> struct platform_device *dsidev = dsi_get_dsidev_from_dssdev(dssdev);
> struct dsi_data *dsi = dsi_get_dsidrv_data(dsidev);
> - u16 dw, dh;
>
> dsi_perf_mark_setup(dsidev);
>
> @@ -4049,11 +4046,8 @@ static int dsi_update(struct omap_dss_device *dssdev, int channel,
> dsi->framedone_callback = callback;
> dsi->framedone_data = data;
>
> - dw = dsi->timings.x_res;
> - dh = dsi->timings.y_res;
> -
> #ifdef DSI_PERF_MEASURE
> - dsi->update_bytes = dw * dh *
> + dsi->update_bytes = dsi->timings.x_res * dsi->timings.y_res *
> dsi_get_pixel_size(dsi->pix_fmt) / 8;
> #endif
> dsi_update_screen_dispc(dsidev);
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
next prev parent reply other threads:[~2020-12-01 10:04 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-28 22:40 [PATCH v2 0/28] drivers/video: W=1 warning fixes Sam Ravnborg
2020-11-28 22:40 ` [PATCH v2 01/28] video: Fix kernel-doc warnings in of_display_timing + of_videomode Sam Ravnborg
2020-11-29 10:01 ` Thomas Zimmermann
2020-11-29 11:22 ` Sam Ravnborg
2020-11-29 21:43 ` Sam Ravnborg
2020-11-28 22:40 ` [PATCH v2 02/28] video: fbcon: Fix warnings by using pr_debug() in fbcon Sam Ravnborg
2020-11-29 10:03 ` Thomas Zimmermann
2020-11-29 10:28 ` Tetsuo Handa
2020-11-29 11:18 ` Sam Ravnborg
2020-11-30 6:38 ` Peilin Ye
2020-11-30 7:56 ` Sam Ravnborg
2020-11-30 8:52 ` Peilin Ye
2020-11-29 21:45 ` Sam Ravnborg
2020-11-28 22:40 ` [PATCH v2 03/28] video: fbdev: core: Fix kernel-doc warnings in fbmon + fb_notify Sam Ravnborg
2020-11-29 10:08 ` Thomas Zimmermann
2020-11-28 22:40 ` [PATCH v2 04/28] video: fbdev: aty: Delete unused variable in radeon_monitor Sam Ravnborg
2020-11-30 8:51 ` Thomas Zimmermann
2020-11-28 22:40 ` [PATCH v2 05/28] video: fbdev: aty: Fix set but not used warnings Sam Ravnborg
2020-11-30 8:53 ` Thomas Zimmermann
2020-11-28 22:40 ` [PATCH v2 06/28] video: fbdev: aty: Fix set but not used warnings in mach64_ct Sam Ravnborg
2020-11-30 8:57 ` Thomas Zimmermann
2020-11-28 22:40 ` [PATCH v2 07/28] video: fbdev: sis: Fix defined but not used warnings Sam Ravnborg
2020-11-30 8:59 ` Thomas Zimmermann
2020-11-28 22:40 ` [PATCH v2 08/28] video: fbdev: sis: Fix defined but not used warning of SiS_TVDelay Sam Ravnborg
2020-11-30 9:13 ` Thomas Zimmermann
2020-11-30 19:01 ` Sam Ravnborg
2020-12-01 9:58 ` Thomas Zimmermann
2020-11-28 22:40 ` [PATCH v2 09/28] video: fbdev: sis: Fix set but not used warnings in init.c Sam Ravnborg
2020-11-30 9:16 ` Thomas Zimmermann
2020-11-28 22:40 ` [PATCH v2 10/28] video: fbdev: sis: Fix set but not used warnings in sis_main Sam Ravnborg
2020-11-30 10:14 ` Thomas Zimmermann
2020-11-28 22:40 ` [PATCH v2 11/28] video: fbdev: via: Fix set but not used warning for mode_crt_table Sam Ravnborg
2020-11-30 12:08 ` Thomas Zimmermann
2020-11-28 22:40 ` [PATCH v2 12/28] video: fbdev: tdfx: Fix set but not used warning in att_outb() Sam Ravnborg
2020-11-30 12:12 ` Thomas Zimmermann
2020-11-28 22:40 ` [PATCH v2 13/28] video: fbdev: riva: Fix kernel-doc and set but not used warnings Sam Ravnborg
2020-11-30 12:14 ` Thomas Zimmermann
2020-11-30 18:35 ` Sam Ravnborg
2020-12-01 8:47 ` Lee Jones
2020-12-01 9:07 ` Sam Ravnborg
2020-12-01 9:46 ` Lee Jones
2020-12-01 10:04 ` Daniel Vetter
2020-12-01 10:27 ` Lee Jones
2020-11-28 22:41 ` [PATCH v2 14/28] video: fbdev: pm2fb: Fix kernel-doc warnings Sam Ravnborg
2020-11-30 12:15 ` Thomas Zimmermann
2020-11-28 22:41 ` [PATCH v2 15/28] video: fbdev: neofb: Fix set but not used warning for CursorMem Sam Ravnborg
2020-11-30 12:16 ` Thomas Zimmermann
2020-11-28 22:41 ` [PATCH v2 16/28] video: fbdev: hgafb: Fix kernel-doc warnings Sam Ravnborg
2020-11-29 16:10 ` Randy Dunlap
2020-11-28 22:41 ` [PATCH v2 17/28] video: fbdev: tgafb: Fix kernel-doc and set but not used warnings Sam Ravnborg
2020-11-30 13:04 ` Thomas Zimmermann
2020-11-28 22:41 ` [PATCH v2 18/28] video: fbdev: mx3fb: Fix kernel-doc, set but not used and string warnings Sam Ravnborg
2020-11-30 13:22 ` Thomas Zimmermann
2020-11-28 22:41 ` [PATCH v2 19/28] video: fbdev: sstfb: Updated logging to fix set but not used warnings Sam Ravnborg
2020-11-30 14:25 ` Thomas Zimmermann
2020-11-28 22:41 ` [PATCH v2 20/28] video: fbdev: nvidia: Fix " Sam Ravnborg
2020-11-30 14:35 ` Thomas Zimmermann
2020-11-28 22:41 ` [PATCH v2 21/28] video: fbdev: tmiofb: " Sam Ravnborg
2020-11-30 14:36 ` Thomas Zimmermann
2020-11-30 18:46 ` Sam Ravnborg
2020-11-28 22:41 ` [PATCH v2 22/28] video: fbdev: omapfb: Fix set but not used warnings in dsi Sam Ravnborg
2020-12-01 10:03 ` Thomas Zimmermann [this message]
2020-11-28 22:41 ` [PATCH v2 23/28] video: fbdev: omapfb: Fix set but not used warnings in hdmi*_core Sam Ravnborg
2020-12-01 10:06 ` Thomas Zimmermann
2020-12-05 20:58 ` Sam Ravnborg
2020-11-28 22:41 ` [PATCH v2 24/28] video: fbdev: s3c-fb: Fix kernel-doc and set but not used warnings Sam Ravnborg
2020-12-01 10:07 ` Thomas Zimmermann
2020-11-28 22:41 ` [PATCH v2 25/28] video: fbdev: uvesafb: Fix set but not used warning Sam Ravnborg
2020-12-01 10:09 ` Thomas Zimmermann
2020-11-28 22:41 ` [PATCH v2 26/28] video: fbdev: uvesafb: Fix string related warnings Sam Ravnborg
2020-12-01 14:19 ` Thomas Zimmermann
2020-11-28 22:41 ` [PATCH v2 27/28] video: fbdev: cirrusfb: Fix kernel-doc and set but not used warnings Sam Ravnborg
2020-12-01 14:21 ` Thomas Zimmermann
2020-12-05 20:18 ` Sam Ravnborg
2020-11-28 22:41 ` [PATCH v2 28/28] video: fbdev: s1d13xxxfb: " Sam Ravnborg
2020-11-29 9:59 ` Thomas Zimmermann
2020-11-29 21:52 ` Sam Ravnborg
2020-12-01 14:23 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f39b00f-3ec7-0712-0eaa-07156c1cdc37@suse.de \
--to=tzimmermann@suse.de \
--cc=FlorianSchandinat@gmx.de \
--cc=adaplas@gmail.com \
--cc=alex.dewar90@gmail.com \
--cc=arnd@arndb.de \
--cc=b.zolnierkie@samsung.com \
--cc=benh@kernel.crashing.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=george.kennedy@oracle.com \
--cc=grandmaster@al2klimov.de \
--cc=gregkh@linuxfoundation.org \
--cc=gustavoars@kernel.org \
--cc=jani.nikula@intel.com \
--cc=jingoohan1@gmail.com \
--cc=jirislaby@kernel.org \
--cc=joe@perches.com \
--cc=kristoffer.ericson@gmail.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=novikov@ispras.ru \
--cc=pakki001@umn.edu \
--cc=peda@axentia.se \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=rdunlap@infradead.org \
--cc=rppt@kernel.org \
--cc=saeed.mirzamohammadi@oracle.com \
--cc=sam@ravnborg.org \
--cc=tanxiaofei@huawei.com \
--cc=thomas@winischhofer.net \
--cc=vaibhavgupta40@gmail.com \
--cc=yanaijie@huawei.com \
--cc=yepeilin.cs@gmail.com \
--cc=zhangqilong3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).