* [RFC PATCH 00/12] i2c: replace i2c_new_probed_device with an ERR_PTR variant
@ 2019-11-06 9:50 Wolfram Sang
2019-11-06 9:50 ` [RFC PATCH 05/12] video: fbdev: matrox: convert to i2c_new_scanned_device Wolfram Sang
2019-11-06 10:06 ` [RFC PATCH 00/12] i2c: replace i2c_new_probed_device with an ERR_PTR variant Sean Young
0 siblings, 2 replies; 6+ messages in thread
From: Wolfram Sang @ 2019-11-06 9:50 UTC (permalink / raw)
To: linux-i2c
Cc: Wolfram Sang, dri-devel, linux-fbdev, linux-input, linux-kernel,
linux-media, linuxppc-dev
From: Wolfram Sang <wsa@the-dreams.de>
In the on-going mission to let i2c_new_* calls return an ERR_PTR instead
of NULL, here is a series converting i2c_new_probed_device(). A new
function called i2c_new_scanned_device() is introduced with the new
retval, but for now, a compatibility helper is provided until all users
are converted. The rest of the patches convert all current in-tree
users.
Note that these patches are RFC because I want feedback on the approach
and hopefully collect acks on the driver conversions. If all goes well,
I'll apply the first two patches for the next merge window. Then, once
this dependency is upstream, I'll resend this series with all issues
fixed and acks collected.
Core changes tested on a Renesas Salvator-XS board (R-Car M3-N), driver
patches build tested by me and buildbot.
Wolfram Sang (12):
i2c: replace i2c_new_probed_device with an ERR_PTR variant
i2c: icy: convert to i2c_new_scanned_device
macintosh: convert to i2c_new_scanned_device
platform: chrome: convert to i2c_new_scanned_device
video: fbdev: matrox: convert to i2c_new_scanned_device
input: mouse: convert to i2c_new_scanned_device
media: pci: cx23885: convert to i2c_new_scanned_device
media: pci: cx88: convert to i2c_new_scanned_device
media: pci: bt8xx: convert to i2c_new_scanned_device
media: pci: cx18: convert to i2c_new_scanned_device
media: pci: ivtv: convert to i2c_new_scanned_device
media: v4l2-core: convert to i2c_new_scanned_device
Documentation/i2c/instantiating-devices.rst | 10 ++++-----
Documentation/i2c/writing-clients.rst | 8 +++----
drivers/i2c/busses/i2c-icy.c | 8 +++----
drivers/i2c/i2c-core-base.c | 25 ++++++++++++++++-----
drivers/input/mouse/psmouse-smbus.c | 8 ++++---
drivers/macintosh/therm_windtunnel.c | 4 ++--
drivers/media/pci/bt8xx/bttv-input.c | 6 ++---
drivers/media/pci/cx18/cx18-i2c.c | 2 +-
drivers/media/pci/cx23885/cx23885-i2c.c | 4 ++--
drivers/media/pci/cx88/cx88-input.c | 2 +-
drivers/media/pci/ivtv/ivtv-i2c.c | 6 ++---
drivers/media/pci/ivtv/ivtv-i2c.h | 2 +-
drivers/media/v4l2-core/v4l2-i2c.c | 10 ++++-----
drivers/platform/chrome/chromeos_laptop.c | 18 ++++++++-------
drivers/video/fbdev/matrox/i2c-matroxfb.c | 4 ++--
include/linux/i2c.h | 12 +++++++---
16 files changed, 76 insertions(+), 53 deletions(-)
--
2.20.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [RFC PATCH 05/12] video: fbdev: matrox: convert to i2c_new_scanned_device
2019-11-06 9:50 [RFC PATCH 00/12] i2c: replace i2c_new_probed_device with an ERR_PTR variant Wolfram Sang
@ 2019-11-06 9:50 ` Wolfram Sang
2019-11-07 8:33 ` Daniel Vetter
2019-11-28 16:19 ` Wolfram Sang
2019-11-06 10:06 ` [RFC PATCH 00/12] i2c: replace i2c_new_probed_device with an ERR_PTR variant Sean Young
1 sibling, 2 replies; 6+ messages in thread
From: Wolfram Sang @ 2019-11-06 9:50 UTC (permalink / raw)
To: linux-i2c
Cc: Wolfram Sang, Bartlomiej Zolnierkiewicz, dri-devel, linux-fbdev,
linux-kernel
Move from the deprecated i2c_new_probed_device() to the new
i2c_new_scanned_device(). Make use of the new ERRPTR if suitable.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
Build tested only. RFC, please comment and/or ack, but don't apply yet.
drivers/video/fbdev/matrox/i2c-matroxfb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/matrox/i2c-matroxfb.c b/drivers/video/fbdev/matrox/i2c-matroxfb.c
index 34e2659c3189..e2e4705e3fe0 100644
--- a/drivers/video/fbdev/matrox/i2c-matroxfb.c
+++ b/drivers/video/fbdev/matrox/i2c-matroxfb.c
@@ -191,8 +191,8 @@ static void* i2c_matroxfb_probe(struct matrox_fb_info* minfo) {
0x1b, I2C_CLIENT_END
};
- i2c_new_probed_device(&m2info->maven.adapter,
- &maven_info, addr_list, NULL);
+ i2c_new_scanned_device(&m2info->maven.adapter,
+ &maven_info, addr_list, NULL);
}
}
return m2info;
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [RFC PATCH 00/12] i2c: replace i2c_new_probed_device with an ERR_PTR variant
2019-11-06 9:50 [RFC PATCH 00/12] i2c: replace i2c_new_probed_device with an ERR_PTR variant Wolfram Sang
2019-11-06 9:50 ` [RFC PATCH 05/12] video: fbdev: matrox: convert to i2c_new_scanned_device Wolfram Sang
@ 2019-11-06 10:06 ` Sean Young
1 sibling, 0 replies; 6+ messages in thread
From: Sean Young @ 2019-11-06 10:06 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-i2c, Wolfram Sang, dri-devel, linux-fbdev, linux-input,
linux-kernel, linux-media, linuxppc-dev
On Wed, Nov 06, 2019 at 10:50:18AM +0100, Wolfram Sang wrote:
> From: Wolfram Sang <wsa@the-dreams.de>
>
> In the on-going mission to let i2c_new_* calls return an ERR_PTR instead
> of NULL, here is a series converting i2c_new_probed_device(). A new
> function called i2c_new_scanned_device() is introduced with the new
> retval, but for now, a compatibility helper is provided until all users
> are converted. The rest of the patches convert all current in-tree
> users.
>
> Note that these patches are RFC because I want feedback on the approach
> and hopefully collect acks on the driver conversions. If all goes well,
> I'll apply the first two patches for the next merge window. Then, once
> this dependency is upstream, I'll resend this series with all issues
> fixed and acks collected.
The patches to drivers/media/pci/* are all IR related which have touched
on/read over the years. So, for those:
Acked-by: Sean Young <sean@mess.org>
>
> Core changes tested on a Renesas Salvator-XS board (R-Car M3-N), driver
> patches build tested by me and buildbot.
>
> Wolfram Sang (12):
> i2c: replace i2c_new_probed_device with an ERR_PTR variant
> i2c: icy: convert to i2c_new_scanned_device
> macintosh: convert to i2c_new_scanned_device
> platform: chrome: convert to i2c_new_scanned_device
> video: fbdev: matrox: convert to i2c_new_scanned_device
> input: mouse: convert to i2c_new_scanned_device
> media: pci: cx23885: convert to i2c_new_scanned_device
> media: pci: cx88: convert to i2c_new_scanned_device
> media: pci: bt8xx: convert to i2c_new_scanned_device
> media: pci: cx18: convert to i2c_new_scanned_device
> media: pci: ivtv: convert to i2c_new_scanned_device
> media: v4l2-core: convert to i2c_new_scanned_device
>
> Documentation/i2c/instantiating-devices.rst | 10 ++++-----
> Documentation/i2c/writing-clients.rst | 8 +++----
> drivers/i2c/busses/i2c-icy.c | 8 +++----
> drivers/i2c/i2c-core-base.c | 25 ++++++++++++++++-----
> drivers/input/mouse/psmouse-smbus.c | 8 ++++---
> drivers/macintosh/therm_windtunnel.c | 4 ++--
> drivers/media/pci/bt8xx/bttv-input.c | 6 ++---
> drivers/media/pci/cx18/cx18-i2c.c | 2 +-
> drivers/media/pci/cx23885/cx23885-i2c.c | 4 ++--
> drivers/media/pci/cx88/cx88-input.c | 2 +-
> drivers/media/pci/ivtv/ivtv-i2c.c | 6 ++---
> drivers/media/pci/ivtv/ivtv-i2c.h | 2 +-
> drivers/media/v4l2-core/v4l2-i2c.c | 10 ++++-----
> drivers/platform/chrome/chromeos_laptop.c | 18 ++++++++-------
> drivers/video/fbdev/matrox/i2c-matroxfb.c | 4 ++--
> include/linux/i2c.h | 12 +++++++---
> 16 files changed, 76 insertions(+), 53 deletions(-)
>
> --
> 2.20.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC PATCH 05/12] video: fbdev: matrox: convert to i2c_new_scanned_device
2019-11-06 9:50 ` [RFC PATCH 05/12] video: fbdev: matrox: convert to i2c_new_scanned_device Wolfram Sang
@ 2019-11-07 8:33 ` Daniel Vetter
2019-11-28 16:18 ` Wolfram Sang
2019-11-28 16:19 ` Wolfram Sang
1 sibling, 1 reply; 6+ messages in thread
From: Daniel Vetter @ 2019-11-07 8:33 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-i2c, linux-fbdev, linux-kernel, dri-devel,
Bartlomiej Zolnierkiewicz
On Wed, Nov 06, 2019 at 10:50:23AM +0100, Wolfram Sang wrote:
> Move from the deprecated i2c_new_probed_device() to the new
> i2c_new_scanned_device(). Make use of the new ERRPTR if suitable.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Ack for merging through whatever tree you think this should best land
through.
-Daniel
> ---
>
> Build tested only. RFC, please comment and/or ack, but don't apply yet.
>
> drivers/video/fbdev/matrox/i2c-matroxfb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/matrox/i2c-matroxfb.c b/drivers/video/fbdev/matrox/i2c-matroxfb.c
> index 34e2659c3189..e2e4705e3fe0 100644
> --- a/drivers/video/fbdev/matrox/i2c-matroxfb.c
> +++ b/drivers/video/fbdev/matrox/i2c-matroxfb.c
> @@ -191,8 +191,8 @@ static void* i2c_matroxfb_probe(struct matrox_fb_info* minfo) {
> 0x1b, I2C_CLIENT_END
> };
>
> - i2c_new_probed_device(&m2info->maven.adapter,
> - &maven_info, addr_list, NULL);
> + i2c_new_scanned_device(&m2info->maven.adapter,
> + &maven_info, addr_list, NULL);
> }
> }
> return m2info;
> --
> 2.20.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC PATCH 05/12] video: fbdev: matrox: convert to i2c_new_scanned_device
2019-11-07 8:33 ` Daniel Vetter
@ 2019-11-28 16:18 ` Wolfram Sang
0 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2019-11-28 16:18 UTC (permalink / raw)
To: Wolfram Sang, linux-i2c, linux-fbdev, linux-kernel, dri-devel,
Bartlomiej Zolnierkiewicz
[-- Attachment #1: Type: text/plain, Size: 517 bytes --]
On Thu, Nov 07, 2019 at 09:33:54AM +0100, Daniel Vetter wrote:
> On Wed, Nov 06, 2019 at 10:50:23AM +0100, Wolfram Sang wrote:
> > Move from the deprecated i2c_new_probed_device() to the new
> > i2c_new_scanned_device(). Make use of the new ERRPTR if suitable.
> >
> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> Ack for merging through whatever tree you think this should best land
> through.
Ok, because it is a single and simple patch, I'll apply it simply via
I2C. Thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC PATCH 05/12] video: fbdev: matrox: convert to i2c_new_scanned_device
2019-11-06 9:50 ` [RFC PATCH 05/12] video: fbdev: matrox: convert to i2c_new_scanned_device Wolfram Sang
2019-11-07 8:33 ` Daniel Vetter
@ 2019-11-28 16:19 ` Wolfram Sang
1 sibling, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2019-11-28 16:19 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-i2c, Bartlomiej Zolnierkiewicz, dri-devel, linux-fbdev,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 299 bytes --]
On Wed, Nov 06, 2019 at 10:50:23AM +0100, Wolfram Sang wrote:
> Move from the deprecated i2c_new_probed_device() to the new
> i2c_new_scanned_device(). Make use of the new ERRPTR if suitable.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-11-28 16:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-06 9:50 [RFC PATCH 00/12] i2c: replace i2c_new_probed_device with an ERR_PTR variant Wolfram Sang
2019-11-06 9:50 ` [RFC PATCH 05/12] video: fbdev: matrox: convert to i2c_new_scanned_device Wolfram Sang
2019-11-07 8:33 ` Daniel Vetter
2019-11-28 16:18 ` Wolfram Sang
2019-11-28 16:19 ` Wolfram Sang
2019-11-06 10:06 ` [RFC PATCH 00/12] i2c: replace i2c_new_probed_device with an ERR_PTR variant Sean Young
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).