* [PATCH -next] omapfb: connector-dvi: simplify the return expression of dvic_connect()
@ 2020-09-15 3:26 Liu Shixin
2020-10-17 6:20 ` Sam Ravnborg
0 siblings, 1 reply; 3+ messages in thread
From: Liu Shixin @ 2020-09-15 3:26 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: Liu Shixin, linux-fbdev, linux-omap, linux-kernel, dri-devel
Simplify the return expression.
Signed-off-by: Liu Shixin <liushixin2@huawei.com>
---
drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c b/drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c
index b4a1aefff766..2fa436475b40 100644
--- a/drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c
+++ b/drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c
@@ -51,16 +51,11 @@ static int dvic_connect(struct omap_dss_device *dssdev)
{
struct panel_drv_data *ddata = to_panel_data(dssdev);
struct omap_dss_device *in = ddata->in;
- int r;
if (omapdss_device_is_connected(dssdev))
return 0;
- r = in->ops.dvi->connect(in, dssdev);
- if (r)
- return r;
-
- return 0;
+ return in->ops.dvi->connect(in, dssdev);
}
static void dvic_disconnect(struct omap_dss_device *dssdev)
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] omapfb: connector-dvi: simplify the return expression of dvic_connect()
2020-09-15 3:26 [PATCH -next] omapfb: connector-dvi: simplify the return expression of dvic_connect() Liu Shixin
@ 2020-10-17 6:20 ` Sam Ravnborg
2020-10-17 6:20 ` Sam Ravnborg
0 siblings, 1 reply; 3+ messages in thread
From: Sam Ravnborg @ 2020-10-17 6:20 UTC (permalink / raw)
To: Liu Shixin
Cc: linux-fbdev, linux-omap, linux-kernel, dri-devel,
Bartlomiej Zolnierkiewicz
Hi Liu.
On Tue, Sep 15, 2020 at 11:26:27AM +0800, Liu Shixin wrote:
> Simplify the return expression.
>
> Signed-off-by: Liu Shixin <liushixin2@huawei.com>
Thanks, also applied.
If you have other drm/fbdev patches pending then I have missed them.
So please resend if this is the case.
Sam
> ---
> drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c b/drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c
> index b4a1aefff766..2fa436475b40 100644
> --- a/drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c
> +++ b/drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c
> @@ -51,16 +51,11 @@ static int dvic_connect(struct omap_dss_device *dssdev)
> {
> struct panel_drv_data *ddata = to_panel_data(dssdev);
> struct omap_dss_device *in = ddata->in;
> - int r;
>
> if (omapdss_device_is_connected(dssdev))
> return 0;
>
> - r = in->ops.dvi->connect(in, dssdev);
> - if (r)
> - return r;
> -
> - return 0;
> + return in->ops.dvi->connect(in, dssdev);
> }
>
> static void dvic_disconnect(struct omap_dss_device *dssdev)
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] omapfb: connector-dvi: simplify the return expression of dvic_connect()
2020-10-17 6:20 ` Sam Ravnborg
@ 2020-10-17 6:20 ` Sam Ravnborg
0 siblings, 0 replies; 3+ messages in thread
From: Sam Ravnborg @ 2020-10-17 6:20 UTC (permalink / raw)
To: Liu Shixin
Cc: Bartlomiej Zolnierkiewicz, linux-fbdev, linux-omap, linux-kernel,
dri-devel
Hi Liu.
On Tue, Sep 15, 2020 at 11:26:27AM +0800, Liu Shixin wrote:
> Simplify the return expression.
>
> Signed-off-by: Liu Shixin <liushixin2@huawei.com>
Thanks, also applied.
If you have other drm/fbdev patches pending then I have missed them.
So please resend if this is the case.
Sam
> ---
> drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c b/drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c
> index b4a1aefff766..2fa436475b40 100644
> --- a/drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c
> +++ b/drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c
> @@ -51,16 +51,11 @@ static int dvic_connect(struct omap_dss_device *dssdev)
> {
> struct panel_drv_data *ddata = to_panel_data(dssdev);
> struct omap_dss_device *in = ddata->in;
> - int r;
>
> if (omapdss_device_is_connected(dssdev))
> return 0;
>
> - r = in->ops.dvi->connect(in, dssdev);
> - if (r)
> - return r;
> -
> - return 0;
> + return in->ops.dvi->connect(in, dssdev);
> }
>
> static void dvic_disconnect(struct omap_dss_device *dssdev)
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-17 6:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-15 3:26 [PATCH -next] omapfb: connector-dvi: simplify the return expression of dvic_connect() Liu Shixin
2020-10-17 6:20 ` Sam Ravnborg
2020-10-17 6:20 ` Sam Ravnborg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).