Linux-fbdev Archive on
 help / color / Atom feed
From: Sam Ravnborg <>
To: Alex Shi <>
Subject: Re: [PATCH] video: fbdev: riva: remove some unused varibles
Date: Mon, 9 Nov 2020 08:31:27 +0100
Message-ID: <> (raw)
In-Reply-To: <>

Hi Alex,

On Sun, Nov 08, 2020 at 04:01:59PM +0800, Alex Shi wrote:
> Couple of variables are actually useless, remove them to save some gcc
> warning:
> drivers/video/fbdev/riva/riva_hw.c:250:21: warning: variable ‘mlwm’ set
> but not used [-Wunused-but-set-variable]
> drivers/video/fbdev/riva/riva_hw.c:665:15: warning: variable ‘vraw’ set
> but not used [-Wunused-but-set-variable]
> drivers/video/fbdev/riva/riva_hw.c:665:9: warning: variable ‘craw’ set
> but not used [-Wunused-but-set-variable]
> drivers/video/fbdev/riva/riva_hw.c:659:73: warning: variable ‘align’ set
> but not used [-Wunused-but-set-variable]
> drivers/video/fbdev/riva/riva_hw.c:659:50: warning: variable
> ‘color_key_enable’ set but not used [-Wunused-but-set-variable]
> Signed-off-by: Alex Shi <>
> Cc: Antonino Daplas <> 
> Cc: 
> Cc: 
> Cc: 

Thanks, applied to drm-misc-next. The fix will appear in -next in a week
or so.


      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-08  8:01 Alex Shi
2020-11-09  7:31 ` Sam Ravnborg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-fbdev Archive on

Archives are clonable:
	git clone --mirror linux-fbdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-fbdev linux-fbdev/ \
	public-inbox-index linux-fbdev

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone