linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] backlight: sky81452-backlight: convert comma to semicolon
@ 2020-12-14 13:34 Zheng Yongjun
  2020-12-14 14:36 ` Daniel Thompson
  2020-12-16 14:36 ` Lee Jones
  0 siblings, 2 replies; 4+ messages in thread
From: Zheng Yongjun @ 2020-12-14 13:34 UTC (permalink / raw)
  To: lee.jones, daniel.thompson, jingoohan1, b.zolnierkie
  Cc: dri-devel, linux-fbdev, linux-kernel, Zheng Yongjun

Replace a comma between expression statements by a semicolon.

Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
 drivers/video/backlight/sky81452-backlight.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/backlight/sky81452-backlight.c b/drivers/video/backlight/sky81452-backlight.c
index 8268ac43d54f..c95e0de7f4e7 100644
--- a/drivers/video/backlight/sky81452-backlight.c
+++ b/drivers/video/backlight/sky81452-backlight.c
@@ -291,7 +291,7 @@ static int sky81452_bl_probe(struct platform_device *pdev)
 	}
 
 	memset(&props, 0, sizeof(props));
-	props.max_brightness = SKY81452_MAX_BRIGHTNESS,
+	props.max_brightness = SKY81452_MAX_BRIGHTNESS;
 	name = pdata->name ? pdata->name : SKY81452_DEFAULT_NAME;
 	bd = devm_backlight_device_register(dev, name, dev, regmap,
 						&sky81452_bl_ops, &props);
-- 
2.22.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH -next] backlight: sky81452-backlight: convert comma to semicolon
  2020-12-14 13:34 [PATCH -next] backlight: sky81452-backlight: convert comma to semicolon Zheng Yongjun
@ 2020-12-14 14:36 ` Daniel Thompson
  2020-12-15  8:04   ` Lee Jones
  2020-12-16 14:36 ` Lee Jones
  1 sibling, 1 reply; 4+ messages in thread
From: Daniel Thompson @ 2020-12-14 14:36 UTC (permalink / raw)
  To: Zheng Yongjun
  Cc: lee.jones, jingoohan1, b.zolnierkie, dri-devel, linux-fbdev,
	linux-kernel

On Mon, Dec 14, 2020 at 09:34:58PM +0800, Zheng Yongjun wrote:
> Replace a comma between expression statements by a semicolon.
> 
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>

Weird! I guess it was harmless but still seriously weird ;-)

Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>

Thanks!


> ---
>  drivers/video/backlight/sky81452-backlight.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/backlight/sky81452-backlight.c b/drivers/video/backlight/sky81452-backlight.c
> index 8268ac43d54f..c95e0de7f4e7 100644
> --- a/drivers/video/backlight/sky81452-backlight.c
> +++ b/drivers/video/backlight/sky81452-backlight.c
> @@ -291,7 +291,7 @@ static int sky81452_bl_probe(struct platform_device *pdev)
>  	}
>  
>  	memset(&props, 0, sizeof(props));
> -	props.max_brightness = SKY81452_MAX_BRIGHTNESS,
> +	props.max_brightness = SKY81452_MAX_BRIGHTNESS;
>  	name = pdata->name ? pdata->name : SKY81452_DEFAULT_NAME;
>  	bd = devm_backlight_device_register(dev, name, dev, regmap,
>  						&sky81452_bl_ops, &props);
> -- 
> 2.22.0
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH -next] backlight: sky81452-backlight: convert comma to semicolon
  2020-12-14 14:36 ` Daniel Thompson
@ 2020-12-15  8:04   ` Lee Jones
  0 siblings, 0 replies; 4+ messages in thread
From: Lee Jones @ 2020-12-15  8:04 UTC (permalink / raw)
  To: Daniel Thompson
  Cc: Zheng Yongjun, jingoohan1, b.zolnierkie, dri-devel, linux-fbdev,
	linux-kernel

On Mon, 14 Dec 2020, Daniel Thompson wrote:

> On Mon, Dec 14, 2020 at 09:34:58PM +0800, Zheng Yongjun wrote:
> > Replace a comma between expression statements by a semicolon.
> > 
> > Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> 
> Weird! I guess it was harmless but still seriously weird ;-)

One of these was found in MFD a couple of weeks ago.

Yours was exactly my train of thought!

One suggestion was to convert all semi-colons to commas and do away
with all the curly braces encapsulating if()s, for()s and while()s.

Who knew that was even possible?

> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> 
> Thanks!
> 
> 
> > ---
> >  drivers/video/backlight/sky81452-backlight.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/video/backlight/sky81452-backlight.c b/drivers/video/backlight/sky81452-backlight.c
> > index 8268ac43d54f..c95e0de7f4e7 100644
> > --- a/drivers/video/backlight/sky81452-backlight.c
> > +++ b/drivers/video/backlight/sky81452-backlight.c
> > @@ -291,7 +291,7 @@ static int sky81452_bl_probe(struct platform_device *pdev)
> >  	}
> >  
> >  	memset(&props, 0, sizeof(props));
> > -	props.max_brightness = SKY81452_MAX_BRIGHTNESS,
> > +	props.max_brightness = SKY81452_MAX_BRIGHTNESS;
> >  	name = pdata->name ? pdata->name : SKY81452_DEFAULT_NAME;
> >  	bd = devm_backlight_device_register(dev, name, dev, regmap,
> >  						&sky81452_bl_ops, &props);

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH -next] backlight: sky81452-backlight: convert comma to semicolon
  2020-12-14 13:34 [PATCH -next] backlight: sky81452-backlight: convert comma to semicolon Zheng Yongjun
  2020-12-14 14:36 ` Daniel Thompson
@ 2020-12-16 14:36 ` Lee Jones
  1 sibling, 0 replies; 4+ messages in thread
From: Lee Jones @ 2020-12-16 14:36 UTC (permalink / raw)
  To: Zheng Yongjun
  Cc: daniel.thompson, jingoohan1, b.zolnierkie, dri-devel,
	linux-fbdev, linux-kernel

On Mon, 14 Dec 2020, Zheng Yongjun wrote:

> Replace a comma between expression statements by a semicolon.
> 
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
>  drivers/video/backlight/sky81452-backlight.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-12-16 14:37 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-14 13:34 [PATCH -next] backlight: sky81452-backlight: convert comma to semicolon Zheng Yongjun
2020-12-14 14:36 ` Daniel Thompson
2020-12-15  8:04   ` Lee Jones
2020-12-16 14:36 ` Lee Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).