linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] staging: fbtft: fix a typo
@ 2021-03-26  8:05 Carlis
  2021-03-26  8:37 ` Greg KH
  0 siblings, 1 reply; 5+ messages in thread
From: Carlis @ 2021-03-26  8:05 UTC (permalink / raw)
  To: gregkh, zhangxuezhi1; +Cc: dri-devel, linux-fbdev, linux-staging, linux-kernel

From: "Carlis" <zhangxuezhi1@yulong.com>

Change 'tft' to 'TFT'

Signed-off-by: Carlis <zhangxuezhi1@yulong.com>
---
 drivers/staging/fbtft/fbtft-core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c
index 4f362da..44e7acb 100644
--- a/drivers/staging/fbtft/fbtft-core.c
+++ b/drivers/staging/fbtft/fbtft-core.c
@@ -775,7 +775,7 @@ void fbtft_framebuffer_release(struct fb_info *info)
 EXPORT_SYMBOL(fbtft_framebuffer_release);
 
 /**
- *	fbtft_register_framebuffer - registers a tft frame buffer device
+ *	fbtft_register_framebuffer - registers a TFT frame buffer device
  *	@fb_info: frame buffer info structure
  *
  *  Sets SPI driverdata if needed
@@ -873,7 +873,7 @@ int fbtft_register_framebuffer(struct fb_info *fb_info)
 EXPORT_SYMBOL(fbtft_register_framebuffer);
 
 /**
- *	fbtft_unregister_framebuffer - releases a tft frame buffer device
+ *	fbtft_unregister_framebuffer - releases a TFT frame buffer device
  *	@fb_info: frame buffer info structure
  *
  *  Frees SPI driverdata if needed
-- 
1.9.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] staging: fbtft: fix a typo
  2021-03-26  8:05 [PATCH] staging: fbtft: fix a typo Carlis
@ 2021-03-26  8:37 ` Greg KH
  2021-03-26  9:16   ` carlis
  0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2021-03-26  8:37 UTC (permalink / raw)
  To: Carlis; +Cc: zhangxuezhi1, dri-devel, linux-fbdev, linux-staging, linux-kernel

On Fri, Mar 26, 2021 at 04:05:15PM +0800, Carlis wrote:
> From: "Carlis" <zhangxuezhi1@yulong.com>
> 
> Change 'tft' to 'TFT'

Why?  What is wrong with "tft"?

> 
> Signed-off-by: Carlis <zhangxuezhi1@yulong.com>

Full name please.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] staging: fbtft: fix a typo
  2021-03-26  8:37 ` Greg KH
@ 2021-03-26  9:16   ` carlis
  2021-03-26  9:33     ` Greg KH
  0 siblings, 1 reply; 5+ messages in thread
From: carlis @ 2021-03-26  9:16 UTC (permalink / raw)
  To: Greg KH; +Cc: zhangxuezhi1, dri-devel, linux-fbdev, linux-staging, linux-kernel

On Fri, 26 Mar 2021 09:37:48 +0100
Greg KH <gregkh@linuxfoundation.org> wrote:

> On Fri, Mar 26, 2021 at 04:05:15PM +0800, Carlis wrote:
> > From: "Carlis" <zhangxuezhi1@yulong.com>
> > 
> > Change 'tft' to 'TFT'  
> 
> Why?  What is wrong with "tft"?
> 
I think abbreviations should be capitalized.
> > 
> > Signed-off-by: Carlis <zhangxuezhi1@yulong.com>  
> 
> Full name please.
> 
OK, i will use my full name next patch
> thanks,
> 
> greg k-h


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] staging: fbtft: fix a typo
  2021-03-26  9:16   ` carlis
@ 2021-03-26  9:33     ` Greg KH
  2021-03-26  9:57       ` carlis
  0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2021-03-26  9:33 UTC (permalink / raw)
  To: carlis; +Cc: zhangxuezhi1, dri-devel, linux-fbdev, linux-staging, linux-kernel

On Fri, Mar 26, 2021 at 05:16:34PM +0800, carlis wrote:
> On Fri, 26 Mar 2021 09:37:48 +0100
> Greg KH <gregkh@linuxfoundation.org> wrote:
> 
> > On Fri, Mar 26, 2021 at 04:05:15PM +0800, Carlis wrote:
> > > From: "Carlis" <zhangxuezhi1@yulong.com>
> > > 
> > > Change 'tft' to 'TFT'  
> > 
> > Why?  What is wrong with "tft"?
> > 
> I think abbreviations should be capitalized.

Why?  What requires this?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] staging: fbtft: fix a typo
  2021-03-26  9:33     ` Greg KH
@ 2021-03-26  9:57       ` carlis
  0 siblings, 0 replies; 5+ messages in thread
From: carlis @ 2021-03-26  9:57 UTC (permalink / raw)
  To: Greg KH; +Cc: zhangxuezhi1, dri-devel, linux-fbdev, linux-staging, linux-kernel

On Fri, 26 Mar 2021 10:33:57 +0100
Greg KH <gregkh@linuxfoundation.org> wrote:

> On Fri, Mar 26, 2021 at 05:16:34PM +0800, carlis wrote:
> > On Fri, 26 Mar 2021 09:37:48 +0100
> > Greg KH <gregkh@linuxfoundation.org> wrote:
> >   
> > > On Fri, Mar 26, 2021 at 04:05:15PM +0800, Carlis wrote:  
> > > > From: "Carlis" <zhangxuezhi1@yulong.com>
> > > > 
> > > > Change 'tft' to 'TFT'    
> > > 
> > > Why?  What is wrong with "tft"?
> > >   
> > I think abbreviations should be capitalized.  
> 
> Why?  What requires this?
Many people use capital letters for abbreviations in comments, which I
think is a good practice
> 
> thanks,
> 
> greg k-h

thanks,
Xuezhi Zhang

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-03-26  9:58 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-26  8:05 [PATCH] staging: fbtft: fix a typo Carlis
2021-03-26  8:37 ` Greg KH
2021-03-26  9:16   ` carlis
2021-03-26  9:33     ` Greg KH
2021-03-26  9:57       ` carlis

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).