From: Anirudh Rayabharam <mail@anirudhrb.com>
To: Ferenc Bakonyi <fero@drama.obuda.kando.hu>,
Igor Matheus Andrade Torrente <igormtorrente@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
Anirudh Rayabharam <mail@anirudhrb.com>,
kernel test robot <oliver.sang@intel.com>,
stable <stable@vger.kernel.org>,
linux-nvidia@lists.surfsouth.com,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] video: hgafb: correctly handle card detect failure during probe
Date: Mon, 17 May 2021 00:57:14 +0530 [thread overview]
Message-ID: <20210516192714.25823-1-mail@anirudhrb.com> (raw)
The return value of hga_card_detect() is not properly handled causing
the probe to succeed even though hga_card_detect() failed. Since probe
succeeds, hgafb_open() can be called which will end up operating on an
unmapped hga_vram. This results in an out-of-bounds access as reported
by kernel test robot [1].
To fix this, correctly detect failure of hga_card_detect() by checking
for a non-zero error code.
[1]: https://lore.kernel.org/lkml/20210516150019.GB25903@xsang-OptiPlex-9020/
Reported-by: kernel test robot <oliver.sang@intel.com>
Fixes: dc13cac4862c ("video: hgafb: fix potential NULL pointer dereference")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Anirudh Rayabharam <mail@anirudhrb.com>
---
drivers/video/fbdev/hgafb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/hgafb.c b/drivers/video/fbdev/hgafb.c
index cc8e62ae93f6..bd3d07aa4f0e 100644
--- a/drivers/video/fbdev/hgafb.c
+++ b/drivers/video/fbdev/hgafb.c
@@ -558,7 +558,7 @@ static int hgafb_probe(struct platform_device *pdev)
int ret;
ret = hga_card_detect();
- if (!ret)
+ if (ret)
return ret;
printk(KERN_INFO "hgafb: %s with %ldK of memory detected.\n",
--
2.26.2
next reply other threads:[~2021-05-16 19:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-16 19:27 Anirudh Rayabharam [this message]
2021-05-17 12:27 ` Igor Torrente
2021-05-20 13:40 ` Anirudh Rayabharam
2021-05-20 13:58 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210516192714.25823-1-mail@anirudhrb.com \
--to=mail@anirudhrb.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=fero@drama.obuda.kando.hu \
--cc=gregkh@linuxfoundation.org \
--cc=igormtorrente@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvidia@lists.surfsouth.com \
--cc=oliver.sang@intel.com \
--cc=stable@vger.kernel.org \
--subject='Re: [PATCH] video: hgafb: correctly handle card detect failure during probe' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).