[PATCH 1/6] fbdev: da8xx-fb: Make use of the helper function dev_err

linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH 1/6] fbdev: da8xx-fb: Make use of the helper function dev_err_probe()
@ 2021-09-17  4:22 Cai Huoqing
  2021-09-17  4:22 ` [PATCH 2/6] fbdev: pxa168fb: " Cai Huoqing
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Cai Huoqing @ 2021-09-17  4:22 UTC (permalink / raw)
  To: caihuoqing; +Cc: Jingoo Han, dri-devel, linux-fbdev, linux-kernel

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
 drivers/video/fbdev/da8xx-fb.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/video/fbdev/da8xx-fb.c b/drivers/video/fbdev/da8xx-fb.c
index 005ac3c17aa1..ae76a2111c77 100644
--- a/drivers/video/fbdev/da8xx-fb.c
+++ b/drivers/video/fbdev/da8xx-fb.c
@@ -1354,10 +1354,9 @@ static int fb_probe(struct platform_device *device)
 		return PTR_ERR(da8xx_fb_reg_base);
 
 	tmp_lcdc_clk = devm_clk_get(&device->dev, "fck");
-	if (IS_ERR(tmp_lcdc_clk)) {
-		dev_err(&device->dev, "Can not get device clock\n");
-		return PTR_ERR(tmp_lcdc_clk);
-	}
+	if (IS_ERR(tmp_lcdc_clk))
+		return dev_err_probe(&device->dev, PTR_ERR(tmp_lcdc_clk),
+				     "Can not get device clock\n");
 
 	pm_runtime_enable(&device->dev);
 	pm_runtime_get_sync(&device->dev);
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/6] fbdev: pxa168fb: Make use of the helper function dev_err_probe()
  2021-09-17  4:22 [PATCH 1/6] fbdev: da8xx-fb: Make use of the helper function dev_err_probe() Cai Huoqing
@ 2021-09-17  4:22 ` Cai Huoqing
  2021-09-17  4:22 ` [PATCH 3/6] fbdev: pxa3xx-gcu: " Cai Huoqing
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Cai Huoqing @ 2021-09-17  4:22 UTC (permalink / raw)
  To: caihuoqing; +Cc: Jingoo Han, dri-devel, linux-fbdev, linux-kernel

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
 drivers/video/fbdev/pxa168fb.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/video/fbdev/pxa168fb.c b/drivers/video/fbdev/pxa168fb.c
index 47e6a1d0d229..35cf806a9219 100644
--- a/drivers/video/fbdev/pxa168fb.c
+++ b/drivers/video/fbdev/pxa168fb.c
@@ -606,10 +606,9 @@ static int pxa168fb_probe(struct platform_device *pdev)
 	}
 
 	clk = devm_clk_get(&pdev->dev, "LCDCLK");
-	if (IS_ERR(clk)) {
-		dev_err(&pdev->dev, "unable to get LCDCLK");
-		return PTR_ERR(clk);
-	}
+	if (IS_ERR(clk))
+		return dev_err_probe(&pdev->dev, PTR_ERR(clk),
+				     "unable to get LCDCLK");
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	if (res == NULL) {
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 3/6] fbdev: pxa3xx-gcu: Make use of the helper function dev_err_probe()
  2021-09-17  4:22 [PATCH 1/6] fbdev: da8xx-fb: Make use of the helper function dev_err_probe() Cai Huoqing
  2021-09-17  4:22 ` [PATCH 2/6] fbdev: pxa168fb: " Cai Huoqing
@ 2021-09-17  4:22 ` Cai Huoqing
  2021-09-17  4:22 ` [PATCH 4/6] fbdev: ssd1307fb: " Cai Huoqing
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Cai Huoqing @ 2021-09-17  4:22 UTC (permalink / raw)
  To: caihuoqing; +Cc: Jingoo Han, dri-devel, linux-fbdev, linux-kernel

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
 drivers/video/fbdev/pxa3xx-gcu.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/video/fbdev/pxa3xx-gcu.c b/drivers/video/fbdev/pxa3xx-gcu.c
index 4279e13a3b58..9239ecd34169 100644
--- a/drivers/video/fbdev/pxa3xx-gcu.c
+++ b/drivers/video/fbdev/pxa3xx-gcu.c
@@ -606,10 +606,8 @@ static int pxa3xx_gcu_probe(struct platform_device *pdev)
 
 	/* enable the clock */
 	priv->clk = devm_clk_get(dev, NULL);
-	if (IS_ERR(priv->clk)) {
-		dev_err(dev, "failed to get clock\n");
-		return PTR_ERR(priv->clk);
-	}
+	if (IS_ERR(priv->clk))
+		return dev_err_probe(dev, PTR_ERR(priv->clk), "failed to get clock\n");
 
 	/* request the IRQ */
 	irq = platform_get_irq(pdev, 0);
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 4/6] fbdev: ssd1307fb: Make use of the helper function dev_err_probe()
  2021-09-17  4:22 [PATCH 1/6] fbdev: da8xx-fb: Make use of the helper function dev_err_probe() Cai Huoqing
  2021-09-17  4:22 ` [PATCH 2/6] fbdev: pxa168fb: " Cai Huoqing
  2021-09-17  4:22 ` [PATCH 3/6] fbdev: pxa3xx-gcu: " Cai Huoqing
@ 2021-09-17  4:22 ` Cai Huoqing
  2021-09-17  4:22 ` [PATCH 5/6] fbdev: s3c-fb: " Cai Huoqing
  2021-09-17  4:22 ` [PATCH 6/6] fbdev: mmp: " Cai Huoqing
  4 siblings, 0 replies; 6+ messages in thread
From: Cai Huoqing @ 2021-09-17  4:22 UTC (permalink / raw)
  To: caihuoqing; +Cc: Jingoo Han, dri-devel, linux-fbdev, linux-kernel

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
 drivers/video/fbdev/ssd1307fb.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c
index 1e2f71c2f8a8..c6d5df31111d 100644
--- a/drivers/video/fbdev/ssd1307fb.c
+++ b/drivers/video/fbdev/ssd1307fb.c
@@ -658,9 +658,8 @@ static int ssd1307fb_probe(struct i2c_client *client)
 
 	par->reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);
 	if (IS_ERR(par->reset)) {
-		dev_err(dev, "failed to get reset gpio: %ld\n",
-			PTR_ERR(par->reset));
-		ret = PTR_ERR(par->reset);
+		ret = dev_err_probe(dev, PTR_ERR(par->reset),
+				    "failed to get reset gpio\n");
 		goto fb_alloc_error;
 	}
 
@@ -670,7 +669,7 @@ static int ssd1307fb_probe(struct i2c_client *client)
 		if (ret == -ENODEV) {
 			par->vbat_reg = NULL;
 		} else {
-			dev_err(dev, "failed to get VBAT regulator: %d\n", ret);
+			dev_err_probe(dev, ret, "failed to get VBAT regulator\n");
 			goto fb_alloc_error;
 		}
 	}
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 5/6] fbdev: s3c-fb: Make use of the helper function dev_err_probe()
  2021-09-17  4:22 [PATCH 1/6] fbdev: da8xx-fb: Make use of the helper function dev_err_probe() Cai Huoqing
                   ` (2 preceding siblings ...)
  2021-09-17  4:22 ` [PATCH 4/6] fbdev: ssd1307fb: " Cai Huoqing
@ 2021-09-17  4:22 ` Cai Huoqing
  2021-09-17  4:22 ` [PATCH 6/6] fbdev: mmp: " Cai Huoqing
  4 siblings, 0 replies; 6+ messages in thread
From: Cai Huoqing @ 2021-09-17  4:22 UTC (permalink / raw)
  To: caihuoqing; +Cc: Jingoo Han, dri-devel, linux-fbdev, linux-kernel

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
 drivers/video/fbdev/s3c-fb.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c
index 3b134e1bbc38..459d159879a3 100644
--- a/drivers/video/fbdev/s3c-fb.c
+++ b/drivers/video/fbdev/s3c-fb.c
@@ -1392,18 +1392,17 @@ static int s3c_fb_probe(struct platform_device *pdev)
 	spin_lock_init(&sfb->slock);
 
 	sfb->bus_clk = devm_clk_get(dev, "lcd");
-	if (IS_ERR(sfb->bus_clk)) {
-		dev_err(dev, "failed to get bus clock\n");
-		return PTR_ERR(sfb->bus_clk);
-	}
+	if (IS_ERR(sfb->bus_clk))
+		return dev_err_probe(dev, PTR_ERR(sfb->bus_clk),
+				     "failed to get bus clock\n");
 
 	clk_prepare_enable(sfb->bus_clk);
 
 	if (!sfb->variant.has_clksel) {
 		sfb->lcd_clk = devm_clk_get(dev, "sclk_fimd");
 		if (IS_ERR(sfb->lcd_clk)) {
-			dev_err(dev, "failed to get lcd clock\n");
-			ret = PTR_ERR(sfb->lcd_clk);
+			ret = dev_err_probe(dev, PTR_ERR(sfb->lcd_clk),
+					    "failed to get lcd clock\n");
 			goto err_bus_clk;
 		}
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 6/6] fbdev: mmp: Make use of the helper function dev_err_probe()
  2021-09-17  4:22 [PATCH 1/6] fbdev: da8xx-fb: Make use of the helper function dev_err_probe() Cai Huoqing
                   ` (3 preceding siblings ...)
  2021-09-17  4:22 ` [PATCH 5/6] fbdev: s3c-fb: " Cai Huoqing
@ 2021-09-17  4:22 ` Cai Huoqing
  4 siblings, 0 replies; 6+ messages in thread
From: Cai Huoqing @ 2021-09-17  4:22 UTC (permalink / raw)
  To: caihuoqing; +Cc: Jingoo Han, dri-devel, linux-fbdev, linux-kernel

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
 drivers/video/fbdev/mmp/hw/mmp_ctrl.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/mmp/hw/mmp_ctrl.c b/drivers/video/fbdev/mmp/hw/mmp_ctrl.c
index 061a105afb86..a9df8ee79810 100644
--- a/drivers/video/fbdev/mmp/hw/mmp_ctrl.c
+++ b/drivers/video/fbdev/mmp/hw/mmp_ctrl.c
@@ -514,7 +514,8 @@ static int mmphw_probe(struct platform_device *pdev)
 	/* get clock */
 	ctrl->clk = devm_clk_get(ctrl->dev, mi->clk_name);
 	if (IS_ERR(ctrl->clk)) {
-		dev_err(ctrl->dev, "unable to get clk %s\n", mi->clk_name);
+		dev_err_probe(ctrl->dev, ret,
+			      "unable to get clk %s\n", mi->clk_name);
 		ret = -ENOENT;
 		goto failed;
 	}
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-09-17  4:38 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-17  4:22 [PATCH 1/6] fbdev: da8xx-fb: Make use of the helper function dev_err_probe() Cai Huoqing
2021-09-17  4:22 ` [PATCH 2/6] fbdev: pxa168fb: " Cai Huoqing
2021-09-17  4:22 ` [PATCH 3/6] fbdev: pxa3xx-gcu: " Cai Huoqing
2021-09-17  4:22 ` [PATCH 4/6] fbdev: ssd1307fb: " Cai Huoqing
2021-09-17  4:22 ` [PATCH 5/6] fbdev: s3c-fb: " Cai Huoqing
2021-09-17  4:22 ` [PATCH 6/6] fbdev: mmp: " Cai Huoqing

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).