From: Hyunwoo Kim <imv4bel@gmail.com>
To: deller@gmx.de, linux-fbdev@vger.kernel.org
Subject: [PATCH] pxa3xx-gcu: Fix integer overflow in pxa3xx_gcu_write
Date: Sat, 11 Jun 2022 12:28:51 -0700 [thread overview]
Message-ID: <20220611192851.GA482606@ubuntu> (raw)
In pxa3xx_gcu_write, a count parameter of
type size_t is passed to words of type int.
Then, copy_from_user may cause a heap overflow because
it is used as the third argument of copy_from_user.
Signed-off-by: Hyunwoo Kim <imv4bel@gmail.com>
---
drivers/video/fbdev/pxa3xx-gcu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/pxa3xx-gcu.c b/drivers/video/fbdev/pxa3xx-gcu.c
index 043cc8f9ef1c..5ca6d37e365f 100644
--- a/drivers/video/fbdev/pxa3xx-gcu.c
+++ b/drivers/video/fbdev/pxa3xx-gcu.c
@@ -389,7 +389,7 @@ pxa3xx_gcu_write(struct file *file, const char *buff,
priv->shared->num_words += words;
/* Last word reserved for batch buffer end command */
- if (words >= PXA3XX_GCU_BATCH_WORDS)
+ if (words >= PXA3XX_GCU_BATCH_WORDS || words < 0)
return -E2BIG;
/* Wait for a free buffer */
--
2.25.1
next reply other threads:[~2022-06-11 19:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-11 19:28 Hyunwoo Kim [this message]
2022-06-20 12:50 ` [PATCH] pxa3xx-gcu: Fix integer overflow in pxa3xx_gcu_write Helge Deller
2022-06-20 14:17 ` Hyunwoo Kim
2022-06-20 18:13 ` Helge Deller
2022-06-20 18:16 ` Hyunwoo Kim
2022-09-20 6:02 Dan Carpenter
2022-09-20 6:13 ` Dan Carpenter
2022-09-20 6:22 ` Hyunwoo Kim
2022-09-20 7:12 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220611192851.GA482606@ubuntu \
--to=imv4bel@gmail.com \
--cc=deller@gmx.de \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).