From: Helge Deller <deller@gmx.de>
To: Hyunwoo Kim <imv4bel@gmail.com>
Cc: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] pxa3xx-gcu: Fix integer overflow in pxa3xx_gcu_write
Date: Mon, 20 Jun 2022 20:13:04 +0200 [thread overview]
Message-ID: <8372b659-e964-a82b-b248-0d5654fdc36a@gmx.de> (raw)
In-Reply-To: <20220620141746.GA688683@ubuntu>
On 6/20/22 16:17, Hyunwoo Kim wrote:
> From 1c55d1e084071caf02e7739e71e65f52206e872c Mon Sep 17 00:00:00 2001
> From: Hyunwoo Kim <imv4bel@gmail.com>
> Date: Mon, 20 Jun 2022 07:00:10 -0700
> Subject: [PATCH] pxa3xx-gcu: Fix integer overflow in pxa3xx_gcu_write
>
> In pxa3xx_gcu_write, a count parameter of
> type size_t is passed to words of type int.
> Then, copy_from_user may cause a heap overflow because
> it is used as the third argument of copy_from_user.
>
> Signed-off-by: Hyunwoo Kim <imv4bel@gmail.com>
applied.
Thanks!
Helge
> ---
> drivers/video/fbdev/pxa3xx-gcu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/pxa3xx-gcu.c b/drivers/video/fbdev/pxa3xx-gcu.c
> index 043cc8f9ef1c..c3cd1e1cc01b 100644
> --- a/drivers/video/fbdev/pxa3xx-gcu.c
> +++ b/drivers/video/fbdev/pxa3xx-gcu.c
> @@ -381,7 +381,7 @@ pxa3xx_gcu_write(struct file *file, const char *buff,
> struct pxa3xx_gcu_batch *buffer;
> struct pxa3xx_gcu_priv *priv = to_pxa3xx_gcu_priv(file);
>
> - int words = count / 4;
> + size_t words = count / 4;
>
> /* Does not need to be atomic. There's a lock in user space,
> * but anyhow, this is just for statistics. */
> --
> 2.25.1
>
> Hello Helge,
>
> Fixed the patch as requested.
>
> Regards,
> Hyunwoo Kim
next prev parent reply other threads:[~2022-06-20 18:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-11 19:28 [PATCH] pxa3xx-gcu: Fix integer overflow in pxa3xx_gcu_write Hyunwoo Kim
2022-06-20 12:50 ` Helge Deller
2022-06-20 14:17 ` Hyunwoo Kim
2022-06-20 18:13 ` Helge Deller [this message]
2022-06-20 18:16 ` Hyunwoo Kim
2022-09-20 6:02 Dan Carpenter
2022-09-20 6:13 ` Dan Carpenter
2022-09-20 6:22 ` Hyunwoo Kim
2022-09-20 7:12 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8372b659-e964-a82b-b248-0d5654fdc36a@gmx.de \
--to=deller@gmx.de \
--cc=imv4bel@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).