* [PATCH 03/27] fbdev: remove MODULE_LICENSE in non-modules
[not found] <20230224150811.80316-1-nick.alcock@oracle.com>
@ 2023-02-24 15:07 ` Nick Alcock
0 siblings, 0 replies; only message in thread
From: Nick Alcock @ 2023-02-24 15:07 UTC (permalink / raw)
To: mcgrof
Cc: linux-modules, linux-kernel, Hitomi Hasegawa, Helge Deller,
linux-fbdev, dri-devel
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Helge Deller <deller@gmx.de>
Cc: linux-fbdev@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
---
drivers/video/fbdev/imsttfb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/video/fbdev/imsttfb.c b/drivers/video/fbdev/imsttfb.c
index bea45647184e..dbfaac0b14a8 100644
--- a/drivers/video/fbdev/imsttfb.c
+++ b/drivers/video/fbdev/imsttfb.c
@@ -1636,7 +1636,6 @@ static void __exit imsttfb_exit(void)
pci_unregister_driver(&imsttfb_pci_driver);
}
-MODULE_LICENSE("GPL");
module_init(imsttfb_init);
module_exit(imsttfb_exit);
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2023-02-24 15:09 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20230224150811.80316-1-nick.alcock@oracle.com>
2023-02-24 15:07 ` [PATCH 03/27] fbdev: remove MODULE_LICENSE in non-modules Nick Alcock
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).