* [PATCH v2] backlight: lm3630a: turn off both led strings when display is blank
@ 2023-05-10 8:52 Maximilian Weigand
2023-05-10 16:03 ` Sam Ravnborg
2023-05-18 10:15 ` Lee Jones
0 siblings, 2 replies; 3+ messages in thread
From: Maximilian Weigand @ 2023-05-10 8:52 UTC (permalink / raw)
To: Lee Jones, Daniel Thompson, Jingoo Han, Helge Deller,
Thierry Reding, Uwe Kleine-König, dri-devel, linux-fbdev,
linux-kernel, linux-pwm
Cc: Maximilian Weigand
From: Maximilian Weigand <mweigand@mweigand.net>
Use backlight_is_blank() to determine if the led strings should be turned
off in the update_status() functions of both strings.
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: Maximilian Weigand <mweigand@mweigand.net>
---
Changes in v2:
- fix description, replace display_is_black() with backlight_is_black()
- use backlight_get_brightness() instead of accessing the property
directly
drivers/video/backlight/lm3630a_bl.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c
index d8c42acecb5d..faf92c8d70c1 100644
--- a/drivers/video/backlight/lm3630a_bl.c
+++ b/drivers/video/backlight/lm3630a_bl.c
@@ -202,7 +202,9 @@ static int lm3630a_bank_a_update_status(struct backlight_device *bl)
usleep_range(1000, 2000);
/* minimum brightness is 0x04 */
ret = lm3630a_write(pchip, REG_BRT_A, bl->props.brightness);
- if (bl->props.brightness < 0x4)
+
+ if (backlight_is_blank(bl) || (backlight_get_brightness(bl) < 0x4))
+ /* turn the string off */
ret |= lm3630a_update(pchip, REG_CTRL, LM3630A_LEDA_ENABLE, 0);
else
ret |= lm3630a_update(pchip, REG_CTRL,
@@ -277,7 +279,9 @@ static int lm3630a_bank_b_update_status(struct backlight_device *bl)
usleep_range(1000, 2000);
/* minimum brightness is 0x04 */
ret = lm3630a_write(pchip, REG_BRT_B, bl->props.brightness);
- if (bl->props.brightness < 0x4)
+
+ if (backlight_is_blank(bl) || (backlight_get_brightness(bl) < 0x4))
+ /* turn the string off */
ret |= lm3630a_update(pchip, REG_CTRL, LM3630A_LEDB_ENABLE, 0);
else
ret |= lm3630a_update(pchip, REG_CTRL,
base-commit: ac9a78681b921877518763ba0e89202254349d1b
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] backlight: lm3630a: turn off both led strings when display is blank
2023-05-10 8:52 [PATCH v2] backlight: lm3630a: turn off both led strings when display is blank Maximilian Weigand
@ 2023-05-10 16:03 ` Sam Ravnborg
2023-05-18 10:15 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Sam Ravnborg @ 2023-05-10 16:03 UTC (permalink / raw)
To: Maximilian Weigand
Cc: Lee Jones, Daniel Thompson, Jingoo Han, Helge Deller,
Thierry Reding, Uwe Kleine-König, dri-devel, linux-fbdev,
linux-kernel, linux-pwm, Maximilian Weigand
On Wed, May 10, 2023 at 10:52:39AM +0200, Maximilian Weigand wrote:
> From: Maximilian Weigand <mweigand@mweigand.net>
>
> Use backlight_is_blank() to determine if the led strings should be turned
> off in the update_status() functions of both strings.
>
> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> Signed-off-by: Maximilian Weigand <mweigand@mweigand.net>
Looks good.
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] backlight: lm3630a: turn off both led strings when display is blank
2023-05-10 8:52 [PATCH v2] backlight: lm3630a: turn off both led strings when display is blank Maximilian Weigand
2023-05-10 16:03 ` Sam Ravnborg
@ 2023-05-18 10:15 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2023-05-18 10:15 UTC (permalink / raw)
To: Maximilian Weigand
Cc: Daniel Thompson, Jingoo Han, Helge Deller, Thierry Reding,
Uwe Kleine-König, dri-devel, linux-fbdev, linux-kernel,
linux-pwm, Maximilian Weigand
On Wed, 10 May 2023, Maximilian Weigand wrote:
> From: Maximilian Weigand <mweigand@mweigand.net>
>
> Use backlight_is_blank() to determine if the led strings should be turned
> off in the update_status() functions of both strings.
>
> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
I moved this tag to the correct place and ...
> Signed-off-by: Maximilian Weigand <mweigand@mweigand.net>
> ---
> Changes in v2:
> - fix description, replace display_is_black() with backlight_is_black()
> - use backlight_get_brightness() instead of accessing the property
> directly
>
> drivers/video/backlight/lm3630a_bl.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
Applied, thanks
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-18 10:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-10 8:52 [PATCH v2] backlight: lm3630a: turn off both led strings when display is blank Maximilian Weigand
2023-05-10 16:03 ` Sam Ravnborg
2023-05-18 10:15 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).