linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v13 09/11] backlight: pwm_bl: Use 64-bit division function
       [not found] <cover.1587523702.git.gurus@codeaurora.org>
@ 2020-04-22  2:57 ` Guru Das Srinagesh
  2020-05-26  7:00   ` Lee Jones
  0 siblings, 1 reply; 2+ messages in thread
From: Guru Das Srinagesh @ 2020-04-22  2:57 UTC (permalink / raw)
  To: linux-pwm
  Cc: Guru Das Srinagesh, Daniel Thompson, David Collins,
	Bartlomiej Zolnierkiewicz, Jingoo Han, linux-kernel, dri-devel,
	Thierry Reding, linux-fbdev, Uwe Kleine-König,
	Subbaraman Narayanamurthy, Lee Jones

Since the PWM framework is switching struct pwm_state.period's datatype
to u64, prepare for this transition by using div_u64 to handle a 64-bit
dividend instead of a straight division operation.

Cc: Lee Jones <lee.jones@linaro.org>
Cc: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Jingoo Han <jingoohan1@gmail.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: linux-pwm@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org

Signed-off-by: Guru Das Srinagesh <gurus@codeaurora.org>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
---
 drivers/video/backlight/pwm_bl.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
index 82b8d75..464baad 100644
--- a/drivers/video/backlight/pwm_bl.c
+++ b/drivers/video/backlight/pwm_bl.c
@@ -606,7 +606,8 @@ static int pwm_backlight_probe(struct platform_device *pdev)
 		pb->scale = data->max_brightness;
 	}
 
-	pb->lth_brightness = data->lth_brightness * (state.period / pb->scale);
+	pb->lth_brightness = data->lth_brightness * (div_u64(state.period,
+				pb->scale));
 
 	props.type = BACKLIGHT_RAW;
 	props.max_brightness = data->max_brightness;
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v13 09/11] backlight: pwm_bl: Use 64-bit division function
  2020-04-22  2:57 ` [PATCH v13 09/11] backlight: pwm_bl: Use 64-bit division function Guru Das Srinagesh
@ 2020-05-26  7:00   ` Lee Jones
  0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2020-05-26  7:00 UTC (permalink / raw)
  To: Guru Das Srinagesh
  Cc: linux-pwm, Daniel Thompson, David Collins,
	Bartlomiej Zolnierkiewicz, Jingoo Han, linux-kernel, dri-devel,
	Thierry Reding, linux-fbdev, Uwe Kleine-König,
	Subbaraman Narayanamurthy

On Tue, 21 Apr 2020, Guru Das Srinagesh wrote:

> Since the PWM framework is switching struct pwm_state.period's datatype
> to u64, prepare for this transition by using div_u64 to handle a 64-bit
> dividend instead of a straight division operation.
> 
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Daniel Thompson <daniel.thompson@linaro.org>
> Cc: Jingoo Han <jingoohan1@gmail.com>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Cc: linux-pwm@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-fbdev@vger.kernel.org
> 
> Signed-off-by: Guru Das Srinagesh <gurus@codeaurora.org>
> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>

Acked-by: Lee Jones <lee.jones@linaro.org>

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-05-26  7:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <cover.1587523702.git.gurus@codeaurora.org>
2020-04-22  2:57 ` [PATCH v13 09/11] backlight: pwm_bl: Use 64-bit division function Guru Das Srinagesh
2020-05-26  7:00   ` Lee Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).