From: Helge Deller <deller@gmx.de>
To: Shang XiaoJing <shangxiaojing@huawei.com>,
s.hauer@pengutronix.de, kernel@pengutronix.de,
shawnguo@kernel.org, festevam@gmail.com, linux-imx@nxp.com,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH -next] video: fbdev: imxfb: Remove redundant dev_err call
Date: Sun, 25 Sep 2022 13:01:46 +0200 [thread overview]
Message-ID: <670566ca-0817-3b5c-c571-b4f81ce50b08@gmx.de> (raw)
In-Reply-To: <20220923102007.19870-1-shangxiaojing@huawei.com>
On 9/23/22 12:20, Shang XiaoJing wrote:
> devm_ioremap_resource() prints error message in itself. Remove the
> dev_err call to avoid redundant error message.
>
> Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
applied.
Thanks,
Helge
> ---
> drivers/video/fbdev/imxfb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c
> index 94f3bc637fc8..51fde1b2a793 100644
> --- a/drivers/video/fbdev/imxfb.c
> +++ b/drivers/video/fbdev/imxfb.c
> @@ -972,7 +972,6 @@ static int imxfb_probe(struct platform_device *pdev)
>
> fbi->regs = devm_ioremap_resource(&pdev->dev, res);
> if (IS_ERR(fbi->regs)) {
> - dev_err(&pdev->dev, "Cannot map frame buffer registers\n");
> ret = PTR_ERR(fbi->regs);
> goto failed_ioremap;
> }
prev parent reply other threads:[~2022-09-25 11:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 10:20 [PATCH -next] video: fbdev: imxfb: Remove redundant dev_err call Shang XiaoJing
2022-09-25 11:01 ` Helge Deller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=670566ca-0817-3b5c-c571-b4f81ce50b08@gmx.de \
--to=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=shangxiaojing@huawei.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).