* [PATCH -next] video: fbdev: imxfb: Remove redundant dev_err call
@ 2022-09-23 10:20 Shang XiaoJing
2022-09-25 11:01 ` Helge Deller
0 siblings, 1 reply; 2+ messages in thread
From: Shang XiaoJing @ 2022-09-23 10:20 UTC (permalink / raw)
To: s.hauer, kernel, deller, shawnguo, festevam, linux-imx,
linux-fbdev, dri-devel
Cc: shangxiaojing
devm_ioremap_resource() prints error message in itself. Remove the
dev_err call to avoid redundant error message.
Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
---
drivers/video/fbdev/imxfb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c
index 94f3bc637fc8..51fde1b2a793 100644
--- a/drivers/video/fbdev/imxfb.c
+++ b/drivers/video/fbdev/imxfb.c
@@ -972,7 +972,6 @@ static int imxfb_probe(struct platform_device *pdev)
fbi->regs = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(fbi->regs)) {
- dev_err(&pdev->dev, "Cannot map frame buffer registers\n");
ret = PTR_ERR(fbi->regs);
goto failed_ioremap;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] video: fbdev: imxfb: Remove redundant dev_err call
2022-09-23 10:20 [PATCH -next] video: fbdev: imxfb: Remove redundant dev_err call Shang XiaoJing
@ 2022-09-25 11:01 ` Helge Deller
0 siblings, 0 replies; 2+ messages in thread
From: Helge Deller @ 2022-09-25 11:01 UTC (permalink / raw)
To: Shang XiaoJing, s.hauer, kernel, shawnguo, festevam, linux-imx,
linux-fbdev, dri-devel
On 9/23/22 12:20, Shang XiaoJing wrote:
> devm_ioremap_resource() prints error message in itself. Remove the
> dev_err call to avoid redundant error message.
>
> Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
applied.
Thanks,
Helge
> ---
> drivers/video/fbdev/imxfb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c
> index 94f3bc637fc8..51fde1b2a793 100644
> --- a/drivers/video/fbdev/imxfb.c
> +++ b/drivers/video/fbdev/imxfb.c
> @@ -972,7 +972,6 @@ static int imxfb_probe(struct platform_device *pdev)
>
> fbi->regs = devm_ioremap_resource(&pdev->dev, res);
> if (IS_ERR(fbi->regs)) {
> - dev_err(&pdev->dev, "Cannot map frame buffer registers\n");
> ret = PTR_ERR(fbi->regs);
> goto failed_ioremap;
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-25 11:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-23 10:20 [PATCH -next] video: fbdev: imxfb: Remove redundant dev_err call Shang XiaoJing
2022-09-25 11:01 ` Helge Deller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).