From: Helge Deller <deller@gmx.de>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] fbdev/clps711x-fb: Use devm_platform_get_and_ioremap_resource()
Date: Sat, 11 Mar 2023 12:57:30 +0100 [thread overview]
Message-ID: <6b7239e3-81f6-067e-1fd2-9dc62166d4da@gmx.de> (raw)
In-Reply-To: <20230308054950.15164-1-yang.lee@linux.alibaba.com>
On 3/8/23 06:49, Yang Li wrote:
> According to commit 890cc39a8799 ("drivers: provide
> devm_platform_get_and_ioremap_resource()"), convert
> platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
applied.
Thanks!
Helge
> ---
> drivers/video/fbdev/clps711x-fb.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/clps711x-fb.c b/drivers/video/fbdev/clps711x-fb.c
> index 45c75ff01eca..c8bfc608bd9c 100644
> --- a/drivers/video/fbdev/clps711x-fb.c
> +++ b/drivers/video/fbdev/clps711x-fb.c
> @@ -238,8 +238,7 @@ static int clps711x_fb_probe(struct platform_device *pdev)
> info->fix.mmio_start = res->start;
> info->fix.mmio_len = resource_size(res);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> - info->screen_base = devm_ioremap_resource(dev, res);
> + info->screen_base = devm_platform_get_and_ioremap_resource(pdev, 1, &res);
> if (IS_ERR(info->screen_base)) {
> ret = PTR_ERR(info->screen_base);
> goto out_fb_release;
prev parent reply other threads:[~2023-03-11 11:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 5:49 [PATCH -next] fbdev/clps711x-fb: Use devm_platform_get_and_ioremap_resource() Yang Li
2023-03-11 11:57 ` Helge Deller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b7239e3-81f6-067e-1fd2-9dc62166d4da@gmx.de \
--to=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).