From: Thomas Zimmermann <tzimmermann@suse.de> To: Xu Wang <vulab@iscas.ac.cn>, b.zolnierkie@samsung.com, jani.nikula@intel.com, daniel.vetter@ffwll.ch Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] au1100fb: Remove NULL pointer check before clk_enable/disable Date: Mon, 19 Oct 2020 07:21:00 +0000 [thread overview] Message-ID: <6cf83ff0-eeae-5646-b068-34dbacf2d961@suse.de> (raw) In-Reply-To: <20201014082137.23320-1-vulab@iscas.ac.cn> Hi On 14.10.20 10:21, Xu Wang wrote: > Because clk_enable, clk_disable, clk_prepare, and clk_unprepare already > checked NULL clock parameter, so the additional checks are unnecessary, > just remove them. > > Signed-off-by: Xu Wang <vulab@iscas.ac.cn> Sam convinced me to merge this patch as-is with out the additional cleanup of the driver. So Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> I'll merge it into drm-misc-next. I'd still like to encourage you to send a patch for the other clk_* calls in au1100fb. Best regard Thomas > --- > drivers/video/fbdev/au1100fb.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/video/fbdev/au1100fb.c b/drivers/video/fbdev/au1100fb.c > index 37a6512feda0..3659dfbb81c1 100644 > --- a/drivers/video/fbdev/au1100fb.c > +++ b/drivers/video/fbdev/au1100fb.c > @@ -560,8 +560,7 @@ int au1100fb_drv_suspend(struct platform_device *dev, pm_message_t state) > /* Blank the LCD */ > au1100fb_fb_blank(VESA_POWERDOWN, &fbdev->info); > > - if (fbdev->lcdclk) > - clk_disable(fbdev->lcdclk); > + clk_disable(fbdev->lcdclk); > > memcpy(&fbregs, fbdev->regs, sizeof(struct au1100fb_regs)); > > @@ -577,8 +576,7 @@ int au1100fb_drv_resume(struct platform_device *dev) > > memcpy(fbdev->regs, &fbregs, sizeof(struct au1100fb_regs)); > > - if (fbdev->lcdclk) > - clk_enable(fbdev->lcdclk); > + clk_enable(fbdev->lcdclk); > > /* Unblank the LCD */ > au1100fb_fb_blank(VESA_NO_BLANKING, &fbdev->info); > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Zimmermann <tzimmermann@suse.de> To: Xu Wang <vulab@iscas.ac.cn>, b.zolnierkie@samsung.com, jani.nikula@intel.com, daniel.vetter@ffwll.ch Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] au1100fb: Remove NULL pointer check before clk_enable/disable Date: Mon, 19 Oct 2020 09:21:00 +0200 [thread overview] Message-ID: <6cf83ff0-eeae-5646-b068-34dbacf2d961@suse.de> (raw) Message-ID: <20201019072100.9jHkQ8wEc6UJ5IXqAk3LJ0jh1QqywmA6n4TS--ad49I@z> (raw) In-Reply-To: <20201014082137.23320-1-vulab@iscas.ac.cn> Hi On 14.10.20 10:21, Xu Wang wrote: > Because clk_enable, clk_disable, clk_prepare, and clk_unprepare already > checked NULL clock parameter, so the additional checks are unnecessary, > just remove them. > > Signed-off-by: Xu Wang <vulab@iscas.ac.cn> Sam convinced me to merge this patch as-is with out the additional cleanup of the driver. So Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> I'll merge it into drm-misc-next. I'd still like to encourage you to send a patch for the other clk_* calls in au1100fb. Best regard Thomas > --- > drivers/video/fbdev/au1100fb.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/video/fbdev/au1100fb.c b/drivers/video/fbdev/au1100fb.c > index 37a6512feda0..3659dfbb81c1 100644 > --- a/drivers/video/fbdev/au1100fb.c > +++ b/drivers/video/fbdev/au1100fb.c > @@ -560,8 +560,7 @@ int au1100fb_drv_suspend(struct platform_device *dev, pm_message_t state) > /* Blank the LCD */ > au1100fb_fb_blank(VESA_POWERDOWN, &fbdev->info); > > - if (fbdev->lcdclk) > - clk_disable(fbdev->lcdclk); > + clk_disable(fbdev->lcdclk); > > memcpy(&fbregs, fbdev->regs, sizeof(struct au1100fb_regs)); > > @@ -577,8 +576,7 @@ int au1100fb_drv_resume(struct platform_device *dev) > > memcpy(fbdev->regs, &fbregs, sizeof(struct au1100fb_regs)); > > - if (fbdev->lcdclk) > - clk_enable(fbdev->lcdclk); > + clk_enable(fbdev->lcdclk); > > /* Unblank the LCD */ > au1100fb_fb_blank(VESA_NO_BLANKING, &fbdev->info); > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer
next prev parent reply other threads:[~2020-10-19 7:21 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-14 8:21 [PATCH] au1100fb: Remove NULL pointer check before clk_enable/disable Xu Wang 2020-10-15 8:05 ` Thomas Zimmermann 2020-10-19 7:21 ` Thomas Zimmermann [this message] 2020-10-19 7:21 ` Thomas Zimmermann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=6cf83ff0-eeae-5646-b068-34dbacf2d961@suse.de \ --to=tzimmermann@suse.de \ --cc=b.zolnierkie@samsung.com \ --cc=daniel.vetter@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=jani.nikula@intel.com \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=vulab@iscas.ac.cn \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).