From: Randy Dunlap <rdunlap@infradead.org>
To: Sam Ravnborg <sam@ravnborg.org>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
Lee Jones <lee.jones@linaro.org>
Cc: Alexander Klimov <grandmaster@al2klimov.de>,
Andrew Morton <akpm@linux-foundation.org>,
Andrzej Hajda <a.hajda@samsung.com>,
Arnd Bergmann <arnd@arndb.de>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Colin Ian King <colin.king@canonical.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Douglas Anderson <dianders@chromium.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Gustavo A R Silva <gustavoars@kernel.org>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
linux-arm-kernel@lists.infradead.org,
Michael Ellerman <mpe@ellerman.id.au>,
Mike Rapoport <rppt@kernel.org>, Peter Jones <pjones@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Qilong Zhang <zhangqilong3@huawei.com>,
Rich Felker <dalias@libc.org>,
Thierry Reding <thierry.reding@gmail.com>,
Thomas Winischhofer <thomas@winischhofer.net>,
Thomas Zimmermann <tzimmermann@suse.de>,
Tony Prisk <linux@prisktech.co.nz>,
Ferenc Bakonyi <fero@drama.obuda.kando.hu>,
linux-nvidia@lists.surfsouth.com
Subject: Re: [PATCH v3 01/13] video: fbdev: hgafb: Fix kernel-doc warnings
Date: Sun, 6 Dec 2020 11:34:18 -0800 [thread overview]
Message-ID: <c0c465e0-035a-956a-f8d6-18976bfb813b@infradead.org> (raw)
In-Reply-To: <20201206190247.1861316-2-sam@ravnborg.org>
On 12/6/20 11:02 AM, Sam Ravnborg wrote:
> Fix kernel-doc comments.
>
> v2:
> - Updated subject (Lee)
>
> v3:
> - Add space after ':' (Randy)
> - Fix name of function in comment
>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Ferenc Bakonyi <fero@drama.obuda.kando.hu>
> Cc: linux-nvidia@lists.surfsouth.com
> Cc: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/video/fbdev/hgafb.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/video/fbdev/hgafb.c b/drivers/video/fbdev/hgafb.c
> index a45fcff1461f..8bbac7182ad3 100644
> --- a/drivers/video/fbdev/hgafb.c
> +++ b/drivers/video/fbdev/hgafb.c
> @@ -357,8 +357,8 @@ static int hga_card_detect(void)
>
> /**
> * hgafb_open - open the framebuffer device
> - * @info:pointer to fb_info object containing info for current hga board
> - * @int:open by console system or userland.
> + * @info: pointer to fb_info object containing info for current hga board
> + * @init: open by console system or userland.
> */
>
> static int hgafb_open(struct fb_info *info, int init)
> @@ -370,9 +370,9 @@ static int hgafb_open(struct fb_info *info, int init)
> }
>
> /**
> - * hgafb_open - open the framebuffer device
> - * @info:pointer to fb_info object containing info for current hga board
> - * @int:open by console system or userland.
> + * hgafb_release - open the framebuffer device
> + * @info: pointer to fb_info object containing info for current hga board
> + * @init: open by console system or userland.
> */
>
> static int hgafb_release(struct fb_info *info, int init)
>
LGTM. Thanks.
Acked-by: Randy Dunlap <rdunlap@infradead.org>
--
~Randy
next prev parent reply other threads:[~2020-12-06 19:38 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-06 19:02 [PATCH v3 0/13] drivers/video: W=1 warning fixes Sam Ravnborg
2020-12-06 19:02 ` [PATCH v3 01/13] video: fbdev: hgafb: Fix kernel-doc warnings Sam Ravnborg
2020-12-06 19:34 ` Randy Dunlap [this message]
2020-12-06 19:02 ` [PATCH v3 02/13] video: fbdev: core: Fix kernel-doc warnings in fbmon + fb_notify Sam Ravnborg
2020-12-06 19:37 ` Randy Dunlap
2020-12-06 20:52 ` Sam Ravnborg
2020-12-06 21:27 ` Randy Dunlap
2020-12-07 8:16 ` Thomas Zimmermann
2020-12-07 16:43 ` Randy Dunlap
2020-12-07 17:12 ` Sam Ravnborg
2020-12-06 19:02 ` [PATCH v3 03/13] video: fbdev: omapfb: Fix set but not used warnings in hdmi*_core Sam Ravnborg
2020-12-07 8:17 ` Thomas Zimmermann
2020-12-06 19:02 ` [PATCH v3 04/13] video: fbdev: uvesafb: Fix set but not used warning Sam Ravnborg
2020-12-07 8:18 ` Thomas Zimmermann
2020-12-06 19:02 ` [PATCH v3 05/13] sh: Fix set but not used warnings with !CONFIG_MMU Sam Ravnborg
2020-12-06 21:19 ` kernel test robot
2020-12-06 21:48 ` Sam Ravnborg
2020-12-06 21:49 ` Sam Ravnborg
2020-12-07 8:19 ` Thomas Zimmermann
2020-12-06 19:02 ` [PATCH v3 06/13] video: fbdev: sparc drivers: fix kernel-doc warnings for blank_mode Sam Ravnborg
2020-12-07 8:21 ` Thomas Zimmermann
2020-12-06 19:02 ` [PATCH v3 07/13] video: fbdev: mmp: Fix kernel-doc warning for lcd_spi_write Sam Ravnborg
2020-12-07 13:48 ` Thomas Zimmermann
2020-12-06 19:02 ` [PATCH v3 08/13] video: fbdev: wmt_ge_rops: Fix function not declared warnings Sam Ravnborg
2020-12-07 13:49 ` Thomas Zimmermann
2020-12-06 19:02 ` [PATCH v3 09/13] video: fbdev: goldfishfb: Fix defined but not used warning Sam Ravnborg
2020-12-07 13:49 ` Thomas Zimmermann
2020-12-06 19:02 ` [PATCH v3 10/13] video: fbdev: gbefb: Fix set " Sam Ravnborg
2020-12-07 13:50 ` Thomas Zimmermann
2020-12-06 19:02 ` [PATCH v3 11/13] video: fbdev: efifb: Fix set but not used warning for screen_pitch Sam Ravnborg
2020-12-07 13:51 ` Thomas Zimmermann
2020-12-06 19:02 ` [PATCH v3 12/13] video: fbdev: controlfb: Fix set but not used warnings Sam Ravnborg
2020-12-07 13:52 ` Thomas Zimmermann
2020-12-06 19:02 ` [PATCH v3 13/13] video: fbdev: sis: Drop useless call to SiS_GetResInfo() Sam Ravnborg
2020-12-07 13:53 ` Thomas Zimmermann
2020-12-08 18:02 ` [PATCH v3 0/13] drivers/video: W=1 warning fixes Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0c465e0-035a-956a-f8d6-18976bfb813b@infradead.org \
--to=rdunlap@infradead.org \
--cc=a.hajda@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=b.zolnierkie@samsung.com \
--cc=colin.king@canonical.com \
--cc=dalias@libc.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fero@drama.obuda.kando.hu \
--cc=geert+renesas@glider.be \
--cc=grandmaster@al2klimov.de \
--cc=gustavoars@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-nvidia@lists.surfsouth.com \
--cc=linux@prisktech.co.nz \
--cc=mpe@ellerman.id.au \
--cc=peterz@infradead.org \
--cc=pjones@redhat.com \
--cc=rppt@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
--cc=thomas@winischhofer.net \
--cc=tzimmermann@suse.de \
--cc=zhangqilong3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).