linux-firmware.lore.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Amit K Bag <amit.k.bag@intel.com>
Cc: linux-firmware@kernel.org, linux-bluetooth@vger.kernel.org,
	ravishankar.srivatsa@intel.com, chethan.tumkur.narayan@intel.com,
	Sukumar Ghorai <sukumar.ghorai@intel.com>
Subject: Re: [PATCH] Bluetooth: print fw build version in power-on boot
Date: Thu, 12 Mar 2020 15:08:54 +0100	[thread overview]
Message-ID: <63E6C606-A941-4FA4-B21D-DCC564DB41F3@holtmann.org> (raw)
Message-ID: <20200312140854.0UMnwznczNpcxQTH5aGKLQoheLQQdc6frNdp3IuTCBw@z> (raw)
In-Reply-To: <20200312102142.26538-1-amit.k.bag@intel.com>

Hi Amit,

> To determine the build version of Bluetooth firmware to ensure reported
> issue related to a particular release. This is very helpful for every fw
> downloaded to BT controller and issue reported from field test.
> 
> Signed-off-by: Amit K Bag <amit.k.bag@intel.com>
> ---
> drivers/bluetooth/btusb.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index f5924f3e8b8d..d4328008a714 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -1930,7 +1930,12 @@ static int btusb_setup_intel(struct hci_dev *hdev)
> 	if (err)
> 		return err;
> 
> -	bt_dev_info(hdev, "Intel firmware patch completed and activated");
> +       /* Need build number for downloaded fw patches in every power-on boot */
> +       err = btintel_read_version(hdev, &ver);
> +       if (err)
> +               return err;
> +       BT_INFO("%s: Intel Bluetooth fw patch 0x%02x completed and activated",
> +               hdev->name, ver.fw_patch_num);

don’t re-introduce the usage of BT_INFO, we have bt_dev_info.

Regards

Marcel


  parent reply	other threads:[~2020-03-12 14:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-12 10:21 [PATCH] Bluetooth: print fw build version in power-on boot Amit K Bag
2020-03-12 10:21 ` Amit K Bag
2020-03-12 14:08 ` Marcel Holtmann [this message]
2020-03-12 14:08   ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63E6C606-A941-4FA4-B21D-DCC564DB41F3@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=amit.k.bag@intel.com \
    --cc=chethan.tumkur.narayan@intel.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-firmware@kernel.org \
    --cc=ravishankar.srivatsa@intel.com \
    --cc=sukumar.ghorai@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).