pull request: rtw89: 8852b: rollback firmware to v0.27.32.1 and introduce new file to new format

pull request: rtw89: 8852b: rollback firmware to v0.27.32.1 and introduce new file to new format

[Ping-Ke Shih]

Hi,

In discussion threads [1] [2], the new format of 8852b break user space.
To avoid this, introduce new filename rtw89/rtw8852b_fw-1.bin that old
drivers will not try to load it.

Rollback firmware version of rtw89/rtw8852b_fw.bin to the latest
version of original format (i.e. v0.27.32.1) supported by old driver.

The patches to support new filename in new driver are almost done,
and I will submit them soon. Thanks for the advice in mail and
bug threads.


[1] 
https://lore.kernel.org/linux-wireless/df1ce994-3368-a57e-7078-8bdcccf4a1fd@gmail.com/T/#m24cb43be31a762d0ea70bf07f27ae96c59f6931b
[2] https://bugzilla.kernel.org/show_bug.cgi?id=217207


Thank you
Ping-Ke

---
The following changes since commit c761dbe804f903cc2df81f251d367cca285eca06:

  Merge tag 'iwlwifi-fw-2023-03-13' of 
http://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/linux-firmware (2023-03-13 09:20:47 -0400)

are available in the Git repository at:

  https://github.com/pkshih/linux-firmware.git HEAD

for you to fetch changes up to 2c07f017ff42398e25b8552bc8e01c7c667b8592:

  rtw89: 8852b: update format-1 fw to v0.29.29.0 (2023-03-18 21:44:30 +0800)

----------------------------------------------------------------
Ping-Ke Shih (3):
      rtw89: 8852b: rollback firmware to v0.27.32.1
      rtw89: 8852b: add format-1 fw v0.29.26.0
      rtw89: 8852b: update format-1 fw to v0.29.29.0

 WHENCE                  |   1 +
 rtw89/rtw8852b_fw-1.bin | Bin 0 -> 1188488 bytes
 rtw89/rtw8852b_fw.bin   | Bin 1188488 -> 1035232 bytes
 3 files changed, 1 insertion(+)
 create mode 100644 rtw89/rtw8852b_fw-1.bin

Re: pull request: rtw89: 8852b: rollback firmware to v0.27.32.1 and introduce new file to new format

[Josh Boyer]

On Sat, Mar 18, 2023 at 9:59 AM Ping-Ke Shih <pkshih@realtek.com> wrote:
>
> Hi,
>
> In discussion threads [1] [2], the new format of 8852b break user space.
> To avoid this, introduce new filename rtw89/rtw8852b_fw-1.bin that old
> drivers will not try to load it.
>
> Rollback firmware version of rtw89/rtw8852b_fw.bin to the latest
> version of original format (i.e. v0.27.32.1) supported by old driver.
>
> The patches to support new filename in new driver are almost done,
> and I will submit them soon. Thanks for the advice in mail and
> bug threads.
>
>
> [1]
> https://lore.kernel.org/linux-wireless/df1ce994-3368-a57e-7078-8bdcccf4a1fd@gmail.com/T/#m24cb43be31a762d0ea70bf07f27ae96c59f6931b
> [2] https://bugzilla.kernel.org/show_bug.cgi?id=217207
>
>
> Thank you
> Ping-Ke
>
> ---
> The following changes since commit c761dbe804f903cc2df81f251d367cca285eca06:
>
>   Merge tag 'iwlwifi-fw-2023-03-13' of
> http://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/linux-firmware (2023-03-13 09:20:47 -0400)
>
> are available in the Git repository at:
>
>   https://github.com/pkshih/linux-firmware.git HEAD

Pulled and pushed out.

josh

>
> for you to fetch changes up to 2c07f017ff42398e25b8552bc8e01c7c667b8592:
>
>   rtw89: 8852b: update format-1 fw to v0.29.29.0 (2023-03-18 21:44:30 +0800)
>
> ----------------------------------------------------------------
> Ping-Ke Shih (3):
>       rtw89: 8852b: rollback firmware to v0.27.32.1
>       rtw89: 8852b: add format-1 fw v0.29.26.0
>       rtw89: 8852b: update format-1 fw to v0.29.29.0
>
>  WHENCE                  |   1 +
>  rtw89/rtw8852b_fw-1.bin | Bin 0 -> 1188488 bytes
>  rtw89/rtw8852b_fw.bin   | Bin 1188488 -> 1035232 bytes
>  3 files changed, 1 insertion(+)
>  create mode 100644 rtw89/rtw8852b_fw-1.bin
>

Re: pull request: rtw89: 8852b: rollback firmware to v0.27.32.1 and introduce new file to new format

[Linux regression tracking (Thorsten Leemhuis)]

On 20.03.23 12:43, Josh Boyer wrote:
> On Sat, Mar 18, 2023 at 9:59 AM Ping-Ke Shih <pkshih@realtek.com> wrote:
>>
>> In discussion threads [1] [2], the new format of 8852b break user space.
>> To avoid this, introduce new filename rtw89/rtw8852b_fw-1.bin that old
>> drivers will not try to load it.
>>
>> Rollback firmware version of rtw89/rtw8852b_fw.bin to the latest
>> version of original format (i.e. v0.27.32.1) supported by old driver.
>>
>> The patches to support new filename in new driver are almost done,
>> and I will submit them soon. Thanks for the advice in mail and
>> bug threads.
>> [...]
> Pulled and pushed out.

Thx to both of you for submitting the revert and applying it.

Josh, do you plan to do another release soon? I fear that otherwise more
distros and users will run into this regression.

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.

Re: pull request: rtw89: 8852b: rollback firmware to v0.27.32.1 and introduce new file to new format

[Josh Boyer]

On Thu, Mar 23, 2023 at 6:25 AM Linux regression tracking (Thorsten
Leemhuis) <regressions@leemhuis.info> wrote:
>
> On 20.03.23 12:43, Josh Boyer wrote:
> > On Sat, Mar 18, 2023 at 9:59 AM Ping-Ke Shih <pkshih@realtek.com> wrote:
> >>
> >> In discussion threads [1] [2], the new format of 8852b break user space.
> >> To avoid this, introduce new filename rtw89/rtw8852b_fw-1.bin that old
> >> drivers will not try to load it.
> >>
> >> Rollback firmware version of rtw89/rtw8852b_fw.bin to the latest
> >> version of original format (i.e. v0.27.32.1) supported by old driver.
> >>
> >> The patches to support new filename in new driver are almost done,
> >> and I will submit them soon. Thanks for the advice in mail and
> >> bug threads.
> >> [...]
> > Pulled and pushed out.
>
> Thx to both of you for submitting the revert and applying it.
>
> Josh, do you plan to do another release soon? I fear that otherwise more
> distros and users will run into this regression.

I've done another release.  Apologies, I was on PTO.

josh