From: Josh Boyer <jwboyer@kernel.org>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: linux-firmware@kernel.org, Adam Sampson <ats@offog.org>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH RESEND v2 05/16] WHENCE: comment out duplicate MediaTek firmware
Date: Tue, 7 Mar 2023 13:08:00 -0500 [thread overview]
Message-ID: <CA+5PVA4wGZxYjM7nVD7J4opM3fXwoK6oGW673=FBOzgeDMLwcw@mail.gmail.com> (raw)
In-Reply-To: <CACvgo51yMRXgbUfK6wNfDvXEuBXH=JPZhm9=oFkhFHipVqz5oQ@mail.gmail.com>
On Tue, Mar 7, 2023 at 12:19 PM Emil Velikov <emil.l.velikov@gmail.com> wrote:
>
> On Tue, 7 Mar 2023 at 15:02, Josh Boyer <jwboyer@kernel.org> wrote:
> >
> > On Wed, Mar 1, 2023 at 1:56 PM Emil Velikov via B4 Relay
> > <devnull+emil.l.velikov.gmail.com@kernel.org> wrote:
> > >
> > > From: Emil Velikov <emil.l.velikov@gmail.com>
> > >
> > > As mentioned in the inline comment - file is already listed further
> > > down. To prevent check_whence.py errors, comment it out.
> >
> > Why did you comment this one out instead of remove it as duplicate
> > like the previous patch?
> >
>
> In the previous patch, we had either a) duplicated within the same
> section or b) section that is no longer applicable. Aka the r8723au
> driver referenced does not existing in kernel.org
> Here we have two drivers which use different firmware sets, which
> partially overlap.
Ok. That makes sense.
> Dropping one or the other would be misleading, but I don't have a
> strong opinion. Let me know what you prefer and I'll respin the patch.
I think this is a case where both should be listed. If you comment
one out and the other entry gets removed, perhaps because none of the
upstream kernels support the driver any longer, then the installation
will not copy the file to disk and the driver that is still in-tree
will now have missing firmware. I don't want to leave people without
a functioning system just because we wanted to avoid some text in
WHENCE.
josh
next prev parent reply other threads:[~2023-03-07 18:08 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 18:56 [PATCH RESEND v2 00/16] Misc fixes, sanity checks and xz/zstd compression Emil Velikov via B4 Relay
2023-03-01 18:56 ` [PATCH RESEND v2 01/16] WHENCE: remove trailing white space Emil Velikov via B4 Relay
2023-03-07 14:53 ` Josh Boyer
2023-03-01 18:56 ` [PATCH RESEND v2 02/16] WHENCE: remove unnecessary filename quotation Emil Velikov via B4 Relay
2023-03-07 14:56 ` Josh Boyer
2023-03-07 17:53 ` Emil Velikov
2023-03-07 18:01 ` Josh Boyer
2023-03-01 18:56 ` [PATCH RESEND v2 03/16] check_whence, WHENCE, copy-firmware: escape filenames with spaces Emil Velikov via B4 Relay
2023-03-07 14:58 ` Josh Boyer
2023-03-07 17:30 ` Emil Velikov
2023-03-07 18:00 ` Josh Boyer
2023-03-07 20:48 ` Emil Velikov
2023-03-01 18:56 ` [PATCH RESEND v2 04/16] WHENCE: remove duplicate File entries Emil Velikov via B4 Relay
2023-03-07 15:01 ` Josh Boyer
2023-03-01 18:56 ` [PATCH RESEND v2 05/16] WHENCE: comment out duplicate MediaTek firmware Emil Velikov via B4 Relay
2023-03-07 15:02 ` Josh Boyer
2023-03-07 17:19 ` Emil Velikov
2023-03-07 18:08 ` Josh Boyer [this message]
2023-03-07 20:57 ` Emil Velikov
2023-03-10 12:42 ` Josh Boyer
2023-03-01 18:56 ` [PATCH RESEND v2 06/16] check_whence: error on duplicate file entries Emil Velikov via B4 Relay
2023-03-07 18:12 ` Josh Boyer
2023-03-01 18:56 ` [PATCH RESEND v2 07/16] check_whence: error on directory listed as File Emil Velikov via B4 Relay
2023-03-13 20:24 ` Emil Velikov
2023-03-21 10:31 ` Emil Velikov
2023-03-29 14:47 ` Emil Velikov
2023-03-01 18:56 ` [PATCH RESEND v2 08/16] copy-firmware: remove non-applicable file presence test Emil Velikov via B4 Relay
2023-05-08 12:39 ` Josh Boyer
2023-03-01 18:56 ` [PATCH RESEND v2 09/16] check_whence: error if File: is actually a link Emil Velikov via B4 Relay
2023-05-08 12:41 ` Josh Boyer
2023-03-01 18:56 ` [PATCH RESEND v2 10/16] check_whence: error if symlinks are in-tree Emil Velikov via B4 Relay
2023-05-08 12:45 ` Josh Boyer
2023-03-01 18:56 ` [PATCH RESEND v2 11/16] copy-firmware: remove unreachable symlink workarounds Emil Velikov via B4 Relay
2023-03-01 18:56 ` [PATCH RESEND v2 12/16] copy-firmware: quote deskdir to prevent word splitting Emil Velikov via B4 Relay
2023-05-08 12:47 ` Josh Boyer
2023-03-01 18:56 ` [PATCH RESEND v2 13/16] copy-firmware: tweak sed invocation Emil Velikov via B4 Relay
2023-05-08 12:48 ` Josh Boyer
2023-03-01 18:56 ` [PATCH RESEND v2 14/16] copy-firmware: quote the output of dirname Emil Velikov via B4 Relay
2023-03-01 18:56 ` [PATCH RESEND v2 15/16] copy-firmware: silence the last shellcheck warnings Emil Velikov via B4 Relay
2023-03-01 18:56 ` [PATCH RESEND v2 16/16] Makefile, copy-firmware: support xz/zstd compressed firmware Emil Velikov via B4 Relay
2023-03-06 14:23 ` Emil Velikov
2023-05-08 12:51 ` [PATCH RESEND v2 00/16] Misc fixes, sanity checks and xz/zstd compression Josh Boyer
2023-05-20 11:05 ` Emil Velikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+5PVA4wGZxYjM7nVD7J4opM3fXwoK6oGW673=FBOzgeDMLwcw@mail.gmail.com' \
--to=jwboyer@kernel.org \
--cc=ats@offog.org \
--cc=dwmw2@infradead.org \
--cc=emil.l.velikov@gmail.com \
--cc=linux-firmware@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).