Re: [PATCH RESEND v2 00/16] Misc fixes, sanity checks and xz/zstd compression

[Josh Boyer <jwboyer@kernel.org>]

I applied a few more of the patches, but generally speaking some of
the changes conflate check_whence.py and copy-firmware.sh.  I think
they should remain independent scripts and not make assumptions that
one is doing something on behalf of the other.

josh

On Wed, Mar 1, 2023 at 1:56 PM Emil Velikov via B4 Relay
<devnull+emil.l.velikov.gmail.com@kernel.org> wrote:
>
> Hey everyone,
>
> Here's an updated series which fixes some outstanding issues, enhances
> the check_whence checks and adds xz/zstd firmware support.
>
> v2:
>  - Commend out duplicated MediaTek firmware
>  - Tweak list_links_list() after Adam's approach
>  - Skip compression of amd ucode
>
> Link to v1: https://lore.kernel.org/linux-firmware/CACvgo50RhmRKnUoos2wGWOP-Pb8oGo1BMPunfTtBQO0eX1D2Dg@mail.gmail.com/T/
>
> Josh, others, kindly let me know if you'd prefer a PR or if there is
> anything I can do to move this forward. Be that as a whole, or chunks of
> it.
>
> Thanks
> Emil
>
> Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
> ---
> Emil Velikov (16):
>       WHENCE: remove trailing white space
>       WHENCE: remove unnecessary filename quotation
>       check_whence, WHENCE, copy-firmware: escape filenames with spaces
>       WHENCE: remove duplicate File entries
>       WHENCE: comment out duplicate MediaTek firmware
>       check_whence: error on duplicate file entries
>       check_whence: error on directory listed as File
>       copy-firmware: remove non-applicable file presence test
>       check_whence: error if File: is actually a link
>       check_whence: error if symlinks are in-tree
>       copy-firmware: remove unreachable symlink workarounds
>       copy-firmware: quote deskdir to prevent word splitting
>       copy-firmware: tweak sed invocation
>       copy-firmware: quote the output of dirname
>       copy-firmware: silence the last shellcheck warnings
>       Makefile, copy-firmware: support xz/zstd compressed firmware
>
>  Makefile         |   8 +++++
>  WHENCE           | 107 ++++++++++++++++++++++++-------------------------------
>  check_whence.py  |  53 +++++++++++++++++++++++----
>  copy-firmware.sh |  76 ++++++++++++++++++++-------------------
>  4 files changed, 141 insertions(+), 103 deletions(-)
> ---
> base-commit: 60971a6485ee604c47cc905ff77c583ae001f9df
> change-id: 20230301-fixes-and-compression-7247407cab21
>
> Best regards,
> --
> Emil Velikov <emil.l.velikov@gmail.com>
>