Re: Bug#982579: Solution for loading firmware

Re: Bug#982579: Solution for loading firmware

[maximilian attems]

[-- Attachment #1: Type: text/plain, Size: 1095 bytes --]

Dear Bernhard,

Thank you very much for your clear and helpful report!

> I tested the following:
> 
> 1. Copy file brcmfmac43430-sdio.AP6212.txt from upstream to lib/firmware/brcm

so indeed it is a bug that we don't ship this one from upstream,
will fix this in next Debian upload.

> 2. Create symbolic link named brcmfmac43430-sdio.sinovoip.bpi-m3.txt to the AP6212-file
> 3. Create symbolic link named brcmfmac43430-sdio.sinovoip.bpi-m2-ultra.txt to the AP6212-file

this should be reported upstream, so that everyone takes advantage of
it, hence adding linux-firmware mailinglist on Cc, happy to cook up
a patch next 24hs.
 
> After that, the wlan0 interface is available and scanning of the WLAN-ESSIDs works.

great!

 
> Please either do it like described above or add the files directly instead of the symbolic links.

The symbolic links are better than duplicated files, but there seem to
be on the Debian side an opened can of trouble on them, see #982757
(I'll post there soonish)
 
Thank you for the kind words, the test and your report!

-- 
maks

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: Bug#982579: Solution for loading firmware

[maximilian attems]

please find patch to add banana ultra support below

From b549a10838edc4f97d4a3b49b572fc613c7c703d Mon Sep 17 00:00:00 2001
From: maximilian attems <maks@stro.at>
Date: Tue, 16 Feb 2021 19:35:27 +0100
Subject: [PATCH] Add symlink for BananaPi M2 to brcmfmac43430-sdio config

Fixes ( Debian bug #982579 [1]):
 [   10.514530] brcmfmac mmc2:0001:1: firmware: direct-loading firmware brcm/brcmfmac43430-sdio.bin
 [   10.514732] brcmfmac mmc2:0001:1: firmware: failed to load brcm/brcmfmac43430-sdio.sinovoip,bpi-m2-ultra.txt ( -2)

Refs:
[1] https://bugs.debian.org/982579

Reported-by: Bernhard <bewoern1@gmail.com>
Signed-off-by: maximilian attems <maks@stro.at>
---
 WHENCE | 1 +
 1 file changed, 1 insertion(+)

diff --git a/WHENCE b/WHENCE
index aa96404..11c0970 100644
--- a/WHENCE
+++ b/WHENCE
@@ -2716,6 +2716,7 @@ File: "brcm/brcmfmac43430a0-sdio.ONDA-V80 PLUS.txt"
 File: "brcm/brcmfmac43430-sdio.AP6212.txt"
 Link: brcm/brcmfmac43430-sdio.sinovoip,bpi-m2-plus.txt -> brcmfmac43430-sdio.AP6212.txt
 Link: brcm/brcmfmac43430-sdio.sinovoip,bpi-m2-zero.txt -> brcmfmac43430-sdio.AP6212.txt
+Link: brcm/brcmfmac43430-sdio.sinovoip,bpi-m2-ultra.txt -> brcmfmac43430-sdio.AP6212.txt
 File: "brcm/brcmfmac43430-sdio.Hampoo-D2D3_Vi8A1.txt"
 File: "brcm/brcmfmac43430-sdio.MUR1DX.txt"
 File: "brcm/brcmfmac43430-sdio.raspberrypi,3-model-b.txt"
-- 
2.30.0

Re: Bug#982579: Solution for loading firmware

[maximilian attems]

[-- Attachment #1: Type: text/plain, Size: 849 bytes --]

> > 1. Copy file brcmfmac43430-sdio.AP6212.txt from upstream to lib/firmware/brcm
> 
> so indeed it is a bug that we don't ship this one from upstream,
> will fix this in next Debian upload.

this needs to go in the debian git, will do soonish. (:
 
> > 2. Create symbolic link named brcmfmac43430-sdio.sinovoip.bpi-m3.txt to the AP6212-file

I am confused by this, as you did *not* submit an error log that showed
a request for this file, is this to add support to another device,
please be specific.

> > 3. Create symbolic link named brcmfmac43430-sdio.sinovoip.bpi-m2-ultra.txt to the AP6212-file
> this should be reported upstream, so that everyone takes advantage of
> it, hence adding linux-firmware mailinglist on Cc, happy to cook up
> a patch next 24hs.

sent, to add that symlink upstream.


thank you!

-- 
maks

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: Bug#982579: Solution for loading firmware

[maximilian attems]

please also add BananaPi M3 support.


From 216a0bda280e7b361c335f545156e86a059d9551 Mon Sep 17 00:00:00 2001
From: maximilian attems <maks@stro.at>
Date: Mon, 22 Feb 2021 22:18:36 +0100
Subject: [PATCH 2/2] WHENCE: add missing symlink for BananaPi M3

Fixes (Debian bug #982579):
> [   11.957171] brcmfmac mmc2:0001:1: firmware: failed to load
brcm/brcmfmac43430-sdio.sinovoip,bpi-m3.txt (-2)
> [   11.967106] firmware_class: See https://wiki.debian.org/Firmware for
information about missing firmware
> [   11.977035] brcmfmac mmc2:0001:1: firmware: failed to load
brcm/brcmfmac43430-sdio.txt (-2)
> [   12.994756] brcmfmac: brcmf_sdio_htclk: HT Avail timeout (1000000): clkctl
0x50

Reported-by: Bernhard <bewoern1@gmail.com>
Signed-off-by: maximilian attems <maks@stro.at>
---
 WHENCE | 1 +
 1 file changed, 1 insertion(+)

diff --git a/WHENCE b/WHENCE
index 11c0970..b569990 100644
--- a/WHENCE
+++ b/WHENCE
@@ -2717,6 +2717,7 @@ File: "brcm/brcmfmac43430-sdio.AP6212.txt"
 Link: brcm/brcmfmac43430-sdio.sinovoip,bpi-m2-plus.txt -> brcmfmac43430-sdio.AP6212.txt
 Link: brcm/brcmfmac43430-sdio.sinovoip,bpi-m2-zero.txt -> brcmfmac43430-sdio.AP6212.txt
 Link: brcm/brcmfmac43430-sdio.sinovoip,bpi-m2-ultra.txt -> brcmfmac43430-sdio.AP6212.txt
+Link: brcm/brcmfmac43430-sdio.sinovoip,bpi-m3.txt -> brcmfmac43430-sdio.AP6212.txt
 File: "brcm/brcmfmac43430-sdio.Hampoo-D2D3_Vi8A1.txt"
 File: "brcm/brcmfmac43430-sdio.MUR1DX.txt"
 File: "brcm/brcmfmac43430-sdio.raspberrypi,3-model-b.txt"
-- 
2.30.0

Re: Bug#982579: Solution for loading firmware

[Josh Boyer]

Both patches applied and pushed out.

In the future, could you please send the patches either as direct
emails or as attachments or as pull requests?  When you embed them in
the body of the email I have to manually adjust them to get the commit
log properly included.

josh

On Mon, Feb 22, 2021 at 4:24 PM maximilian attems <maks@stro.at> wrote:
>
> please also add BananaPi M3 support.
>
>
> From 216a0bda280e7b361c335f545156e86a059d9551 Mon Sep 17 00:00:00 2001
> From: maximilian attems <maks@stro.at>
> Date: Mon, 22 Feb 2021 22:18:36 +0100
> Subject: [PATCH 2/2] WHENCE: add missing symlink for BananaPi M3
>
> Fixes (Debian bug #982579):
> > [   11.957171] brcmfmac mmc2:0001:1: firmware: failed to load
> brcm/brcmfmac43430-sdio.sinovoip,bpi-m3.txt (-2)
> > [   11.967106] firmware_class: See https://wiki.debian.org/Firmware for
> information about missing firmware
> > [   11.977035] brcmfmac mmc2:0001:1: firmware: failed to load
> brcm/brcmfmac43430-sdio.txt (-2)
> > [   12.994756] brcmfmac: brcmf_sdio_htclk: HT Avail timeout (1000000): clkctl
> 0x50
>
> Reported-by: Bernhard <bewoern1@gmail.com>
> Signed-off-by: maximilian attems <maks@stro.at>
> ---
>  WHENCE | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/WHENCE b/WHENCE
> index 11c0970..b569990 100644
> --- a/WHENCE
> +++ b/WHENCE
> @@ -2717,6 +2717,7 @@ File: "brcm/brcmfmac43430-sdio.AP6212.txt"
>  Link: brcm/brcmfmac43430-sdio.sinovoip,bpi-m2-plus.txt -> brcmfmac43430-sdio.AP6212.txt
>  Link: brcm/brcmfmac43430-sdio.sinovoip,bpi-m2-zero.txt -> brcmfmac43430-sdio.AP6212.txt
>  Link: brcm/brcmfmac43430-sdio.sinovoip,bpi-m2-ultra.txt -> brcmfmac43430-sdio.AP6212.txt
> +Link: brcm/brcmfmac43430-sdio.sinovoip,bpi-m3.txt -> brcmfmac43430-sdio.AP6212.txt
>  File: "brcm/brcmfmac43430-sdio.Hampoo-D2D3_Vi8A1.txt"
>  File: "brcm/brcmfmac43430-sdio.MUR1DX.txt"
>  File: "brcm/brcmfmac43430-sdio.raspberrypi,3-model-b.txt"
> --
> 2.30.0
>

Re: Bug#982579: Solution for loading firmware

[maximilian attems]

> Both patches applied and pushed out.

great thank you.
 
> In the future, could you please send the patches either as direct
> emails or as attachments or as pull requests?  When you embed them in
> the body of the email I have to manually adjust them to get the commit
> log properly included.

sure, will do as pull request.