pull request: add back missing symlink to Qualcomm firmware file

pull request: add back missing symlink to Qualcomm firmware file

[Denys Fedoryshchenko]

Add missing symlink required for Qualcomm SC7180.
As stated in
https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/commit/qcom/venus-5.4?id=ad9fdba01fd2c909ea7962844211e25aa276e705
likely by mistake file got deleted, instead of replaced by symlink.

It results SC7180 failing to load firmware with following message:

1679 20:43:46.474154  <4>[   18.381820] qcom-venus aa00000.video-codec:
Direct firmware load for qcom/venus-5.4/venus.mdt failed with error -2

After fixing it device booting without error.


The following changes since commit
7e4f0eda76d58024f78ac68d4ffd6f87d63a3a29:

  Merge https://github.com/pkshih/linux-firmware (2023-01-17 08:00:15 -
0500)

are available in the Git repository at:

  https://github.com/nuclearcat/linux-firmware 

for you to fetch changes up to
a02f1168becbaacbae82a7002ff489c137f9b8b4:

  qcom: Fix symlink from venus-5.4/venus.mdt to venus.mbn (2023-01-20
14:18:17 +0200)

----------------------------------------------------------------
Denys Fedoryshchenko (1):
      qcom: Fix symlink from venus-5.4/venus.mdt to venus.mbn

 qcom/venus-5.4/venus.mdt | 1 +
 1 file changed, 1 insertion(+)
 create mode 120000 qcom/venus-5.4/venus.mdt


Thank you!

Re: pull request: add back missing symlink to Qualcomm firmware file

[Nathan Hebert]

Hi Denys,

On Fri, Jan 20, 2023 at 10:23 PM Denys Fedoryshchenko
<denys.f@collabora.com> wrote:
>
> Add missing symlink required for Qualcomm SC7180.
> As stated in
> https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/commit/qcom/venus-5.4?id=ad9fdba01fd2c909ea7962844211e25aa276e705
> likely by mistake file got deleted, instead of replaced by symlink.
>
> It results SC7180 failing to load firmware with following message:
>
> 1679 20:43:46.474154  <4>[   18.381820] qcom-venus aa00000.video-codec:
> Direct firmware load for qcom/venus-5.4/venus.mdt failed with error -2
>
> After fixing it device booting without error.
>
>
> The following changes since commit
> 7e4f0eda76d58024f78ac68d4ffd6f87d63a3a29:
>
>   Merge https://github.com/pkshih/linux-firmware (2023-01-17 08:00:15 -
> 0500)
>
> are available in the Git repository at:
>
>   https://github.com/nuclearcat/linux-firmware
>
> for you to fetch changes up to
> a02f1168becbaacbae82a7002ff489c137f9b8b4:
>
>   qcom: Fix symlink from venus-5.4/venus.mdt to venus.mbn (2023-01-20
> 14:18:17 +0200)
>
> ----------------------------------------------------------------
> Denys Fedoryshchenko (1):
>       qcom: Fix symlink from venus-5.4/venus.mdt to venus.mbn
>
>  qcom/venus-5.4/venus.mdt | 1 +
>  1 file changed, 1 insertion(+)
>  create mode 120000 qcom/venus-5.4/venus.mdt
It is my understanding that the link from qcom/venus-5.4/venus.mdt to
venus.mbn should be handled by the WHENCE file. There is a line [0]
that describes the link. A reviewer discouraged me from creating the
link in the file tree.
>
>
> Thank you!
>

Best regards,
Nathan Hebert

[0]: https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/WHENCE?id=bb2d42dceff755623d6d59a32a743ccf87cbb6b9#n5730

Re: pull request: add back missing symlink to Qualcomm firmware file

[Denys Fedoryshchenko]

On Mon, 2023-01-23 at 10:06 -0800, Nathan Hebert wrote:
> Hi Denys,
> 
> On Fri, Jan 20, 2023 at 10:23 PM Denys Fedoryshchenko
> <denys.f@collabora.com> wrote:
> > 
> > Add missing symlink required for Qualcomm SC7180.
> > As stated in
> > https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/commit/qcom/venus-5.4?id=ad9fdba01fd2c909ea7962844211e25aa276e705
> > likely by mistake file got deleted, instead of replaced by symlink.
> > 
> > It results SC7180 failing to load firmware with following message:
> > 
> > 1679 20:43:46.474154  <4>[   18.381820] qcom-venus aa00000.video-
> > codec:
> > Direct firmware load for qcom/venus-5.4/venus.mdt failed with error
> > -2
> > 
> > After fixing it device booting without error.
> > 
> > 
> > The following changes since commit
> > 7e4f0eda76d58024f78ac68d4ffd6f87d63a3a29:
> > 
> >   Merge https://github.com/pkshih/linux-firmware (2023-01-17
> > 08:00:15 -
> > 0500)
> > 
> > are available in the Git repository at:
> > 
> >   https://github.com/nuclearcat/linux-firmware
> > 
> > for you to fetch changes up to
> > a02f1168becbaacbae82a7002ff489c137f9b8b4:
> > 
> >   qcom: Fix symlink from venus-5.4/venus.mdt to venus.mbn (2023-01-
> > 20
> > 14:18:17 +0200)
> > 
> > ----------------------------------------------------------------
> > Denys Fedoryshchenko (1):
> >       qcom: Fix symlink from venus-5.4/venus.mdt to venus.mbn
> > 
> >  qcom/venus-5.4/venus.mdt | 1 +
> >  1 file changed, 1 insertion(+)
> >  create mode 120000 qcom/venus-5.4/venus.mdt
> It is my understanding that the link from qcom/venus-5.4/venus.mdt to
> venus.mbn should be handled by the WHENCE file. There is a line [0]
> that describes the link. A reviewer discouraged me from creating the
> link in the file tree.
Thank you very much for the information! 
This is somewhat surprising, i guess we will adapt our CI to use
copy-firmware.sh now.

> > 
> > 
> > Thank you!
> > 
> 
> Best regards,
> Nathan Hebert
> 
> [0]: 
> https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/WHENCE?id=bb2d42dceff755623d6d59a32a743ccf87cbb6b9#n5730