* [PATCH v3] dt-bindings: fpga: xilinx-pr-decoupler: convert bindings to json-schema
@ 2023-02-24 11:18 Nava kishore Manne
2023-02-24 11:22 ` Krzysztof Kozlowski
2023-03-07 22:40 ` Rob Herring
0 siblings, 2 replies; 3+ messages in thread
From: Nava kishore Manne @ 2023-02-24 11:18 UTC (permalink / raw)
To: mdf, hao.wu, yilun.xu, trix, robh+dt, krzysztof.kozlowski+dt,
michal.simek, nava.kishore.manne, linux-fpga, devicetree,
linux-arm-kernel, linux-kernel
Convert xilinx-pr-decoupler bindings to DT schema format using json-schema
Signed-off-by: Nava kishore Manne <nava.kishore.manne@amd.com>
---
Changes for v3:
- Removed 'bridge-enable' property and addressed some minor
comments as suggested by Krzysztof.
Changes for v2:
- Updated the description and addressed some minor comments
as suggested by Krzysztof.
.../bindings/fpga/xilinx-pr-decoupler.txt | 54 ----------------
.../bindings/fpga/xlnx,pr-decoupler.yaml | 64 +++++++++++++++++++
2 files changed, 64 insertions(+), 54 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt
create mode 100644 Documentation/devicetree/bindings/fpga/xlnx,pr-decoupler.yaml
diff --git a/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt b/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt
deleted file mode 100644
index 0acdfa6d62a4..000000000000
--- a/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt
+++ /dev/null
@@ -1,54 +0,0 @@
-Xilinx LogiCORE Partial Reconfig Decoupler Softcore
-
-The Xilinx LogiCORE Partial Reconfig Decoupler manages one or more
-decouplers / fpga bridges.
-The controller can decouple/disable the bridges which prevents signal
-changes from passing through the bridge. The controller can also
-couple / enable the bridges which allows traffic to pass through the
-bridge normally.
-
-Xilinx LogiCORE Dynamic Function eXchange(DFX) AXI shutdown manager
-Softcore is compatible with the Xilinx LogiCORE pr-decoupler.
-
-The Dynamic Function eXchange AXI shutdown manager prevents AXI traffic
-from passing through the bridge. The controller safely handles AXI4MM
-and AXI4-Lite interfaces on a Reconfigurable Partition when it is
-undergoing dynamic reconfiguration, preventing the system deadlock
-that can occur if AXI transactions are interrupted by DFX
-
-The Driver supports only MMIO handling. A PR region can have multiple
-PR Decouplers which can be handled independently or chained via decouple/
-decouple_status signals.
-
-Required properties:
-- compatible : Should contain "xlnx,pr-decoupler-1.00" followed by
- "xlnx,pr-decoupler" or
- "xlnx,dfx-axi-shutdown-manager-1.00" followed by
- "xlnx,dfx-axi-shutdown-manager"
-- regs : base address and size for decoupler module
-- clocks : input clock to IP
-- clock-names : should contain "aclk"
-
-See Documentation/devicetree/bindings/fpga/fpga-region.txt and
-Documentation/devicetree/bindings/fpga/fpga-bridge.txt for generic bindings.
-
-Example:
-Partial Reconfig Decoupler:
- fpga-bridge@100000450 {
- compatible = "xlnx,pr-decoupler-1.00",
- "xlnx-pr-decoupler";
- regs = <0x10000045 0x10>;
- clocks = <&clkc 15>;
- clock-names = "aclk";
- bridge-enable = <0>;
- };
-
-Dynamic Function eXchange AXI shutdown manager:
- fpga-bridge@100000450 {
- compatible = "xlnx,dfx-axi-shutdown-manager-1.00",
- "xlnx,dfx-axi-shutdown-manager";
- regs = <0x10000045 0x10>;
- clocks = <&clkc 15>;
- clock-names = "aclk";
- bridge-enable = <0>;
- };
diff --git a/Documentation/devicetree/bindings/fpga/xlnx,pr-decoupler.yaml b/Documentation/devicetree/bindings/fpga/xlnx,pr-decoupler.yaml
new file mode 100644
index 000000000000..a7d4b8e59e19
--- /dev/null
+++ b/Documentation/devicetree/bindings/fpga/xlnx,pr-decoupler.yaml
@@ -0,0 +1,64 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/fpga/xlnx,pr-decoupler.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Xilinx LogiCORE Partial Reconfig Decoupler/AXI shutdown manager Softcore
+
+maintainers:
+ - Nava kishore Manne <nava.kishore.manne@amd.com>
+
+description: |
+ The Xilinx LogiCORE Partial Reconfig(PR) Decoupler manages one or more
+ decouplers/fpga bridges. The controller can decouple/disable the bridges
+ which prevents signal changes from passing through the bridge. The controller
+ can also couple / enable the bridges which allows traffic to pass through the
+ bridge normally.
+ Xilinx LogiCORE Dynamic Function eXchange(DFX) AXI shutdown manager Softcore
+ is compatible with the Xilinx LogiCORE pr-decoupler. The Dynamic Function
+ eXchange AXI shutdown manager prevents AXI traffic from passing through the
+ bridge. The controller safely handles AXI4MM and AXI4-Lite interfaces on a
+ Reconfigurable Partition when it is undergoing dynamic reconfiguration,
+ preventing the system deadlock that can occur if AXI transactions are
+ interrupted by DFX.
+ Please refer to fpga-region.txt and fpga-bridge.txt in this directory for
+ common binding part and usage.
+
+properties:
+ compatible:
+ oneOf:
+ - items:
+ - const: xlnx,pr-decoupler-1.00
+ - const: xlnx,pr-decoupler
+ - items:
+ - const: xlnx,dfx-axi-shutdown-manager-1.00
+ - const: xlnx,dfx-axi-shutdown-manager
+
+ reg:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ clock-names:
+ items:
+ - const: aclk
+
+required:
+ - compatible
+ - reg
+ - clocks
+ - clock-names
+
+additionalProperties: false
+
+examples:
+ - |
+ fpga-bridge@100000450 {
+ compatible = "xlnx,pr-decoupler-1.00", "xlnx,pr-decoupler";
+ reg = <0x10000045 0x10>;
+ clocks = <&clkc 15>;
+ clock-names = "aclk";
+ };
+...
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3] dt-bindings: fpga: xilinx-pr-decoupler: convert bindings to json-schema
2023-02-24 11:18 [PATCH v3] dt-bindings: fpga: xilinx-pr-decoupler: convert bindings to json-schema Nava kishore Manne
@ 2023-02-24 11:22 ` Krzysztof Kozlowski
2023-03-07 22:40 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-02-24 11:22 UTC (permalink / raw)
To: Nava kishore Manne, mdf, hao.wu, yilun.xu, trix, robh+dt,
krzysztof.kozlowski+dt, michal.simek, linux-fpga, devicetree,
linux-arm-kernel, linux-kernel
On 24/02/2023 12:18, Nava kishore Manne wrote:
> Convert xilinx-pr-decoupler bindings to DT schema format using json-schema
>
> Signed-off-by: Nava kishore Manne <nava.kishore.manne@amd.com>
> ---
> Changes for v3:
> - Removed 'bridge-enable' property and addressed some minor
> comments as suggested by Krzysztof.
>
> Changes for v2:
> - Updated the description and addressed some minor comments
> as suggested by Krzysztof.
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] dt-bindings: fpga: xilinx-pr-decoupler: convert bindings to json-schema
2023-02-24 11:18 [PATCH v3] dt-bindings: fpga: xilinx-pr-decoupler: convert bindings to json-schema Nava kishore Manne
2023-02-24 11:22 ` Krzysztof Kozlowski
@ 2023-03-07 22:40 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2023-03-07 22:40 UTC (permalink / raw)
To: Nava kishore Manne
Cc: mdf, michal.simek, trix, linux-fpga, linux-kernel, robh+dt,
krzysztof.kozlowski+dt, linux-arm-kernel, hao.wu, devicetree,
yilun.xu
On Fri, 24 Feb 2023 16:48:25 +0530, Nava kishore Manne wrote:
> Convert xilinx-pr-decoupler bindings to DT schema format using json-schema
>
> Signed-off-by: Nava kishore Manne <nava.kishore.manne@amd.com>
> ---
> Changes for v3:
> - Removed 'bridge-enable' property and addressed some minor
> comments as suggested by Krzysztof.
>
> Changes for v2:
> - Updated the description and addressed some minor comments
> as suggested by Krzysztof.
>
> .../bindings/fpga/xilinx-pr-decoupler.txt | 54 ----------------
> .../bindings/fpga/xlnx,pr-decoupler.yaml | 64 +++++++++++++++++++
> 2 files changed, 64 insertions(+), 54 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt
> create mode 100644 Documentation/devicetree/bindings/fpga/xlnx,pr-decoupler.yaml
>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-07 22:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-24 11:18 [PATCH v3] dt-bindings: fpga: xilinx-pr-decoupler: convert bindings to json-schema Nava kishore Manne
2023-02-24 11:22 ` Krzysztof Kozlowski
2023-03-07 22:40 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).