Re: [PATCH 2/4] fpga: dfl: Move DFH header register macros to linux/dfl.h

From: kernel test robot <lkp@intel.com>
To: "Martin Hundebøll" <mhu@silicom.dk>, "Wu Hao" <hao.wu@intel.com>,
	"Tom Rix" <trix@redhat.com>, "Moritz Fischer" <mdf@kernel.org>,
	"Xu Yilun" <yilun.xu@intel.com>,
	"Jean Delvare" <jdelvare@suse.com>,
	"Guenter Roeck" <linux@roeck-us.net>,
	"Lee Jones" <lee.jones@linaro.org>,
	"Mark Brown" <broonie@kernel.org>
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
	"Martin Hundebøll" <mhu@geanix.com>,
	linux-fpga@vger.kernel.org
Subject: Re: [PATCH 2/4] fpga: dfl: Move DFH header register macros to linux/dfl.h
Date: Tue, 22 Jun 2021 03:33:22 +0800	[thread overview]
Message-ID: <202106220313.PQF1lSCC-lkp@intel.com> (raw)
In-Reply-To: <20210621070621.431482-3-mhu@silicom.dk>

[-- Attachment #1: Type: text/plain, Size: 2977 bytes --]

Hi "Martin,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on hwmon/hwmon-next]
[also build test ERROR on spi/for-next lee-mfd/for-mfd-next linus/master v5.13-rc7 next-20210621]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Martin-Hundeb-ll/fpga-mfd-hwmon-Initial-support-for-Silicom-N5010-PAC/20210621-150923
base:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
config: mips-randconfig-r005-20210621 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project e1adf90826a57b674eee79b071fb46c1f5683cd0)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install mips cross compiling tool for clang build
        # apt-get install binutils-mips-linux-gnu
        # https://github.com/0day-ci/linux/commit/3cd517ceee3e0bb24e44dd409f3ba2652c2ed297
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Martin-Hundeb-ll/fpga-mfd-hwmon-Initial-support-for-Silicom-N5010-PAC/20210621-150923
        git checkout 3cd517ceee3e0bb24e44dd409f3ba2652c2ed297
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from drivers/fpga/dfl.c:13:
>> include/linux/dfl.h:117:10: error: implicit declaration of function 'readq' [-Werror,-Wimplicit-function-declaration]
           u64 v = readq(base + DFH);
                   ^
   include/linux/dfl.h:126:10: error: implicit declaration of function 'readq' [-Werror,-Wimplicit-function-declaration]
           u64 v = readq(base + DFH);
                   ^
   include/linux/dfl.h:135:37: error: implicit declaration of function 'readq' [-Werror,-Wimplicit-function-declaration]
           return (u8)FIELD_GET(DFH_REVISION, readq(base + DFH));
                                              ^
   include/linux/dfl.h:135:37: error: implicit declaration of function 'readq' [-Werror,-Wimplicit-function-declaration]
   4 errors generated.

vim +/readq +117 include/linux/dfl.h

   113	
   114	/* Function to read from DFH and check if the Feature type is FME */
   115	static inline bool dfl_feature_is_fme(void __iomem *base)
   116	{
 > 117		u64 v = readq(base + DFH);
   118	
   119		return (FIELD_GET(DFH_TYPE, v) == DFH_TYPE_FIU) &&
   120			(FIELD_GET(DFH_ID, v) == DFH_ID_FIU_FME);
   121	}
   122	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 23249 bytes --]