From: "Martin Hundebøll" <martin@geanix.com>
To: Wu Hao <hao.wu@intel.com>, Tom Rix <trix@redhat.com>,
Moritz Fischer <mdf@kernel.org>, Xu Yilun <yilun.xu@intel.com>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Lee Jones <lee.jones@linaro.org>, Mark Brown <broonie@kernel.org>
Cc: "Martin Hundebøll" <mhu@silicom.dk>,
linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hwmon@vger.kernel.org, linux-spi@vger.kernel.org
Subject: [PATCH v4 2/4] spi: spi-altera-dfl: support n5010 feature revision
Date: Mon, 5 Jul 2021 12:16:43 +0200 [thread overview]
Message-ID: <20210705101645.2040106-3-martin@geanix.com> (raw)
In-Reply-To: <20210705101645.2040106-1-martin@geanix.com>
From: Martin Hundebøll <mhu@silicom.dk>
The Max10 BMC on the Silicom n5010 PAC is slightly different than the
existing BMCs, so use a dedicated feature revision detect it.
Signed-off-by: Martin Hundebøll <mhu@silicom.dk>
Reviewed-by: Moritz Fischer <mdf@kernel.org>
---
Changes since v3:
* Changed "BMC's" to "BMCs"
* Added Moritz' Reviewed-by
Changes since v2:
* None
Changes since v1:
* use feature revision from struct dfl_device instead of reading it
from io-mem
drivers/spi/spi-altera-dfl.c | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi-altera-dfl.c b/drivers/spi/spi-altera-dfl.c
index 3e32e4fe5895..f6cf7c8d9dac 100644
--- a/drivers/spi/spi-altera-dfl.c
+++ b/drivers/spi/spi-altera-dfl.c
@@ -111,6 +111,13 @@ static struct spi_board_info m10_bmc_info = {
.chip_select = 0,
};
+static struct spi_board_info m10_n5010_bmc_info = {
+ .modalias = "m10-n5010",
+ .max_speed_hz = 12500000,
+ .bus_num = 0,
+ .chip_select = 0,
+};
+
static void config_spi_master(void __iomem *base, struct spi_master *master)
{
u64 v;
@@ -130,6 +137,7 @@ static void config_spi_master(void __iomem *base, struct spi_master *master)
static int dfl_spi_altera_probe(struct dfl_device *dfl_dev)
{
+ struct spi_board_info *board_info = &m10_bmc_info;
struct device *dev = &dfl_dev->dev;
struct spi_master *master;
struct altera_spi *hw;
@@ -172,9 +180,12 @@ static int dfl_spi_altera_probe(struct dfl_device *dfl_dev)
goto exit;
}
- if (!spi_new_device(master, &m10_bmc_info)) {
+ if (dfl_dev->revision == FME_FEATURE_REV_MAX10_SPI_N5010)
+ board_info = &m10_n5010_bmc_info;
+
+ if (!spi_new_device(master, board_info)) {
dev_err(dev, "%s failed to create SPI device: %s\n",
- __func__, m10_bmc_info.modalias);
+ __func__, board_info->modalias);
}
return 0;
--
2.31.0
next prev parent reply other threads:[~2021-07-05 10:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-05 10:16 [PATCH v4 0/4] fpga/mfd/hwmon: Initial support for Silicom N5010 PAC Martin Hundebøll
2021-07-05 10:16 ` [PATCH v4 1/4] fpga: dfl: expose feature revision from struct dfl_device Martin Hundebøll
2021-07-06 14:10 ` Tom Rix
2021-07-14 11:14 ` Martin Hundebøll
2021-07-14 14:30 ` Tom Rix
2021-07-05 10:16 ` Martin Hundebøll [this message]
2021-07-06 14:56 ` [PATCH v4 2/4] spi: spi-altera-dfl: support n5010 feature revision Tom Rix
2021-07-14 11:33 ` Martin Hundebøll
2021-07-14 14:22 ` Tom Rix
2021-07-14 14:27 ` Martin Hundebøll
2021-07-05 10:16 ` [PATCH v4 3/4] mfd: intel-m10-bmc: add n5010 variant Martin Hundebøll
2021-07-05 10:16 ` [PATCH v4 4/4] hwmon: intel-m10-bmc-hwmon: add n5010 sensors Martin Hundebøll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210705101645.2040106-3-martin@geanix.com \
--to=martin@geanix.com \
--cc=broonie@kernel.org \
--cc=hao.wu@intel.com \
--cc=jdelvare@suse.com \
--cc=lee.jones@linaro.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mdf@kernel.org \
--cc=mhu@silicom.dk \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).