From: kajoljain <kjain@linux.ibm.com>
To: Moritz Fischer <mdf@kernel.org>
Cc: will@kernel.org, hao.wu@intel.com, mark.rutland@arm.com,
trix@redhat.com, yilun.xu@intel.com, luwei.kang@intel.com,
linux-fpga@vger.kernel.org, maddy@linux.vnet.ibm.com,
atrajeev@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, rnsastry@linux.ibm.com
Subject: Re: [RFC] fpga: dfl: fme: Fix cpu hotplug code
Date: Tue, 29 Jun 2021 12:44:25 +0530 [thread overview]
Message-ID: <46a6380b-e0c8-00d1-7e31-4bb8bc543438@linux.ibm.com> (raw)
In-Reply-To: <YNoXnHq+nlJhO8o6@epycbox.lan>
On 6/29/21 12:10 AM, Moritz Fischer wrote:
> On Mon, Jun 28, 2021 at 12:45:46PM +0530, Kajol Jain wrote:
>> Commit 724142f8c42a ("fpga: dfl: fme: add performance
>> reporting support") added performance reporting support
>> for FPGA management engine via perf.
>>
>> It also added cpu hotplug feature but it didn't add
>> pmu migration call in cpu offline function.
>> This can create an issue incase the current designated
>> cpu being used to collect fme pmu data got offline,
>> as based on current code we are not migrating fme pmu to
>> new target cpu. Because of that perf will still try to
>> fetch data from that offline cpu and hence we will not
>> get counter data.
>>
>> Patch fixed this issue by adding pmu_migrate_context call
>> in fme_perf_offline_cpu function.
>>
>> Fixes: 724142f8c42a ("fpga: dfl: fme: add performance reporting support")
>> Signed-off-by: Kajol Jain <kjain@linux.ibm.com>
>
> You might want to Cc: stable@vger.kernel.org if it fixes an actual bug.
Hi Moritz,
I already send patch out without RFC tag yesterday.
Link to the patch: https://lkml.org/lkml/2021/6/28/275
I will cc stable@vger.kernel.org there as suggested by you.
Thanks,
Kajol Jain
>> ---
>> drivers/fpga/dfl-fme-perf.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> ---
>> - This fix patch is not tested (as I don't have required environment).
>> But issue mentioned in the commit msg can be re-created, by starting any
>> fme_perf event and while its still running, offline current designated
>> cpu pointed by cpumask file. Since current code didn't migrating pmu,
>> perf gonna try getting counts from that offlined cpu and hence we will
>> not get event data.
>> ---
>> diff --git a/drivers/fpga/dfl-fme-perf.c b/drivers/fpga/dfl-fme-perf.c
>> index 4299145ef347..b9a54583e505 100644
>> --- a/drivers/fpga/dfl-fme-perf.c
>> +++ b/drivers/fpga/dfl-fme-perf.c
>> @@ -953,6 +953,10 @@ static int fme_perf_offline_cpu(unsigned int cpu, struct hlist_node *node)
>> return 0;
>>
>> priv->cpu = target;
>> +
>> + /* Migrate fme_perf pmu events to the new target cpu */
>> + perf_pmu_migrate_context(&priv->pmu, cpu, target);
>> +
>> return 0;
>> }
>>
>> --
>> 2.31.1
>>
> - Moritz
>
prev parent reply other threads:[~2021-06-29 7:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 7:15 [RFC] fpga: dfl: fme: Fix cpu hotplug code Kajol Jain
2021-06-28 9:01 ` Xu Yilun
2021-06-28 10:04 ` kajoljain
2021-06-28 18:40 ` Moritz Fischer
2021-06-29 7:14 ` kajoljain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46a6380b-e0c8-00d1-7e31-4bb8bc543438@linux.ibm.com \
--to=kjain@linux.ibm.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=hao.wu@intel.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=luwei.kang@intel.com \
--cc=maddy@linux.vnet.ibm.com \
--cc=mark.rutland@arm.com \
--cc=mdf@kernel.org \
--cc=rnsastry@linux.ibm.com \
--cc=trix@redhat.com \
--cc=will@kernel.org \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).