From: Alan Tull <atull@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Moritz Fischer <mdf@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-fpga@vger.kernel.org
Subject: Re: [PATCH 4/5] fpga: of-fpga-region: Use platform_set_drvdata
Date: Mon, 12 Nov 2018 09:48:00 -0600 [thread overview]
Message-ID: <CANk1AXSr1xdqfmyNeN6Jc-OnZhDqbL+C2Uz_j37NGopVRWNj6g@mail.gmail.com> (raw)
In-Reply-To: <20180930154921.GB13200@kroah.com>
On Sun, Sep 30, 2018 at 10:49 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
Hi Greg,
>
> On Wed, Sep 12, 2018 at 09:43:26AM -0500, Alan Tull wrote:
> > From: Moritz Fischer <mdf@kernel.org>
> >
> > Use platform_set_drvdata rather than dev_set_drvdata
> > to match the platform_get_drvdata in the _remove()
> > function of the platform driver.
> >
> > Signed-off-by: Moritz Fischer <mdf@kernel.org>
> > Acked-by: Alan Tull <atull@kernel.org>
> > ---
> > drivers/fpga/of-fpga-region.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/fpga/of-fpga-region.c b/drivers/fpga/of-fpga-region.c
> > index 052a134..d6a70e4 100644
> > --- a/drivers/fpga/of-fpga-region.c
> > +++ b/drivers/fpga/of-fpga-region.c
> > @@ -421,7 +421,7 @@ static int of_fpga_region_probe(struct platform_device *pdev)
> > goto eprobe_free;
> >
> > of_platform_populate(np, fpga_region_of_match, NULL, ®ion->dev);
> > - dev_set_drvdata(dev, region);
> > + platform_set_drvdata(pdev, region);
>
> Again, not really a bugfix :)
Could you take this patch 4/5 (just sent a reminder for 5/5)?
Thanks
Alan
next prev parent reply other threads:[~2018-11-12 15:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 14:43 [PATCH 0/5] fpga: patches for v4.19 Alan Tull
2018-09-12 14:43 ` [PATCH 1/5] fpga: do not access region struct after fpga_region_unregister Alan Tull
2018-09-12 14:43 ` [PATCH 2/5] fpga: bridge: fix obvious function documentation error Alan Tull
2018-09-12 14:43 ` [PATCH 3/5] docs: fpga: document fpga manager flags Alan Tull
2018-09-12 14:43 ` [PATCH 4/5] fpga: of-fpga-region: Use platform_set_drvdata Alan Tull
2018-09-30 15:49 ` Greg Kroah-Hartman
2018-11-12 15:48 ` Alan Tull [this message]
2018-09-12 14:43 ` [PATCH 5/5] fpga: dfl-fme-region: Use platform_get_drvdata() Alan Tull
2018-09-30 15:48 ` Greg Kroah-Hartman
2018-11-12 15:46 ` Alan Tull
2018-11-12 18:02 ` Greg Kroah-Hartman
2018-11-12 19:39 ` Alan Tull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANk1AXSr1xdqfmyNeN6Jc-OnZhDqbL+C2Uz_j37NGopVRWNj6g@mail.gmail.com \
--to=atull@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).