linux-fpga.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: richard.gong@linux.intel.com
Cc: mdf@kernel.org, trix@redhat.com, linux-fpga@vger.kernel.org,
	linux-kernel@vger.kernel.org, dinguyen@kernel.org,
	sridhar.rajagopal@intel.com,
	Richard Gong <richard.gong@intel.com>
Subject: Re: [PATCHv3 1/6] firmware: stratix10-svc: add COMMAND_AUTHENTICATE_BITSTREAM flag
Date: Wed, 27 Jan 2021 13:04:55 +0100	[thread overview]
Message-ID: <YBFW50LPP/yEbvEW@kroah.com> (raw)
In-Reply-To: <1611608188-25621-2-git-send-email-richard.gong@linux.intel.com>

On Mon, Jan 25, 2021 at 02:56:23PM -0600, richard.gong@linux.intel.com wrote:
> From: Richard Gong <richard.gong@intel.com>
> 
> Add COMMAND_AUTHENTICATE_BITSTREAM command flag for new added bitstream
> authentication feature. Authenticating a bitstream is to make sure a signed
> bitstream has the valid signatures.
> 
> Except for the actual configuration of the device, the bitstream
> authentication works the same way as FPGA configuration does. If the
> authentication passes, the signed bitstream will be programmed into QSPI
> flash memory and will be expected to boot without issues.
> 
> Clean up COMMAND_RECONFIG_FLAG_PARTIAL flag by resetting it to 0, which
> aligns with the firmware settings.
> 
> Signed-off-by: Richard Gong <richard.gong@intel.com>
> ---
> v3: no change
> v2: new added
> ---
>  include/linux/firmware/intel/stratix10-svc-client.h | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/include/linux/firmware/intel/stratix10-svc-client.h b/include/linux/firmware/intel/stratix10-svc-client.h
> index ebc2956..7ada1f2 100644
> --- a/include/linux/firmware/intel/stratix10-svc-client.h
> +++ b/include/linux/firmware/intel/stratix10-svc-client.h
> @@ -51,12 +51,17 @@
>  #define SVC_STATUS_NO_SUPPORT		6
>  
>  /*
> - * Flag bit for COMMAND_RECONFIG
> + * Flag for COMMAND_RECONFIG, in bit number
>   *
>   * COMMAND_RECONFIG_FLAG_PARTIAL:
> - * Set to FPGA configuration type (full or partial).
> + * Set for partial FPGA configuration.
> + *
> + * COMMAND_AUTHENTICATE_BITSTREAM:
> + * Set for bitstream authentication, which makes sure a signed bitstream
> + * has valid signatures before committing it to QSPI flash memory.
>   */
> -#define COMMAND_RECONFIG_FLAG_PARTIAL	1
> +#define COMMAND_RECONFIG_FLAG_PARTIAL	0

So is this a bugfix, changing this value to the correct one?

If so, shouldn't this be a stand-alone patch and get backported to
stable kernel releases?

If not, then no one uses this flag today?

thanks,

greg k-h

  parent reply	other threads:[~2021-01-27 12:07 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-25 20:56 [PATCHv3 0/6] [PATCHv3 0/6] Extend Intel service layer, FPGA manager and region richard.gong
2021-01-25 20:56 ` [PATCHv3 1/6] firmware: stratix10-svc: add COMMAND_AUTHENTICATE_BITSTREAM flag richard.gong
2021-01-25 22:56   ` Tom Rix
2021-01-26  2:16     ` Richard Gong
2021-01-27 12:04   ` Greg KH [this message]
2021-01-27 13:05     ` Richard Gong
2021-01-27 21:41       ` Moritz Fischer
2021-01-27 23:02         ` Richard Gong
2021-01-25 20:56 ` [PATCHv3 2/6] firmware: stratix10-svc: extend SVC driver to get the firmware version richard.gong
2021-01-26  5:01   ` Moritz Fischer
2021-01-26 13:37     ` Richard Gong
2021-01-25 20:56 ` [PATCHv3 3/6] fpga: fpga-mgr: add FPGA_MGR_BITSTREM_AUTHENTICATION flag richard.gong
2021-01-26  5:04   ` Moritz Fischer
2021-01-26 13:38     ` Richard Gong
2021-01-25 20:56 ` [PATCHv3 4/6] fpga: of-fpga-region: add authenticate-fpga-config property richard.gong
2021-01-26  5:10   ` Moritz Fischer
2021-01-26 14:03     ` Richard Gong
2021-01-25 20:56 ` [PATCHv3 5/6] dt-bindings: fpga: " richard.gong
2021-01-26  5:05   ` Moritz Fischer
2021-01-26 13:58     ` Richard Gong
2021-01-25 20:56 ` [PATCHv3 6/6] fpga: stratix10-soc: extend driver for bitstream authentication richard.gong
2021-01-26  5:09   ` Moritz Fischer
2021-01-26 14:00     ` Richard Gong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YBFW50LPP/yEbvEW@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dinguyen@kernel.org \
    --cc=linux-fpga@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mdf@kernel.org \
    --cc=richard.gong@intel.com \
    --cc=richard.gong@linux.intel.com \
    --cc=sridhar.rajagopal@intel.com \
    --cc=trix@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).