From: Richard Gong <richard.gong@linux.intel.com>
To: Moritz Fischer <mdf@kernel.org>
Cc: trix@redhat.com, gregkh@linuxfoundation.org,
linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org,
dinguyen@kernel.org, sridhar.rajagopal@intel.com,
Richard Gong <richard.gong@intel.com>
Subject: Re: [PATCHv3 3/6] fpga: fpga-mgr: add FPGA_MGR_BITSTREM_AUTHENTICATION flag
Date: Tue, 26 Jan 2021 07:38:44 -0600 [thread overview]
Message-ID: <cfbcf19c-bb76-59f2-5401-8ab242b9e02e@linux.intel.com> (raw)
In-Reply-To: <YA+iyFi4lQWPgkTQ@epycbox.lan>
Hi Moritz,
On 1/25/21 11:04 PM, Moritz Fischer wrote:
> On Mon, Jan 25, 2021 at 02:56:25PM -0600, richard.gong@linux.intel.com wrote:
>> From: Richard Gong <richard.gong@intel.com>
>>
>> Add FPGA_MGR_BITSTREM_AUTHENTICATION flag for FPGA bitstream
>> authentication, which makes sure a signed bitstream has valid signatures.
>>
>> Except for the actual configuration of the device, the authentication works
>> the same way as FPGA configuration does. If the authentication passes, the
>> bitstream will be programmed into QSPI flash and will be expected to boot
>> without issues.
>>
>> Signed-off-by: Richard Gong <richard.gong@intel.com>
>> ---
>> v3: no change
>> v2: align all FPGA_MGR_* flags
>> update the commit messages
>> ---
>> include/linux/fpga/fpga-mgr.h | 13 ++++++++-----
>> 1 file changed, 8 insertions(+), 5 deletions(-)
>>
>> diff --git a/include/linux/fpga/fpga-mgr.h b/include/linux/fpga/fpga-mgr.h
>> index 2bc3030..4fb3400 100644
>> --- a/include/linux/fpga/fpga-mgr.h
>> +++ b/include/linux/fpga/fpga-mgr.h
>> @@ -67,12 +67,15 @@ enum fpga_mgr_states {
>> * %FPGA_MGR_BITSTREAM_LSB_FIRST: SPI bitstream bit order is LSB first
>> *
>> * %FPGA_MGR_COMPRESSED_BITSTREAM: FPGA bitstream is compressed
>> + *
>> + * %FPGA_MGR_BITSTREM_AUTHENTICATION: do FPGA bitstream authentication only
>> */
>> -#define FPGA_MGR_PARTIAL_RECONFIG BIT(0)
>> -#define FPGA_MGR_EXTERNAL_CONFIG BIT(1)
>> -#define FPGA_MGR_ENCRYPTED_BITSTREAM BIT(2)
>> -#define FPGA_MGR_BITSTREAM_LSB_FIRST BIT(3)
>> -#define FPGA_MGR_COMPRESSED_BITSTREAM BIT(4)
>> +#define FPGA_MGR_PARTIAL_RECONFIG BIT(0)
>> +#define FPGA_MGR_EXTERNAL_CONFIG BIT(1)
>> +#define FPGA_MGR_ENCRYPTED_BITSTREAM BIT(2)
>> +#define FPGA_MGR_BITSTREAM_LSB_FIRST BIT(3)
>> +#define FPGA_MGR_COMPRESSED_BITSTREAM BIT(4)
>> +#define FPGA_MGR_BITSTREM_AUTHENTICATION BIT(5)
> Consider FPGA_MGR_BITSTREAM_AUTHENTICATE (and fix typo)
Thanks, I will correct that in next submission.
>>
>> /**
>> * struct fpga_image_info - information specific to a FPGA image
>> --
>> 2.7.4
>>
>
> Thanks,
> Moritz
>
Regards,
Richard
next prev parent reply other threads:[~2021-01-26 13:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 20:56 [PATCHv3 0/6] [PATCHv3 0/6] Extend Intel service layer, FPGA manager and region richard.gong
2021-01-25 20:56 ` [PATCHv3 1/6] firmware: stratix10-svc: add COMMAND_AUTHENTICATE_BITSTREAM flag richard.gong
2021-01-25 22:56 ` Tom Rix
2021-01-26 2:16 ` Richard Gong
2021-01-27 12:04 ` Greg KH
2021-01-27 13:05 ` Richard Gong
2021-01-27 21:41 ` Moritz Fischer
2021-01-27 23:02 ` Richard Gong
2021-01-25 20:56 ` [PATCHv3 2/6] firmware: stratix10-svc: extend SVC driver to get the firmware version richard.gong
2021-01-26 5:01 ` Moritz Fischer
2021-01-26 13:37 ` Richard Gong
2021-01-25 20:56 ` [PATCHv3 3/6] fpga: fpga-mgr: add FPGA_MGR_BITSTREM_AUTHENTICATION flag richard.gong
2021-01-26 5:04 ` Moritz Fischer
2021-01-26 13:38 ` Richard Gong [this message]
2021-01-25 20:56 ` [PATCHv3 4/6] fpga: of-fpga-region: add authenticate-fpga-config property richard.gong
2021-01-26 5:10 ` Moritz Fischer
2021-01-26 14:03 ` Richard Gong
2021-01-25 20:56 ` [PATCHv3 5/6] dt-bindings: fpga: " richard.gong
2021-01-26 5:05 ` Moritz Fischer
2021-01-26 13:58 ` Richard Gong
2021-01-25 20:56 ` [PATCHv3 6/6] fpga: stratix10-soc: extend driver for bitstream authentication richard.gong
2021-01-26 5:09 ` Moritz Fischer
2021-01-26 14:00 ` Richard Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfbcf19c-bb76-59f2-5401-8ab242b9e02e@linux.intel.com \
--to=richard.gong@linux.intel.com \
--cc=dinguyen@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=richard.gong@intel.com \
--cc=sridhar.rajagopal@intel.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).